New issue
Advanced search Search tips

Issue 634140 link

Starred by 2 users
Status: Assigned
Owner:
rdevlin....@chromium.org
Cc:
karandeepb@chromium.org
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 648275
issue 829174


Sign in to add a comment

Clean up extension function implementations

Project Member Reported by rdevlin....@chromium.org, Aug 3 2016 
There are a bunch of (non-api-specific) ExtensionFunction implementations, but it'd be great to get it down to only a handful.  In theory, we might even be able to reduce this down to UIThread and IOThread variants.  At minimum, we should strive to get rid of the Sync vs Async versions, which confuse people to no end.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1

commit 2202833e0d6f23b24e9c8ecd8fec2a262895c3e1
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Aug 04 16:38:11 2016

[Extensions] Remove SyncIOThreadExtensionFunction

ExtensionFunction has umpteen different implementations, when really there
should only be handful (maybe just UIThread and IOThread variants). Remove one
of them to start making a dent.

BUG=634140

Review-Url: https://codereview.chromium.org/2204363002
Cr-Commit-Position: refs/heads/master@{#409807}

[modify] https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1/extensions/browser/api/web_request/web_request_api.h
[modify] https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1/extensions/browser/extension_function.cc
[modify] https://crrev.com/2202833e0d6f23b24e9c8ecd8fec2a262895c3e1/extensions/browser/extension_function.h
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f86d207a9b2f7644d74f4509369611eee41a98

commit d4f86d207a9b2f7644d74f4509369611eee41a98
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Aug 18 21:21:38 2016

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- info_private_api
- wallpaper_private_api
- command_line_private_api
- tts_engine_extension_api
- app_current_window_internal_api
- audio_api

BUG=634140

Review-Url: https://codereview.chromium.org/2236703002
Cr-Commit-Position: refs/heads/master@{#412930}

[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/chromeos/extensions/info_private_api.h
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/chromeos/extensions/wallpaper_private_api.h
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/extensions/api/command_line_private/command_line_private_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/extensions/api/command_line_private/command_line_private_api.h
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/speech/extension_api/tts_engine_extension_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/chrome/browser/speech/extension_api/tts_engine_extension_api.h
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.h
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/extensions/browser/api/audio/audio_api.cc
[modify] https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98/extensions/browser/api/audio/audio_api.h
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c448a7d036621333de42066bd5a8a06982ad87a

commit 0c448a7d036621333de42066bd5a8a06982ad87a
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Aug 25 03:14:56 2016

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- management
- metrics_private
- system_private
- networking_private
- power

BUG=634140

Review-Url: https://codereview.chromium.org/2261313002
Cr-Commit-Position: refs/heads/master@{#414284}

[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/management/chrome_management_api_delegate.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/metrics_private/metrics_private_api.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/system_private/system_private_api.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/chrome/browser/extensions/api/system_private/system_private_api.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/management/management_api.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/management/management_api_delegate.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/networking_private/networking_private_api.h
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a/extensions/browser/api/power/power_api.h
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/747c4ef945c423752e5e4b8de39b62c5caa69390

commit 747c4ef945c423752e5e4b8de39b62c5caa69390
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Aug 26 22:22:59 2016

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- tab_capture
- virtual_keyboard_private

BUG=634140

Review-Url: https://codereview.chromium.org/2272563011
Cr-Commit-Position: refs/heads/master@{#414832}

[modify] https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
[modify] https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390/chrome/browser/extensions/api/tab_capture/tab_capture_api.h
[modify] https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
[modify] https://crrev.com/747c4ef945c423752e5e4b8de39b62c5caa69390/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a2445fd9dacd5d11f906cec52b85b24b929146

commit 94a2445fd9dacd5d11f906cec52b85b24b929146
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Aug 30 05:40:29 2016

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140

Review-Url: https://codereview.chromium.org/2285573002
Cr-Commit-Position: refs/heads/master@{#415170}

[modify] https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h
[modify] https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h
[modify] https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146/chrome/test/data/extensions/api_test/input_ime/background.js
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c3ad865920504d33eadf8ff87e9719322a38b3

commit f4c3ad865920504d33eadf8ff87e9719322a38b3
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Aug 30 22:55:07 2016

[Extensions] Remove SyncExtensionFunction

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunction.

BUG=634140

Review-Url: https://codereview.chromium.org/2294943002
Cr-Commit-Position: refs/heads/master@{#415475}

[modify] https://crrev.com/f4c3ad865920504d33eadf8ff87e9719322a38b3/extensions/browser/extension_function.cc
[modify] https://crrev.com/f4c3ad865920504d33eadf8ff87e9719322a38b3/extensions/browser/extension_function.h
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3223122d168e31a55dae986cf35b34e08168352d

commit 3223122d168e31a55dae986cf35b34e08168352d
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Sep 07 21:27:26 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- accessibility_extension
- echo_private
- first_run_private
- browser
- browsing_data
- commands
- developer_private
- font_settings
- chrome_direct_setting

BUG=634140

Review-Url: https://codereview.chromium.org/2298493003
Cr-Commit-Position: refs/heads/master@{#417041}

[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/accessibility/accessibility_extension_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/chromeos/extensions/echo_private_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/chromeos/extensions/echo_private_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/chromeos/extensions/first_run_private_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/chromeos/extensions/first_run_private_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/browser/browser_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/browser/browser_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/browsing_data/browsing_data_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/commands/commands.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/commands/commands.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/developer_private/developer_private_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/font_settings/font_settings_api.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/preference/chrome_direct_setting.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/api/preference/chrome_direct_setting.h
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d/chrome/browser/extensions/extension_tab_util.h
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f79e504bceef52d751cf28ed49c6de4a34fdeb4

commit 8f79e504bceef52d751cf28ed49c6de4a34fdeb4
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Sep 09 19:07:03 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- cookies
- desktop_capture
- downloads
- module

BUG=634140

Review-Url: https://codereview.chromium.org/2327723002
Cr-Commit-Position: refs/heads/master@{#417656}

[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/cookies/cookies_api.h
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/downloads/downloads_api.h
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/module/module.cc
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/chrome/browser/extensions/api/module/module.h
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/extensions/browser/extension_function.cc
[modify] https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4/extensions/browser/extension_function.h
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46ef7309a36681bb8d59b96a9f8b6daddad3d95

commit e46ef7309a36681bb8d59b96a9f8b6daddad3d95
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Sep 09 19:25:37 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- autotest_private
- content_settings
- context_menus

BUG=634140

Review-Url: https://codereview.chromium.org/2328643003
Cr-Commit-Position: refs/heads/master@{#417666}

[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/autotest_private/autotest_private_api.h
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/content_settings/content_settings_api.h
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/context_menus/context_menus_api.cc
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/context_menus/context_menus_api.h
[modify] https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95/chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1cf9883e1db32dbd97d62af04240d247d91cc9

commit 7c1cf9883e1db32dbd97d62af04240d247d91cc9
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Sep 14 18:18:40 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- feedback_private
- file_manager/private_api_drive
- file_manager/private_api_misc
- file_manager/private_api_strings
- file_manager/private_api_tasks
- file_system
- file_system_provider

BUG=634140

Review-Url: https://codereview.chromium.org/2335213004
Cr-Commit-Position: refs/heads/master@{#418613}

[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_strings.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/7c1cf9883e1db32dbd97d62af04240d247d91cc9/chrome/browser/extensions/api/file_system/file_system_api.h
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94676744596ef4b4a20aef05fbfc4e2e40747f28

commit 94676744596ef4b4a20aef05fbfc4e2e40747f28
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Sep 15 00:54:39 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- launcher_search_provider
- hotword_private
- i18n
- identity
- omnibox

BUG=634140

Review-Url: https://codereview.chromium.org/2344653002
Cr-Commit-Position: refs/heads/master@{#418733}

[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/chromeos/extensions/launcher_search_provider.cc
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/chromeos/extensions/launcher_search_provider.h
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/hotword_private/hotword_private_api.h
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/i18n/i18n_api.cc
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/i18n/i18n_api.h
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/identity/identity_api.h
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/omnibox/omnibox_api.cc
[modify] https://crrev.com/94676744596ef4b4a20aef05fbfc4e2e40747f28/chrome/browser/extensions/api/omnibox/omnibox_api.h

Comment 13 by rdevlin....@chromium.org, Sep 19 2016

Blockedon: 648275
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6458eb87e45739312f88a36942062c009070f1d6

commit 6458eb87e45739312f88a36942062c009070f1d6
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Oct 06 23:28:19 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- tabs

BUG=634140

Review-Url: https://codereview.chromium.org/2398793002
Cr-Commit-Position: refs/heads/master@{#423733}

[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_api.h
[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_test.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0f52a702314185fefb7234c9179a8238b79c99

commit 4d0f52a702314185fefb7234c9179a8238b79c99
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Oct 07 23:14:32 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- permissions
- screenlock_private
- signed_in_devices
- sync_file_system
- tab_catpure
- web_navigation

BUG=634140

Review-Url: https://codereview.chromium.org/2399423004
Cr-Commit-Position: refs/heads/master@{#424004}

[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/permissions/permissions_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/permissions/permissions_api.h
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/tab_capture/tab_capture_api.h
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/4d0f52a702314185fefb7234c9179a8238b79c99/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d

commit 2ef2539bb09e6e73fb0850be03ad5a38658b6f4d
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 10 16:34:25 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- extension_action
- file_system_provider

BUG=634140

Review-Url: https://codereview.chromium.org/2408483002
Cr-Commit-Position: refs/heads/master@{#424168}

[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h
[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc
[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h
[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d/chrome/browser/extensions/api/extension_action/extension_action_api.h
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27e26a673238a2833f8df02abacc2cc99a99b345

commit 27e26a673238a2833f8df02abacc2cc99a99b345
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 10 18:58:48 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- tts

BUG=634140

Review-Url: https://codereview.chromium.org/2409643002
Cr-Commit-Position: refs/heads/master@{#424201}

[modify] https://crrev.com/27e26a673238a2833f8df02abacc2cc99a99b345/chrome/browser/speech/extension_api/tts_extension_api.cc
[modify] https://crrev.com/27e26a673238a2833f8df02abacc2cc99a99b345/chrome/browser/speech/extension_api/tts_extension_api.h
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/456b28325156d9aa526d2c2fc02cb5ffedb07b4b

commit 456b28325156d9aa526d2c2fc02cb5ffedb07b4b
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 10 20:20:21 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- preference
- sessions

BUG=634140

Review-Url: https://codereview.chromium.org/2408763002
Cr-Commit-Position: refs/heads/master@{#424219}

[modify] https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b/chrome/browser/extensions/api/preference/preference_api.h
[modify] https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b/chrome/browser/extensions/api/sessions/sessions_api.h
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70e53eb4a624fe91dd95fc227d0936287f71022

commit b70e53eb4a624fe91dd95fc227d0936287f71022
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Tue Oct 11 00:23:06 2016

[Extensions] Remove ChromeSyncExtensionFunction

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunction.

BUG=634140

Review-Url: https://codereview.chromium.org/2404013002
Cr-Commit-Position: refs/heads/master@{#424301}

[modify] https://crrev.com/b70e53eb4a624fe91dd95fc227d0936287f71022/chrome/browser/extensions/chrome_extension_function.cc
[modify] https://crrev.com/b70e53eb4a624fe91dd95fc227d0936287f71022/chrome/browser/extensions/chrome_extension_function.h
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6458eb87e45739312f88a36942062c009070f1d6

commit 6458eb87e45739312f88a36942062c009070f1d6
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Oct 06 23:28:19 2016

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- tabs

BUG=634140

Review-Url: https://codereview.chromium.org/2398793002
Cr-Commit-Position: refs/heads/master@{#423733}

[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_api.h
[modify] https://crrev.com/6458eb87e45739312f88a36942062c009070f1d6/chrome/browser/extensions/api/tabs/tabs_test.cc

Comment 21 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 22 by rdevlin....@chromium.org, Feb 14 2017

Cc: -asargent@chromium.org karandeepb@chromium.org
karandeep@, here's a long-term bug that's good to work towards when you're between tasks.
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9eee22c0bb92ce804a0325118e9f0d36a1de92

commit bd9eee22c0bb92ce804a0325118e9f0d36a1de92
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jan 11 16:43:38 2018

[Extensions Functions] Migrate PlatformKeys to UIThreadExtensionFunction

Migrate the platformKeys API to use UIThreadExtensionFunction instead of
of ChromeUIThreadExtensionFunction.

Bug: 634140
Change-Id: Ife58395413968a783f791cbd93c6044e1a095417
Reviewed-on: https://chromium-review.googlesource.com/857893
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528642}
[modify] https://crrev.com/bd9eee22c0bb92ce804a0325118e9f0d36a1de92/chrome/browser/extensions/api/platform_keys/platform_keys_api.h
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b191e9e6c3bb8185be573ba461f0433f149e4f66

commit b191e9e6c3bb8185be573ba461f0433f149e4f66
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Wed Jan 17 20:43:55 2018

[Extensions Functions] Migrate DeveloperPrivate to UIThreadExtensionFunction

Migrate the developerPrivate API to use UIThreadExtensionFunction instead
of ChromeUIThreadExtensionFunction.

Bug: 634140
Change-Id: I4e509621238a341caa7b53388f5f98c4935a57f9
Reviewed-on: https://chromium-review.googlesource.com/857899
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529878}
[modify] https://crrev.com/b191e9e6c3bb8185be573ba461f0433f149e4f66/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/b191e9e6c3bb8185be573ba461f0433f149e4f66/chrome/browser/extensions/api/developer_private/developer_private_api.h
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1985e78b98762a0c37af9dac0fcc1e32ddf9dda

commit e1985e78b98762a0c37af9dac0fcc1e32ddf9dda
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Jan 23 01:27:39 2018

[Extensions Functions] Migrate Automation to UIThreadExtensionFunction

Migrate the automation API to use UIThreadExtensionFunction instead of
ChromeUIThreadExtensionFunction.

Bug: 634140
Change-Id: Icf4d8709b4b21376e56e16c2351e72018c0522d2
Reviewed-on: https://chromium-review.googlesource.com/857936
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531110}
[modify] https://crrev.com/e1985e78b98762a0c37af9dac0fcc1e32ddf9dda/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e1985e78b98762a0c37af9dac0fcc1e32ddf9dda/chrome/browser/extensions/api/automation_internal/automation_internal_api.h
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557d783c745d8e1d6ba66fe1e6f992681a802f78

commit 557d783c745d8e1d6ba66fe1e6f992681a802f78
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jan 25 15:57:25 2018

[Extensions] Remove ChromeUIThreadExtensionFunction

There are no more uses of ChromeUIThreadExtensionFunction. Remove it,
and have ChromeAsyncExtensionFunction inherit directly from
UIThreadExtensionFunction.

Bug: 634140

Change-Id: I5a941792a8d1e2ee07d0603903c7ca52daab65ef
Reviewed-on: https://chromium-review.googlesource.com/883976
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531907}
[modify] https://crrev.com/557d783c745d8e1d6ba66fe1e6f992681a802f78/chrome/browser/extensions/chrome_extension_function.cc
[modify] https://crrev.com/557d783c745d8e1d6ba66fe1e6f992681a802f78/chrome/browser/extensions/chrome_extension_function.h
Project Member

Comment 28 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef78a87a98e35103f8f8be2f4501acc485174e9

commit 4ef78a87a98e35103f8f8be2f4501acc485174e9
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Feb 08 00:34:42 2018

[Extension Functions] Move GetCurrentBrowser to details only

Remove ChromeAsyncExtensionFunction::GetCurrentBrowser() and update
callers to always use
ChromeExtensionFunctionDetails::GetCurrentBrowser(). This is
functionally the same as what was happening before, but now we don't
have to duplicate the function (and very long comment) in both
chrome_extension_function and chrome_extension_function_details.

No behavior change.

Bug: 809194
Bug: 634140

Change-Id: I4379fc0c2d22800ceed7c6355828719ec81cde1b
Reviewed-on: https://chromium-review.googlesource.com/902086
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535214}
[modify] https://crrev.com/4ef78a87a98e35103f8f8be2f4501acc485174e9/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc
[modify] https://crrev.com/4ef78a87a98e35103f8f8be2f4501acc485174e9/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/4ef78a87a98e35103f8f8be2f4501acc485174e9/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/4ef78a87a98e35103f8f8be2f4501acc485174e9/chrome/browser/extensions/chrome_extension_function.cc
[modify] https://crrev.com/4ef78a87a98e35103f8f8be2f4501acc485174e9/chrome/browser/extensions/chrome_extension_function.h

Comment 29 by catmulli...@chromium.org, Feb 8 2018

Cc: -catmulli...@chromium.org

Comment 30 by lazyboy@chromium.org, Apr 5 2018

Blockedon: 829174
Project Member

Comment 31 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b089c4c04ca4bb7c62d616a6a32c92f38928275

commit 4b089c4c04ca4bb7c62d616a6a32c92f38928275
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon May 21 22:01:49 2018

[Extensions Functions] Migrate Cloud Print to UIThreadExtensionFunction

Migrate the cloud print API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: Ic80be088ff5185a441a87b716227aef1433e5623
Reviewed-on: https://chromium-review.googlesource.com/1066817
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560370}
[modify] https://crrev.com/4b089c4c04ca4bb7c62d616a6a32c92f38928275/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
[modify] https://crrev.com/4b089c4c04ca4bb7c62d616a6a32c92f38928275/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
Project Member

Comment 32 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53e9ed9f83167b8791920b50f1239ac94fa4d89f

commit 53e9ed9f83167b8791920b50f1239ac94fa4d89f
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 22 15:54:24 2018

[Extensions Functions] Migrate TopSites API to UIThreadExtensionFunction

Migrate the topSites API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Also fix a bug where if the results were not immediately ready, the
function would never respond.

Bug: 634140
Change-Id: I4fef4e12878ce8cfc62ad8152805b72d18f91885
Reviewed-on: https://chromium-review.googlesource.com/1067488
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560612}
[modify] https://crrev.com/53e9ed9f83167b8791920b50f1239ac94fa4d89f/chrome/browser/extensions/api/top_sites/top_sites_api.cc
[modify] https://crrev.com/53e9ed9f83167b8791920b50f1239ac94fa4d89f/chrome/browser/extensions/api/top_sites/top_sites_api.h
Project Member

Comment 33 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f8ef8b55a482b4d13d4f8cc2cd97e8cae85f38b

commit 6f8ef8b55a482b4d13d4f8cc2cd97e8cae85f38b
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 22 17:45:07 2018

[Extensions Functions] Migrate Permissions API to UIThreadExtensionFunction

Migrate the permissions API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Note: there is a small behavior difference here where the API will no
longer return `false` if there is an error (and runtime.lastError will be
set). Functions should not return both a result and an error.

Bug: 634140
Change-Id: I7dbdc3a9c99f0f51ef96189667abc65528c407fa
Reviewed-on: https://chromium-review.googlesource.com/1067510
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560690}
[modify] https://crrev.com/6f8ef8b55a482b4d13d4f8cc2cd97e8cae85f38b/chrome/browser/extensions/api/permissions/permissions_api.cc
[modify] https://crrev.com/6f8ef8b55a482b4d13d4f8cc2cd97e8cae85f38b/chrome/browser/extensions/api/permissions/permissions_api.h
Project Member

Comment 34 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14fef327aca711b85d0fcf4731450b67dd9bd0fe

commit 14fef327aca711b85d0fcf4731450b67dd9bd0fe
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 22 17:56:55 2018

[Extensions Functions] Migrate BrowserAction API to UIThreadExtensionFunction

Migrate the browserAction API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: Ic6af918ee5a3c968ad5afb6ec0d3700d450be0b9
Reviewed-on: https://chromium-review.googlesource.com/1067484
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560696}
[modify] https://crrev.com/14fef327aca711b85d0fcf4731450b67dd9bd0fe/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/14fef327aca711b85d0fcf4731450b67dd9bd0fe/chrome/browser/extensions/api/extension_action/extension_action_api.h
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d94dbd12c60ad68f542ad0416a13aaf71a207aa

commit 1d94dbd12c60ad68f542ad0416a13aaf71a207aa
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Jun 05 01:32:19 2018

[Extensions  Functions] Migrate Tabs API to UIThreadExtensionFunction

Migrate the tabs API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: If814f2b4040ec5d38d7e61368c3826ad171ea4dd
Reviewed-on: https://chromium-review.googlesource.com/1067481
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564336}
[modify] https://crrev.com/1d94dbd12c60ad68f542ad0416a13aaf71a207aa/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/1d94dbd12c60ad68f542ad0416a13aaf71a207aa/chrome/browser/extensions/api/tabs/tabs_api.h
Project Member

Comment 36 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf48fda83d730adf2009bb2ba47d5da77ce68f4d

commit cf48fda83d730adf2009bb2ba47d5da77ce68f4d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Jun 05 01:33:23 2018

[Extensions Functions] Migrate Cookies to UIThreadExtensionFunction

Migrate the cookies API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: Iad15634409a717033b9dc8e74adecf88a4dbb572
Reviewed-on: https://chromium-review.googlesource.com/1062957
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564338}
[modify] https://crrev.com/cf48fda83d730adf2009bb2ba47d5da77ce68f4d/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/cf48fda83d730adf2009bb2ba47d5da77ce68f4d/chrome/browser/extensions/api/cookies/cookies_api.h
►

Sign in to add a comment