Integer-overflow in SkIRect::height |
||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5459706661568512 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: SkIRect::height gfx::SkIRectToRect cc::MapRectInternal Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=398502:398570 Minimized Testcase (0.65 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97LeUrZj9bpIqdVQeIMfq8XbxSYqzZE0YeC0t7NObilz7NrF2pHhGQQ8KRIZF1sM3B5EwX3wmgtZzJr_coQ2pSpchHI0VwPP3i6PNN8Y18i1jlFPhAbWdv83Z2vy_drze22pxDlt2aoa6V7o0GQPXO21eCcsg?testcase_id=5459706661568512 Filer: mummareddy See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Aug 3 2016
So there is a very large SkIRect, such that fBottom - fTop overflows (it's larger than std::numeric_limits<int>::max()). It's not obvious to me who should be handling this, if anyone. Should SkIRect::height be doing something if the result is not representable, or is it gfx's responsibility to not call SkIRect::height in that case, or should someone else (i.e. cc's filter code) be checking for this this? cc danakj for ui/gfx/, reed for skia; thoughts?
,
Aug 5 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1704b2b984c977e47116e978db7465beaa8a65d commit a1704b2b984c977e47116e978db7465beaa8a65d Author: jbroman <jbroman@chromium.org> Date: Tue Aug 23 17:22:00 2016 Use CheckedNumeric when converting SkIRect to gfx::Rect. BUG= 634134 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2231243002 Cr-Commit-Position: refs/heads/master@{#413769} [modify] https://crrev.com/a1704b2b984c977e47116e978db7465beaa8a65d/cc/output/filter_operations_unittest.cc [modify] https://crrev.com/a1704b2b984c977e47116e978db7465beaa8a65d/ui/gfx/skia_util.cc [modify] https://crrev.com/a1704b2b984c977e47116e978db7465beaa8a65d/ui/gfx/skrect_conversion_unittest.cc
,
Aug 24 2016
ClusterFuzz has detected this issue as fixed in range 413737:413785. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5459706661568512 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: SkIRect::height gfx::SkIRectToRect cc::MapRectInternal Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=398502:398570 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=413737:413785 Minimized Testcase (0.65 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97LeUrZj9bpIqdVQeIMfq8XbxSYqzZE0YeC0t7NObilz7NrF2pHhGQQ8KRIZF1sM3B5EwX3wmgtZzJr_coQ2pSpchHI0VwPP3i6PNN8Y18i1jlFPhAbWdv83Z2vy_drze22pxDlt2aoa6V7o0GQPXO21eCcsg?testcase_id=5459706661568512 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Aug 24 2016
ClusterFuzz testcase is verified as fixed, closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Oct 18 2016
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mummare...@chromium.org
, Aug 3 2016Labels: Te-Logged M-53
Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)