New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634120 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use transferSize to generate % cached resources per page load

Project Member Reported by csharrison@chromium.org, Aug 3 2016

Issue description

Blink can infer if a resource was cached or not by its transferSize attribute.

We can aggregate all resources in a load, and derive an aggregate measure of "warmth" from 0 to 100.

In a followup, this measurement can be used to bucket PLT (see  issue 607063 ).
 
Alternatively, we may want to do this in the browser process to properly associate OOPIF. I will think on this.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b707384c5790eb863ce0388e0492f9a4bb5aa5e6

commit b707384c5790eb863ce0388e0492f9a4bb5aa5e6
Author: csharrison <csharrison@chromium.org>
Date: Tue Aug 09 23:57:28 2016

[page_load_metrics] Log cache warmth ratios at parse stop

This patch instruments ChromeResourceDispatcherHostDelegate to forward
request information upon request completion to page_load_metrics. This
data is then associated with the current committed navigation, and used
to generate histograms of % cache warmth in terms of total requests. This is
only an estimate, as the actual event in browser process where we log parse
stop can be up to a second after the true parse stop. In any case, it is still
useful data.

If we think it is necessary, we can eagerly send the parse stop IPC to
the browser process in a follow up.

Note: This CL also coalesces short events posted to the UI thread to avoid
spamming the task queue on request complete.

BUG= 634120 

Review-Url: https://codereview.chromium.org/2218583002
Cr-Commit-Position: refs/heads/master@{#410881}

[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/b707384c5790eb863ce0388e0492f9a4bb5aa5e6/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment