New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634094 link

Starred by 3 users
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
pdr@chromium.org
█ anan...@chromium.org
gov...@chromium.org
█ yabinh@chromium.org
wangxianzhu@chromium.org
█ aelias@chromium.org
█ bustamante@chromium.org
yosin@chromium.org
ligim...@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
changwan@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Caret becomes invisible when offset within TextArea filled with text.

Reported by debugz...@gmail.com, Aug 3 2016 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2817.0 Safari/537.36

Example URL:
data:text/html;charset=UTF-8;base64,PHRleHRhcmVhIGlkPSJlZGl0b3IiIHdyYXA9Im9mZiIgc3BlbGxjaGVjaz0iZmFsc2UiPjwvdGV4dGFyZWE+PHNjcmlwdD5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZWRpdG9yIikudmFsdWU9Ii0iLnJlcGVhdCg2MCk8L3NjcmlwdD4=

Steps to reproduce the problem:
1. Open specificed URL
2. Click textarea, press End key
3. Observe textarea

What is the expected behavior?
Blinking cursor

What went wrong?
Cursor disappears

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes Last known good revision: r409090

Does this work in other browsers? Yes 

Chrome version: 54.0.2817.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
Cursor disappears.mp4
2.6 MB View Download

Comment 1 by msrchandra@chromium.org, Aug 4 2016

Cc: msrchandra@chromium.org
Labels: -Type-Compat M-54 OS-Linux Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Abkle to reproduce the issue on Chrome Canary# 54.0.2817.0 on Windows and Linux.
This is a Regression issue in M54, below are the details,
Chrome Good Build -- 54.0.2816.0
Chrome Bad  Build -- 54.0.2817.0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/a056430f8f7969461abc089f6130a4a89f73d1e9..02a9535ecacde9f391e1f6832c5b99dc4e54cc6e

Thank You.

Comment 2 by durga.behera@chromium.org, Aug 4 2016

Cc: gov...@chromium.org ligim...@chromium.org
Labels: ReleaseBlock-Beta OS-Mac
Owner: yabinh@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Mac 10.11.6 as well on latest camary 54.0.2817.0.
This is working fine on Latest stable 52.0.2743.116 and beta 53.0.2785.34.

Omahaproxy Change Log from above Bisect range:
https://chromium.googlesource.com/chromium/src/+log/54.0.2816.0..54.0.2817.0?pretty=fuller&n=10000

Possible suspect : https://codereview.chromium.org/2020973002
yabinh@ : Could you please take a look into this if its related to your change.

Added ReleaseBlock-Beta against M54, please modify if its not applicable.

Comment 3 by gov...@chromium.org, Aug 4 2016

Cc: anan...@chromium.org bustamante@chromium.org

Comment 4 by yabinh@chromium.org, Aug 9 2016

Cc: aelias@chromium.org changwan@chromium.org

Comment 5 by yabinh@chromium.org, Aug 9 2016

Cc: yabinh@chromium.org
Owner: iclell...@chromium.org
The CL https://codereview.chromium.org/2020973002 is about composing text. I don't think it's related to the CL. I suspect it's related to selection. Resigning to iclelland@ for changing third_party/WebKit/Source/core/editing/DOMSelection.cpp.


iclelland@, Could you please take a look into this if its related to your change https://codereview.chromium.org/2068053002 ? Thanks.

Comment 6 by aelias@chromium.org, Aug 9 2016

Labels: Needs-Bisect
Owner: yabinh@chromium.org
It's almost certainly not iclelland#'s change as it's a trivial rename.

The issue reproes on Linux, so could you perform a bisect?

Comment 7 by durga.behera@chromium.org, Aug 12 2016

Labels: -Needs-Bisect Needs-Feedback
aelias@ : The Bisect information is present in comment # 1 & 2.
And it holds good for Linux(Ubuntu 14.04) as said in comment # 1.

But its working fine now on the latest canary 54.0.2827.0/54.0.2827.1 on Win7,Mac 10.11.6 and Ubuntu 14.04.Please find the attached screen cast of Windows.

Note : The cursor blinks only on Mac and Win and not in Linux though the cursor is visible.

Removing the Needs-Bisect as its reported in M54 and is working fine on latest canary.

debugzxcv@ : Could you please review the attached screen cast and confirm if its fine.
634094_Aug_12.mp4
224 KB View Download

Comment 8 by aelias@chromium.org, Aug 12 2016

Status: WontFix (was: Assigned)
OK, looks like a fix went in at some point recently, let's close.

Comment 9 by debugz...@gmail.com, Aug 12 2016 

Still able to reproduce the issue on Windows 7 using 54.0.2828.0 r411590.

Comment 10 by debugz...@gmail.com, Aug 14 2016 

Able to reproduce the issue on Windows 7 using 54.0.2830.0 r411911.

Comment 11 by yabinh@chromium.org, Aug 16 2016

Owner: wkorman@chromium.org
Status: Assigned (was: WontFix)
According to bisect result, this bug is caused by the cl:
https://codereview.chromium.org/1484163002

wkorman@, can you take a look into it?

Comment 12 by wkorman@chromium.org, Aug 19 2016 

Yes, sorry for delay, I will look at this tomorrow.

Comment 13 by ranjitkan@chromium.org, Aug 23 2016

Cc: ranjitkan@chromium.org
@wkorman: Gentle ping, Issue is marked with a beta blocker and M54 is going to be branched soon. Request you to please take a look into it .

Thanks.!

Comment 14 by wkorman@chromium.org, Aug 23 2016

Cc: pdr@chromium.org
Components: Blink>Paint>Invalidation
Looking at this now. The caret's visual rect is wrong/empty. It toggles back and forth between the below while blinking:

{index: 17, client: "0x32b8c6818378 LayoutBlockFlow DIV id='inner-editor'", type: "DrawingCaret", cacheIsValid: true, visualRect: [0,0 0x0]},
{index: 17, client: "0x32b8c6818378 LayoutBlockFlow DIV id='inner-editor'", type: "DrawingCaret", rect: [11.000000,11.000000 469.000000x15.000000], cacheIsValid: true, visualRect: [0,0 0x0]},

Comment 15 by wkorman@chromium.org, Aug 23 2016

Summary: Caret becomes invisible when offset within TextArea filled with text. (was: Cursor disappears)
The textarea's inner-editor LayoutBlockFlow looks to be calculating an incorrect paint invalidation rect. Tracing LayoutObject::invalidatePaintIfNeeded() for:

*       LayoutBlockFlow 0x20e793a18370  DIV     0x6b1b82039c0 ID="inner-editor" (editable)

PaintInvalidationState::computePaintInvalidationRectInBacking() starts with an element rect via
localOverflowRectForPaintInvalidation() as [0,0 175x16].

Mapping that to the paint invalidation container (the doc's LayoutView) uses m_cachedOffsetsEnabled path:

m_clipRect = 9,9 179x36
m_paintOffset = -280x11
After moving the rect we're mapping by the paint offset = -280,11 175x16
After intersecting that rect with the clip rect = 0,0 0x0

happening here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp?sq=package:chromium&dr=CSs&l=439

I'm not too familiar with cached offsets, something is obviously wrong here though. Continuing to investigate.

Comment 16 by wkorman@chromium.org, Aug 23 2016

Cc: yosin@chromium.org wangxianzhu@chromium.org
Work for  http://crbug.com/436198  to reduce the size of LayoutBox::localOverflowRectForPaintInvalidation() is believed to have introduced this issue, see:

https://codereview.chromium.org/1929413002/patch/80001/90003

We can demonstrably fix the issue as a hack exploration by modifying LayoutBox::localOverflowRectForPaintInvalidation() to:

return unionRect(selfVisualOverflowRect(), contentsVisualOverflowRect());

but this is likely an incomplete fix re: potential container resizes, and would end up undoing the optimization work in aforementioned bug, all just to ensure we correctly invalidate the caret in certain circumstances.

Moreover, the caret is known to be in need of cleanup implementation work, as previously discussed with yosin@ and others.

So, one current idea to fix is to rework caret painting (BlockPainter::paintCarets, CaretBase, ...) such that CaretBase is the DisplayItemClient for its painting, and existing logic for computing the caret invalidation rect in CaretBase::invalidateLocalCaretRect() would be used to provide the caret's visual rect. chrishtr@ notes that logic is slow, but carets aren't painted often.

Comment 17 by chrishtr@chromium.org, Aug 23 2016 

Or CaretBase can simply cache its visual rect.

Comment 18 by chrishtr@chromium.org, Aug 23 2016 

FYI I am going to do some work on CaretBase that is related to this work, in
order to fix  crbug.com/635724 .

Comment 19 by tkonch...@chromium.org, Aug 29 2016 

Just to update:

Still able to reproduce the issue on mac 10.11.6 chrome version 55.0.2843.0

Comment 20 by wkorman@chromium.org, Aug 30 2016 

Confirmed issue still exists at ToT. I believe chrishtr@ work is complete per landing of http://crrev.com/2271883002/. I will come back to this shortly.

Comment 21 by chrishtr@chromium.org, Aug 31 2016 

This bug is still happening at ToT even after fixes to the other caret bugs.

Walter, this cl seems to fix this bug:

https://codereview.chromium.org/2296203002

Try running with this approach? Needs a test.

Comment 22 by wkorman@chromium.org, Aug 31 2016 

Replied on CL -- looks good, fixes the issue, and I've sent a test distilled from the one in this bug.
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5153d9b53989b32068b7759aa0253a1e5662492a

commit 5153d9b53989b32068b7759aa0253a1e5662492a
Author: wkorman <wkorman@chromium.org>
Date: Fri Sep 02 05:18:57 2016

Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG= 634094 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2293293003
Cr-Commit-Position: refs/heads/master@{#416191}

[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/fast/forms/relayout-shifts-inner-editor.html
[add] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.png
[add] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.txt
[add] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret.html
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/CaretBase.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/CaretBase.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/FrameCaret.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
[modify] https://crrev.com/5153d9b53989b32068b7759aa0253a1e5662492a/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

Comment 24 by wkorman@chromium.org, Sep 2 2016 

We need to merge this to M54. I'll wait to verify fix on Canary before requesting merge.
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20bde053d9e8d93eb56892bc052c157ab83a4e87

commit 20bde053d9e8d93eb56892bc052c157ab83a4e87
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Sep 02 06:37:39 2016

Auto-rebaseline for r416191

https://chromium.googlesource.com/chromium/src/+/5153d9b53

BUG= 634094 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2304863002 .

Cr-Commit-Position: refs/heads/master@{#416202}

[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[rename] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/4776765-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-outside-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/caret-with-transformation-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/delete-into-nested-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/textarea-caret-expected.png
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/textarea-caret-expected.png
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/4776765-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-outside-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/caret-with-transformation-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/delete-into-nested-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-outline-repaint-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/textarea-caret-expected.png
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/4776765-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-outside-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/caret-with-transformation-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/delete-into-nested-block-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/fast/repaint/selection-after-delete-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[add] https://crrev.com/20bde053d9e8d93eb56892bc052c157ab83a4e87/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/textarea-caret-expected.txt

Comment 26 by wkorman@chromium.org, Sep 6 2016

Labels: Merge-Request-54
I've verified the test case in original comment no longer repros on Win Canary 55.0.2851.0 which includes r416191. Requesting merge to M54.

Comment 27 by dimu@chromium.org, Sep 6 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 6 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bedbc4f9a7d362447b2dc30544479aa1484f5e1

commit 6bedbc4f9a7d362447b2dc30544479aa1484f5e1
Author: Walter Korman <wkorman@chromium.org>
Date: Tue Sep 06 21:08:07 2016

Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG= 634094 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2293293003
Cr-Commit-Position: refs/heads/master@{#416191}
(cherry picked from commit 5153d9b53989b32068b7759aa0253a1e5662492a)

Review URL: https://codereview.chromium.org/2312383002 .

Cr-Commit-Position: refs/branch-heads/2840@{#184}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/fast/forms/relayout-shifts-inner-editor.html
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.png
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.txt
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret.html
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/CaretBase.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/CaretBase.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameCaret.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

Comment 29 by wkorman@chromium.org, Sep 6 2016

Status: Fixed (was: Assigned)
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bedbc4f9a7d362447b2dc30544479aa1484f5e1

commit 6bedbc4f9a7d362447b2dc30544479aa1484f5e1
Author: Walter Korman <wkorman@chromium.org>
Date: Tue Sep 06 21:08:07 2016

Make CaretBase a DisplayItemClient.

From chrishtr@'s http://crrev.com/2296203002 with test added. Fixes caret
invalidation in textarea where caret is scrolled outside of visible textarea
rect.

BUG= 634094 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2293293003
Cr-Commit-Position: refs/heads/master@{#416191}
(cherry picked from commit 5153d9b53989b32068b7759aa0253a1e5662492a)

Review URL: https://codereview.chromium.org/2312383002 .

Cr-Commit-Position: refs/branch-heads/2840@{#184}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/fast/forms/relayout-shifts-inner-editor.html
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.png
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret-expected.txt
[add] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/LayoutTests/paint/invalidation/textarea-caret.html
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/CaretBase.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/CaretBase.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameCaret.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h
[modify] https://crrev.com/6bedbc4f9a7d362447b2dc30544479aa1484f5e1/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
►

Sign in to add a comment