Issue metadata
Sign in to add a comment
|
EV incognito chip color is off |
||||||||||||||||||||||||
Issue descriptionHey Sarah, it looks like on Mac Incognito EV looks dimmer and bolder than the normal omnibox text. The EV string should be white like the icon. See screenshot in https://bugs.chromium.org/p/chromium/issues/detail?id=609929#c27 The bolder text is a OSX problem that occurs when transparent text is drawn on a dark background. Using white text should resolve this. Spec - https://drive.google.com/a/google.com/file/d/0B6Wxmj9LZL6XTk4zLU9WcDhPMlk/view
,
Aug 9 2016
This also applies to the scheme. In Incognito mode it should be - white when secure - dimmed when mixed - dimmed and crossed out when insecure. Overview in the specs: https://goo.gl/igXwCT Thanks for looking into this!
,
Aug 12 2016
,
Aug 12 2016
CL is in review Here are the screenshots of the changes I made
,
Aug 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b27db761f7aec09d22417d962c29beb5b2200e29 commit b27db761f7aec09d22417d962c29beb5b2200e29 Author: spqchan <spqchan@chromium.org> Date: Fri Aug 12 23:58:10 2016 [Material][Mac] Incognito Text Color Fix in the Omnibox The HTTPS scheme and EV Bubble text color should be white in dark mode. BUG= 634057 Review-Url: https://codereview.chromium.org/2246663002 Cr-Commit-Position: refs/heads/master@{#411822} [modify] https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h [modify] https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm [modify] https://crrev.com/b27db761f7aec09d22417d962c29beb5b2200e29/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
,
Aug 13 2016
,
Aug 15 2016
,
Aug 15 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fb21793a41d8d22293a069cf64e814db9fe6f11 commit 3fb21793a41d8d22293a069cf64e814db9fe6f11 Author: spqchan <spqchan@chromium.org> Date: Mon Aug 15 16:46:03 2016 [Material][Mac] Incognito Text Color Fix in the Omnibox The HTTPS scheme and EV Bubble text color should be white in dark mode. BUG= 634057 Review-Url: https://codereview.chromium.org/2246663002 Cr-Commit-Position: refs/heads/master@{#411822} (cherry picked from commit b27db761f7aec09d22417d962c29beb5b2200e29) Review URL: https://codereview.chromium.org/2241323002 . Cr-Commit-Position: refs/branch-heads/2785@{#590} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/3fb21793a41d8d22293a069cf64e814db9fe6f11/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h [modify] https://crrev.com/3fb21793a41d8d22293a069cf64e814db9fe6f11/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/3fb21793a41d8d22293a069cf64e814db9fe6f11/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h [modify] https://crrev.com/3fb21793a41d8d22293a069cf64e814db9fe6f11/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm [modify] https://crrev.com/3fb21793a41d8d22293a069cf64e814db9fe6f11/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
,
Aug 15 2016
,
Aug 17 2016
Tested the issue on Mac 10.11.6 using 53.0.2785.70.Observed that the HTTPS scheme and EV Bubble text color is white in incognito mode(as per comment #9). Please find attached screencast. Marking it as TE-Verified.
,
Oct 19 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by emilyschechter@chromium.org
, Aug 8 2016