CrWinASan(dll) is failing to build the ipc_fuzzer in the component build |
|||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4673/steps/generate_build_files/logs/stdio The bot is configured with these gn args: clang_use_chrome_plugins = false enable_ipc_fuzzer = true is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 v8_enable_verify_heap = true And gn generates this error message: ERROR at //tools/ipc_fuzzer/BUILD.gn:23:3: Assertion failed. assert(!is_component_build, "IPC fuzzer does not support component builds.") ^----- IPC fuzzer does not support component builds. See //BUILD.gn:192:5: which caused the file to be included. "//tools/ipc_fuzzer:ipc_fuzzer_all", ^---------------------------------- I believe we are building the IPC fuzzer because it is used in clusterfuzz and that's what we're trying to test, but maybe we don't need to do it on the dll builder.
,
Aug 3 2016
we were thinking to turn it off for now in the config, until we are able to bring back the static build.
,
Aug 3 2016
Sounds good.
,
Aug 3 2016
Heh, I just looked at this myself and pinged mbarbella@ about it. It looks like the shared build worked fine in gyp, and I'm not sure why it's disabled in GN, so maybe try removing the assert and see if it just compiles?
,
Aug 3 2016
,
Aug 3 2016
ipc_fuzzer isn't enabled by default in gyp builds I think.
,
Aug 3 2016
You're right that it's not enabled by default (in either build), but it was set on the bot. However, looks like maybe the flag was set in GYP_DEFINES, but the targets weren't actually compiled: https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4613
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0000ea98743393be00cef07afc4d556e7c801524 commit 0000ea98743393be00cef07afc4d556e7c801524 Author: thakis <thakis@chromium.org> Date: Wed Aug 03 19:42:46 2016 Don't build ipc_fuzzer on the CrWinASan(dll) bot. The fuzzer doesn't build in component builds BUG= 634056 Review-Url: https://codereview.chromium.org/2206963004 Cr-Commit-Position: refs/heads/master@{#409596} [modify] https://crrev.com/0000ea98743393be00cef07afc4d556e7c801524/tools/mb/mb_config.pyl
,
Aug 3 2016
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4676 |
|||
►
Sign in to add a comment |
|||
Comment 1 by r...@chromium.org
, Aug 3 2016