New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634045 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gsutil polling misses should not appear as infra failure steps.

Project Member Reported by robert...@chromium.org, Aug 3 2016

Issue description

When waiting for a build, gsutil polls the location, and if the build is not there it becomes an infra failure, cluttering the output of the bisect jobs.
 
Cc: robert...@chromium.org
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e5316b18800771931a523593991755d5a978f840

commit e5316b18800771931a523593991755d5a978f840
Author: robertocn <robertocn@chromium.org>
Date: Wed Aug 10 19:17:45 2016

Gsutil ls misses should not be treated as failures by bisect.

The purpose of this is to declutter bisect output. The gsutil
module calls a wrapper that contains retry logic to avoid
cases of flake.

Actual failures of gsutil remain a possibility, and this
change would make it a little tricky to diagnose since we
won't have purple steps, but in this case all that will
happen is that builds will either time out or the download
and unzip step would fail.

Google Storage going down has not as of yet been a problem
for bisect.

R=sullivan,dtu@chromium.org
BUG= 634045 

Review-Url: https://codereview.chromium.org/2209833002

[modify] https://crrev.com/e5316b18800771931a523593991755d5a978f840/scripts/slave/recipe_modules/auto_bisect/api.py
[modify] https://crrev.com/e5316b18800771931a523593991755d5a978f840/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
[modify] https://crrev.com/e5316b18800771931a523593991755d5a978f840/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e15fb993b0ea3e3a6d02f230559fd8d27b26be87

commit e15fb993b0ea3e3a6d02f230559fd8d27b26be87
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Aug 10 20:26:56 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bbd362cda10d5882f6b25f8dc200c4ef2c5aeb3b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/e5316b18800771931a523593991755d5a978f840 Gsutil ls misses should not be treated as failures by bisect. (robertocn@chromium.org)
  https://crrev.com/cad38fb18406815054a09616e5ed61a226abf5f0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/02d14f12d15236131a1bc0f95b038e53a907436e Fix two more paths to account for buildroot (abarth@chromium.org)
  https://crrev.com/aec8b75ff8f02ac71a70f360eb0ebd81824221ec Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/7c3841abdfddcb33f25be98d20c9e9db70657f9f git cl set-commit: actually apply passed --rietveld / --gerrit options (phajdan.jr@chromium.org)
  https://crrev.com/d2c82a25e81bf39b8a9e3da1350374e5c00d0594 Bot_update recipe output: Add 'Try Rebasing' to patch failure output (hinoka@google.com)
  https://crrev.com/ca5f2c8c49b0175bc56c0b57409f8bbcf8b4fe98 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/267db0f8954e4cd624e35d79482039811ab2cc5b Bump vendoring, move to proto3 release. (dnj@chromium.org)

R=robertocn@chromium.org,hinoka@google.com,abarth@chromium.org,phajdan.jr@chromium.org,dnj@chromium.org,recipe-roller@chromium.org
BUG= 634045 , chromium:628770 , 600945 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2233843003

[modify] https://crrev.com/e15fb993b0ea3e3a6d02f230559fd8d27b26be87/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e06c0b95e3e502051e81e29e1df63351d237ff6

commit 5e06c0b95e3e502051e81e29e1df63351d237ff6
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Aug 18 17:08:22 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1d392379e5023add13917fe8213f8baa57069679 [Android] Remove build/-side test spec for ClangToTAndroidASan. (jbudorick@chromium.org)
  https://crrev.com/ab5d157c22c95a0e4d0a6cf61bb5eadfb6390199 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/ce31e9613889dd969b66f407d57c2a1c391dffa3 webrtc: run tests in the checkout directory (phajdan.jr@chromium.org)
  https://crrev.com/e8c4706bcf98f455c6d4b5b416dd78b29d612b14 Revert of webrtc: run tests in the checkout directory (patchset #1 id:1 of https://codereview.chromium.org/2229213003/ ) (kjellander@chromium.org)
  https://crrev.com/c7478b1663a3c95c5fd41f70ed1e34c019663022 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/f5754f48489e3d38abaca86bfc2c623ceb55fe54 WebRTC: Enable MB for Android bots. (kjellander@chromium.org)
  https://crrev.com/ff987aaa25333bdd4a2bfad52375c6dcd561d8fd WebRTC: Remove Linux32 Debug+Release builders. (kjellander@chromium.org)
  https://crrev.com/95bc8c1803fc7a9dc409e6cdaa20c69001346cf2 chromium: run GN in the checkout directory (phajdan.jr@chromium.org)
  https://crrev.com/bfe8a695c17b592f5263c6d44a0266ccdb25a1c3 ios: fix cwd for git diff (phajdan.jr@chromium.org)
  https://crrev.com/5d4d12232cc7a15ef93dfc640a3f8a11b9c58d48 chromium: pass proper --src-dir to win_apply_syzyasan.py (phajdan.jr@chromium.org)
  https://crrev.com/d752c0093621a75eb2bf22b03239e893492ba494 Using the new convention for resolving the checkout directory. (robertocn@chromium.org)
  https://crrev.com/bbd362cda10d5882f6b25f8dc200c4ef2c5aeb3b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/e5316b18800771931a523593991755d5a978f840 Gsutil ls misses should not be treated as failures by bisect. (robertocn@chromium.org)
  https://crrev.com/cad38fb18406815054a09616e5ed61a226abf5f0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/02d14f12d15236131a1bc0f95b038e53a907436e Fix two more paths to account for buildroot (abarth@chromium.org)
  https://crrev.com/aec8b75ff8f02ac71a70f360eb0ebd81824221ec Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/ba41e09fdee7169b88c2ce65662da52e20301212 Revert of Use iossim/test-without-building for Earlgrey tests. (patchset #5 id:100001 of https://codereview.chromium.org/2229183002/ ) (huangml@chromium.org)
  https://crrev.com/bf50bb928a6cd38b24a5b09fa2381c5ef2993d06 Update path to snapshot target (abarth@chromium.org)
  https://crrev.com/772f3c1a6b92c56ae8799ae41b0bfd60584ac6af Add retries and backoff to build_scan.py (martiniss@chromium.org)
  https://crrev.com/e5ff4c787090f81aa4b0dfb61895be009429e92a Moving AutoBisectApi.working_dir fallback logic to the property code. (robertocn@chromium.org)
  https://crrev.com/8dbc87ce68b4aab11a98c247c4d4bf07ea1d200c The second solution solution for ToT catapult. (robertocn@chromium.org)
  https://crrev.com/a9cfd226df3aa184f2fb6d91cd70788dd3fe624e Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/e3c184f8b065289348de9f6ef3912aa076c73c70 Fix build_scan.py error handling, add test (martiniss@chromium.org)
  https://crrev.com/a9a30980d2f243f003db441e2e898e065732220a Add logging to build_scan.py for url retries (martiniss@chromium.org)
  https://crrev.com/d1abddeb8fe45bff3706713d945ed998ef4dbaa1 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/6ce0ae3616a38366ddb585d7a752ecf3a7b6d2a2 WebRTC: Enable MB for Windows builders. (kjellander@chromium.org)
  https://crrev.com/bc3c4bc0fb25d33f82ba92bddfc16c3da04fe6ce WebRTC: Enable MB for Mac builders. (kjellander@chromium.org)
  https://crrev.com/34fd8200ebd17d56fb8b8edf7fa29ce70aff6ee4 WebRTC: Add gyp_script parameter to ios recipe module's run_mb call. (kjellander@chromium.org)
  https://crrev.com/3e712149928b25d79d20c4a1728ca821d7a30d74 Update dart2js_nobuild recipe, switch some builders (whesse@google.com)
  https://crrev.com/2df96279adf5abf895e63b609c7683d33b941862 cipd: drop unneeded dependency on the file recipe module (phajdan.jr@chromium.org)
  https://crrev.com/5d1a4325cb496b888ee88d6707fbe4174f19a041 Allow Dart package.stamp file to be missing in dart2js_nobuild recipe (whesse@google.com)
  https://crrev.com/b2d728aee987c4d2f565752f56aa30dcfe07ff49 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/b3b5ebfc203792617180419b39e5f63f1d4f57eb Use iossim to work around duplicate xcodebuild destination names. (justincohen@chromium.org)
  https://crrev.com/844f958bce2c658e79272c5e83517fc5ad8eb64c Stop distributing SkyShell.apk and flutter.mojo (abarth@chromium.org)
  https://crrev.com/a7d2fc32f5b0db4a878246303e1794867ea580e3 Revert "ios: fix path to the test app" (smut@google.com)
  https://crrev.com/7fe41e5c1fe02370566f84358a1566901bc7a566 Setup a buildbot master for running end-to-end tests on Offline Pages. (bustamante@google.com)
  https://crrev.com/dfd62794c4925e42fb06a493149683122f68a791 Implement upload_logs() in recipe_modules/goma (tikuta@chromium.org)
  https://crrev.com/5b1fdf8d379c7803bf54ede0ab9e73212548fe54 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/eb0dc31ad0b04b088dae4277b306cd6007415f94 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/6859823bf8464ad91a6c3429e5d791f63f7dbc7b git cl set-commit: allow forcing code review system (phajdan.jr@chromium.org)
  https://crrev.com/7c3841abdfddcb33f25be98d20c9e9db70657f9f git cl set-commit: actually apply passed --rietveld / --gerrit options (phajdan.jr@chromium.org)
  https://crrev.com/d2c82a25e81bf39b8a9e3da1350374e5c00d0594 Bot_update recipe output: Add 'Try Rebasing' to patch failure output (hinoka@google.com)
  https://crrev.com/ca5f2c8c49b0175bc56c0b57409f8bbcf8b4fe98 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/8a65a02164e312addbfe53c9fb834d260bd59d23 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/dafd4f0c9a24d2b46531b9e054eb199e4f305f0a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/9e198a84a930530032d87318b8c33b62b8b3833f Overhaul the README files a bit. (maruel@chromium.org)
  https://crrev.com/7929675b19082a057ceb9d1daa87565b6793add5 Add cipd recipe module to depot_tools (phajdan.jr@chromium.org)
recipe_engine:
  https://crrev.com/6a4b2e47ebde45f546588ed9d733969fbc0634e7 Fixes for autoroll when repo_type=GITILES is used (phajdan.jr@chromium.org)
  https://crrev.com/267db0f8954e4cd624e35d79482039811ab2cc5b Bump vendoring, move to proto3 release. (dnj@chromium.org)
  https://crrev.com/aa5141a2236738b8a3d0e0fa57e1220066df29a4 Add support for operational arguments protobuf. (dnj@chromium.org)
  https://crrev.com/85dbcfb4d81379d40b4461436daa5264008904bf Make recipes.py run give better messages. (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 634045 , 544330 , 636499 , 600945 , chromium:628770 ,629679, 589510 ,598405,632712,584079, 635421 ,633363, 636080 , 593999 ,636190, chromium:459840 

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2255233002
Cr-Commit-Position: refs/heads/master@{#412862}

[modify] https://crrev.com/5e06c0b95e3e502051e81e29e1df63351d237ff6/infra/config/recipes.cfg

Components: Speed>Bisection
Cc: simonhatch@chromium.org
Components: -Speed>Bisection Infra
Status: Untriaged (was: Available)
This might be fixed, moving to the right component.
Cc: benhenry@chromium.org
Components: -Infra Speed>Bisection
IMO, Speed>Bisection is a reasonable component as this method is most likely used by Speed infra recipe only, and so it's up to them to decide if it's fixed.
Owner: robert...@chromium.org
Status: Fixed (was: Untriaged)
Marking this as fixed since the misses don't appear as failure steps.

Sign in to add a comment