https://codereview.chromium.org/2209843002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560dba3c9e8878608d735a811cfaaf29aa6fab88

commit 560dba3c9e8878608d735a811cfaaf29aa6fab88
Author: thestig <thestig@chromium.org>
Date: Wed Aug 03 23:05:21 2016

Expand scope of enable_hotwording.

It is currently only in chrome/browser/BUILD.gn even though it is used
elsewhere. Moving it to chrome/common/features.gni and checking for it
where it is used.

BUG= 634044 

Review-Url: https://codereview.chromium.org/2209843002
Cr-Commit-Position: refs/heads/master@{#409651}

[modify] https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88/chrome/browser/BUILD.gn
[modify] https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88/chrome/common/features.gni

And done. Good luck with the other hotwording problems.

And I broke the build. Revert is in CQ. Will try again.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60c1473ba214cff9ee701d5ea55b0c6025b582a7

commit 60c1473ba214cff9ee701d5ea55b0c6025b582a7
Author: thestig <thestig@chromium.org>
Date: Thu Aug 04 00:20:24 2016

Revert of Expand scope of enable_hotwording. (patchset #5 id:80001 of https://codereview.chromium.org/2209843002/ )

Reason for revert:
Broke official CrOS build.

Original issue's description:
> Expand scope of enable_hotwording.
>
> It is currently only in chrome/browser/BUILD.gn even though it is used
> elsewhere. Moving it to chrome/common/features.gni and checking for it
> where it is used.
>
> BUG= 634044 
>
> Committed: https://crrev.com/560dba3c9e8878608d735a811cfaaf29aa6fab88
> Cr-Commit-Position: refs/heads/master@{#409651}

TBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 634044 

Review-Url: https://codereview.chromium.org/2204343004
Cr-Commit-Position: refs/heads/master@{#409681}

[modify] https://crrev.com/60c1473ba214cff9ee701d5ea55b0c6025b582a7/chrome/browser/BUILD.gn
[modify] https://crrev.com/60c1473ba214cff9ee701d5ea55b0c6025b582a7/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/60c1473ba214cff9ee701d5ea55b0c6025b582a7/chrome/common/features.gni

Second try: https://codereview.chromium.org/2213713002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0

commit 0e3086f5ce38b1837685327e1d3d53f57ac7fcd0
Author: thestig <thestig@chromium.org>
Date: Thu Aug 04 04:44:16 2016

Expand scope of enable_hotwording. (try 2)

It is currently only in chrome/browser/BUILD.gn even though it is used
elsewhere. Moving it to chrome/common/features.gni and checking for it
where it is used.

BUG= 634044 
Previous attempt: https://codereview.chromium.org/2209843002/

Review-Url: https://codereview.chromium.org/2213713002
Cr-Commit-Position: refs/heads/master@{#409720}

[modify] https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0/chrome/browser/BUILD.gn
[modify] https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/0e3086f5ce38b1837685327e1d3d53f57ac7fcd0/chrome/common/features.gni

Second time is the charm.

🙌