Issue metadata
Sign in to add a comment
|
78.1% regression in cc_perftests at 409195:409228 |
||||||||||||||||||||
Issue descriptionSee attached graph.
,
Aug 3 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9005331429290814400
,
Aug 3 2016
This is an improvement. :) The bigger the num_runs_in_2_seconds is, the better performance is. We probably need to change the monitoring configuration. I am working on improving mojo serialization performance recently: https://bugs.chromium.org/p/chromium/issues/detail?id=624459 And this is the result of that work.
,
Aug 3 2016
=== Auto-CCing suspected CL author yzshen@chromium.org === Hi yzshen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Mojo C++ bindings: inline struct data view field getters. Author : yzshen Commit description: This significantly improves deserialization performance of cc_serialization_perftest by about 25~30%. BUG= 624459 NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2199043002 Cr-Commit-Position: refs/heads/master@{#409212} Commit : 1b78a8928c31188e2ca1e24d031031fd619dba7b Date : Tue Aug 02 17:11:32 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@409194 2712.0 4.47214 5 good chromium@409211 2722.0 4.47214 5 good chromium@409212 3606.0 5.47723 5 bad <-- chromium@409213 3584.0 5.47723 5 bad chromium@409214 4316.0 11.4018 5 bad chromium@409216 4342.0 8.3666 5 bad chromium@409220 4294.0 20.7364 5 bad chromium@409228 4122.0 8.3666 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 634024 Test Command: ./src/out/Release/cc_perftests --test-launcher-print-test-stdio=always --verbose Test Metric: StructTraits deserialization/num runs in 2 seconds: DelegatedFrame_ManyQuads_1_4000 Relative Change: 51.99% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6618 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005331429290814400 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5822542690910208 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f commit 9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f Author: yzshen <yzshen@chromium.org> Date: Thu Aug 04 20:58:57 2016 Improve gfx::Transform StructTraits. This change significantly improves the performance of cc_serialization_perftest: Two test cases are mostly not affected. For the rest, the serialization and deserialization performance is improved by 10%~20%. BUG= 634024 Review-Url: https://codereview.chromium.org/2210673002 Cr-Commit-Position: refs/heads/master@{#409898} [modify] https://crrev.com/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f/mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl [modify] https://crrev.com/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl [modify] https://crrev.com/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f/ui/gfx/mojo/transform.mojom [modify] https://crrev.com/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f/ui/gfx/mojo/transform.typemap [modify] https://crrev.com/9cbbefdc8f2ee2b82b21d188b29bd9ae2629da6f/ui/gfx/mojo/transform_struct_traits.h
,
Nov 18 2016
,
May 6 2017
Based on comment #3. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by aiolos@chromium.org
, Aug 3 2016