New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634024 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

78.1% regression in cc_perftests at 409195:409228

Project Member Reported by aiolos@chromium.org, Aug 3 2016

Issue description

See attached graph.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=634024

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg5tj-vAoM


Bot(s) for this bug's original alert(s):

linux-release
This is an improvement. :) The bigger the num_runs_in_2_seconds is, the better performance is. We probably need to change the monitoring configuration.

I am working on improving mojo serialization performance recently:
https://bugs.chromium.org/p/chromium/issues/detail?id=624459

And this is the result of that work.
Cc: yzshen@chromium.org
Owner: yzshen@chromium.org

=== Auto-CCing suspected CL author yzshen@chromium.org ===

Hi yzshen@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Mojo C++ bindings: inline struct data view field getters.
Author  : yzshen
Commit description:
  
This significantly improves deserialization performance of cc_serialization_perftest by about 25~30%.

BUG= 624459 
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2199043002
Cr-Commit-Position: refs/heads/master@{#409212}
Commit  : 1b78a8928c31188e2ca1e24d031031fd619dba7b
Date    : Tue Aug 02 17:11:32 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@409194  2712.0  4.47214  5  good
chromium@409211  2722.0  4.47214  5  good
chromium@409212  3606.0  5.47723  5  bad    <--
chromium@409213  3584.0  5.47723  5  bad
chromium@409214  4316.0  11.4018  5  bad
chromium@409216  4342.0  8.3666   5  bad
chromium@409220  4294.0  20.7364  5  bad
chromium@409228  4122.0  8.3666   5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 634024

Test Command: ./src/out/Release/cc_perftests --test-launcher-print-test-stdio=always --verbose
Test Metric: StructTraits deserialization/num runs in 2 seconds: DelegatedFrame_ManyQuads_1_4000
Relative Change: 51.99%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6618
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005331429290814400


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5822542690910208

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 6 by rbyers@chromium.org, Nov 18 2016

Labels: Performance
Status: WontFix (was: Assigned)
Based on comment #3.

Sign in to add a comment