New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634021 link

Starred by 2 users
Status: Fixed
Owner:
sadrul@chromium.org
Closed: Aug 2016
Cc:
█ ben@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove MOJO_SHELL_CLIENT define

Project Member Reported by sadrul@chromium.org, Aug 3 2016 
Now that gn is default on all platforms, we can remove the MOJO_SHELL_CLIENT define.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd

commit e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd
Author: sadrul <sadrul@chromium.org>
Date: Wed Aug 03 20:20:28 2016

browser_test: Add a browser_tests_runner target for running tests.

browser_tests_main.cc file is used to run the tests in browser_tests,
chromevox_tests, and sync_integration_tests. Create a separate
browser_tests_runner target, and use that instead for these tests.

BUG= 634021 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2210573002
Cr-Commit-Position: refs/heads/master@{#409610}

[modify] https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
[modify] https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd/chrome/chrome_tests.gypi
[modify] https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd/chrome/test/BUILD.gn

Comment 2 by sadrul@chromium.org, Aug 17 2016

Status: Fixed (was: Started)
►

Sign in to add a comment