New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634017 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

video_VimeoVideo doesn't work.

Project Member Reported by steve...@chromium.org, Aug 3 2016

Issue description

This catapult roll:

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a95bbdfc8de9..efec1f2e771b

Broke video_VimeoVideo:

ERROR:root:video_VimeoVideo import error: cannot import name webpagereplay.  Skipping video_VimeoVideo

This is the CL that appears to introduce the dependency:
https://chromium.git.corp.google.com/chromiumos/third_party/autotest/+/cc0a1ef1328cab897faa95b07187651bf634476c

 
Owner: achuith@chromium.org
It looks like that change came from here:
https://googleplex-android.git.corp.google.com/platform/external/autotest/+/b058a8f201af2d99f3d02aa956ab118df2d9c67d

-> achuith@

WAR to get the build going: https://chromium-review.googlesource.com/#/c/365851/

We need to look into getting rid of this wrapper altogether.
Ned's CL for reference: https://codereview.chromium.org/2209443003
Cc: rohi...@chromium.org
Status: Started (was: Assigned)
Rohit - webpagereplay_wrapper is only used by video_VimeoVideo. This test is not running as part of any suite. I tried running it locally and it doesn't succeed.

Is this test still in use? Why does it need to use webpagereplay?
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf6aa93ffe9d963f41475479ad0e96df03a05e7a

commit cf6aa93ffe9d963f41475479ad0e96df03a05e7a
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Aug 03 18:12:49 2016

webpagereplay has moved.

This is a temporary workaround. We need to not import an internal item.

BUG=chromium:634017
TEST=BuildPackages

Change-Id: I0072c07d031173bd7357d50a1be7331e92c75f6a
Reviewed-on: https://chromium-review.googlesource.com/365851
Trybot-Ready: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Trybot-Ready: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/cf6aa93ffe9d963f41475479ad0e96df03a05e7a/client/cros/webpagereplay_wrapper.py

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf6aa93ffe9d963f41475479ad0e96df03a05e7a

commit cf6aa93ffe9d963f41475479ad0e96df03a05e7a
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Aug 03 18:12:49 2016

webpagereplay has moved.

This is a temporary workaround. We need to not import an internal item.

BUG=chromium:634017
TEST=BuildPackages

Change-Id: I0072c07d031173bd7357d50a1be7331e92c75f6a
Reviewed-on: https://chromium-review.googlesource.com/365851
Trybot-Ready: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Trybot-Ready: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/cf6aa93ffe9d963f41475479ad0e96df03a05e7a/client/cros/webpagereplay_wrapper.py

Labels: -Pri-0 Pri-1
Owner: rohi...@chromium.org
While waiting to see if this fixes the build issue, dropping to P1, and assigning to Rohit to see if we can get rid of this test altogether or at least remove the wpr dependency.
We tried using wpr to test vimeo to reduce online streaming related issues but didn't have much success due to several platform related issues so we decided to stop running the test.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8bdfae8bd6e250184af2f2c31221735ec2bd7cc5

commit 8bdfae8bd6e250184af2f2c31221735ec2bd7cc5
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Aug 10 19:09:02 2016

Delete webpagereplay_wrapper.

BUG=chromium:634017
TEST=None

Change-Id: I63f2fda9adf469034a304fdc2ceb9ffceadc9060
Reviewed-on: https://chromium-review.googlesource.com/367740
Commit-Ready: Dan Shi <dshi@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>

[modify] https://crrev.com/8bdfae8bd6e250184af2f2c31221735ec2bd7cc5/client/site_tests/video_VimeoVideo/video_VimeoVideo.py
[delete] https://crrev.com/e8d1a1ee4083536969d1cdab15c75215d8242761/client/cros/webpagereplay_wrapper.py

Components: -Tests>Telemetry Tests>Fails
Labels: -Pri-1 -Build-PFQ-Failures Pri-2
Status: Assigned (was: Started)
Summary: video_VimeoVideo doesn't work. (was: video_VimeoVideo import error: cannot import name webpagereplay)
Either need to delete video_VimeoVideo or get it working again.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d99c6180c34273e10e12c19e97affc5a03e6f10

commit 7d99c6180c34273e10e12c19e97affc5a03e6f10
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Thu Aug 11 21:17:19 2016

Remove video_VimeoVideo from autotest ebuilds.

The tests need to be updated to not use internal telemetry
dependencies.

BUG=chromium:634017
TEST=None.

Change-Id: I27e8d74516d4b411563f14131063cfab9c762999
Reviewed-on: https://chromium-review.googlesource.com/368380
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>

[modify] https://crrev.com/7d99c6180c34273e10e12c19e97affc5a03e6f10/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild
[modify] https://crrev.com/7d99c6180c34273e10e12c19e97affc5a03e6f10/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Comment 16 by hiroh@chromium.org, Dec 28 2017

Cc: hiroh@chromium.org
Shall we make a decision about crbug.com/634017#c13?
More than one year has passed since we removed video_VimeoVideo.

Cc: -mu...@chromium.org -rohi...@chromium.org vsu...@chromium.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment