Currently the username is hidden in case there is a federation provider and a username. Therefore, it's possible that we show identical rows.
Linux implementation
Mac
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c75da0d1db3c9d2d590bf3788b246fa45ed4809 commit 8c75da0d1db3c9d2d590bf3788b246fa45ed4809 Author: vasilii <vasilii@chromium.org> Date: Thu Aug 04 08:23:33 2016 Show 3 rows in the account chooser. They appear in case the credential has all three fields: - username - display name - federation provider BUG= 633994 Review-Url: https://codereview.chromium.org/2201413002 Cr-Commit-Position: refs/heads/master@{#409739} [modify] https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm [modify] https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809/chrome/browser/ui/passwords/manage_passwords_view_utils.cc [modify] https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809/chrome/browser/ui/passwords/manage_passwords_view_utils.h [modify] https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809/chrome/browser/ui/views/passwords/credentials_item_view.cc
Android already shows username instead of display name.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f13a4c8d4b067616016e48c4a71aadecdc33b9d commit 9f13a4c8d4b067616016e48c4a71aadecdc33b9d Author: vasilii <vasilii@chromium.org> Date: Fri Aug 19 19:20:24 2016 Tune the account chooser on Mac. - it should always have vertical margins of 8px. - The focus ring is drawn in the new method since OS X 10.7. BUG= 633994 Review-Url: https://codereview.chromium.org/2259533006 Cr-Commit-Position: refs/heads/master@{#413207} [modify] https://crrev.com/9f13a4c8d4b067616016e48c4a71aadecdc33b9d/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/9f13a4c8d4b067616016e48c4a71aadecdc33b9d/chrome/browser/ui/cocoa/passwords/credential_item_button.mm
Comment 1 by vasi...@chromium.org
, Aug 3 201620.1 KB
20.1 KB View Download