New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633976 link

Starred by 2 users
Status: Fixed
Owner:
pkl@chromium.org
Closed: Jan 2017
Cc:
█ jif@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove "back to calling app" logic.

Project Member Reported by jif@chromium.org, Aug 3 2016 
In web_toolbar_controller.mm there's logic involving |_backToCallingAppButton| that should be removed.

Comment 1 by jif@chromium.org, Aug 3 2016 

We shouldn't forget to remove setUpButton:withLeftAlignedImageEnum too

Comment 2 by jif@chromium.org, Sep 26 2016

Cc: pkl@chromium.org
+pkl@, in case you want to handle that cleaning.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3914049c055f99ea42378e5edf163fd6acdaf98f

commit 3914049c055f99ea42378e5edf163fd6acdaf98f
Author: sdefresne <sdefresne@google.com>
Date: Sat Dec 17 14:56:07 2016

Comment 4 by pkl@chromium.org, Jan 9 2017

Cc: -pkl@chromium.org jif@chromium.org
Owner: pkl@chromium.org
Status: Fixed (was: Assigned)
That was removed a couple of months ago in https://chromereviews.googleplex.com/523537014/
►

Sign in to add a comment