New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633975 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Don't delete the following V8 related GYP files

Project Member Reported by hablich@chromium.org, Aug 3 2016

Issue description

The V8 team still needs the following GYP files. Please do not delete them for now until noticed:

./(v8)/testing/gtest.gyp
./(v8)/testing/gmock.gyp
./third_party/icu/icu.gyp

machenbach, jochen please feel free to add more entries if something comes up.
 
Note that the reason is that V8 is also being used by other embedders than Chrome, notably Node.js. Node.js still uses GYP and will continue to do so in the foreseeable future. Until that is resolved, dependencies of V8 will have to keep their GYP configurations up-to-date.
Cc: ofrobots@google.com
./third_party/icu/icu.gyp is pulled in via DEPS, and isn't part of the chromium repo, so we have no particular plans to delete it.

gtest and gmock will probably need to be cleaned up as part of the next roll of googletest, where the repos get merged together.
Labels: -Proj-GN-Migration Proj-GN-Migration-V8

Comment 5 by jochen@chromium.org, Sep 23 2016

gtest and gmock are checked into v8, so it's really just about icu.gyp
Cc: fran...@chromium.org
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: yangguo@chromium.org
@Yang: Wonder if this still holds? We removed gyp in V8. Node.js has their own copy. They could have their own copy for ICU, too, right?
Yup. This is correct. Though that would also mean Node.js needs to maintain ICU's gyp files on ICU updates too.
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment