Don't delete the following V8 related GYP files |
|||||||
Issue descriptionThe V8 team still needs the following GYP files. Please do not delete them for now until noticed: ./(v8)/testing/gtest.gyp ./(v8)/testing/gmock.gyp ./third_party/icu/icu.gyp machenbach, jochen please feel free to add more entries if something comes up.
,
Aug 3 2016
,
Aug 3 2016
./third_party/icu/icu.gyp is pulled in via DEPS, and isn't part of the chromium repo, so we have no particular plans to delete it. gtest and gmock will probably need to be cleaned up as part of the next roll of googletest, where the repos get merged together.
,
Sep 22 2016
,
Sep 23 2016
gtest and gmock are checked into v8, so it's really just about icu.gyp
,
Feb 27 2017
,
Mar 9 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 9 2018
@Yang: Wonder if this still holds? We removed gyp in V8. Node.js has their own copy. They could have their own copy for ICU, too, right?
,
Mar 9 2018
Yup. This is correct. Though that would also mean Node.js needs to maintain ICU's gyp files on ICU updates too.
,
Mar 13 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yangguo@chromium.org
, Aug 3 2016