New issue
Advanced search Search tips

Issue 633971 link

Starred by 4 users

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

gn cannot run in a non-git repo while non-gclient repo

Reported by hanp...@gmail.com, Aug 3 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
1. Run gn in a folder. The folder is not in a git repo. And it is not in a gclient repo. But there is buildtools in it.
2. gn run failed with error message:

gn.py: Could not find checkout in any parent of the current path.
This must be run inside a checkout.

What is the expected behavior?

What went wrong?
Wish gn can run normally.

Did this work before? N/A 

Chrome version: 51.0.2704.79  Channel: n/a
OS Version: 
Flash Version:
 
Components: -Platform>DevTools Build
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/13f9c37185750d4212a125204d22302376c77f8e

commit 13f9c37185750d4212a125204d22302376c77f8e
Author: hanpfei <hanpfei@gmail.com>
Date: Tue Aug 09 05:05:56 2016

Update top_dir with git repo root just when cwd locate in a git repo.

if when execute command "git rev-parse --show-toplevel" in a directory
that is not a subdirectory of a git repo, CheckCallAndFilter will not
throw exception, so the top_dir may be updated with a invalid path.

BUG= 633971 

Signed-off-by: hanpfei <hanpfei@gmail.com>
Review-Url: https://codereview.chromium.org/2200193003

[modify] https://crrev.com/13f9c37185750d4212a125204d22302376c77f8e/gclient_utils.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e194ba182811abb83a66de3a7304fb88369ca9e9

commit e194ba182811abb83a66de3a7304fb88369ca9e9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 05:29:52 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/13f9c37185750d4212a125204d22302376c77f8e Update top_dir with git repo root just when cwd locate in a git repo. (hanpfei@gmail.com)

R=hanpfei@gmail.com
BUG= 633971 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2228823002

[modify] https://crrev.com/e194ba182811abb83a66de3a7304fb88369ca9e9/infra/config/recipes.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/44d0ad518d98b74699bdb93447af15a7cfd6d6a5

commit 44d0ad518d98b74699bdb93447af15a7cfd6d6a5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 06:03:57 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e194ba182811abb83a66de3a7304fb88369ca9e9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/dff032d88cade0048a60c2c6fdadd367771dce40 Add option to store pid of cloudtail in compile.py (tikuta@chromium.org)
depot_tools:
  https://crrev.com/13f9c37185750d4212a125204d22302376c77f8e Update top_dir with git repo root just when cwd locate in a git repo. (hanpfei@gmail.com)

R=tikuta@chromium.org,phajdan.jr@chromium.org,hanpfei@gmail.com,martiniss@chromium.org,recipe-roller@chromium.org
BUG= 633971 , 544330 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2223173003

[modify] https://crrev.com/44d0ad518d98b74699bdb93447af15a7cfd6d6a5/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/649cee3f737eba27daacc69fb2309cc7e7c01e71

commit 649cee3f737eba27daacc69fb2309cc7e7c01e71
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 06:51:09 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/331017e61df618c587dbe9762f7d80dd8c80ba38 Remove unused android-gce recipe code. (bpastene@chromium.org)
  https://crrev.com/14ed81de22b5635905c22b5d0b98420f235874c2 build_state._is_build_archived is a method, not a property. (robertocn@chromium.org)
  https://crrev.com/a2c5c12a068bbd21fef24d9158451c76e8aac935 Upload LocalGTestTest results to test-results. (jbudorick@chromium.org)
  https://crrev.com/66efb7523e1a05821bb897a1bf96a9a7793abf13 Revert of Upload LocalGTestTest results to test-results. (patchset #2 id:20001 of https://codereview.chromium.org/2225893002/ ) (jbudorick@chromium.org)
  https://crrev.com/e194ba182811abb83a66de3a7304fb88369ca9e9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/dff032d88cade0048a60c2c6fdadd367771dce40 Add option to store pid of cloudtail in compile.py (tikuta@chromium.org)
depot_tools:
  https://crrev.com/13f9c37185750d4212a125204d22302376c77f8e Update top_dir with git repo root just when cwd locate in a git repo. (hanpfei@gmail.com)

R=bpastene@chromium.org,robertocn@chromium.org,jbudorick@chromium.org,stip@chromium.org,dtu@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,tikuta@chromium.org,hanpfei@gmail.com
BUG=chromium:634527, 633971 , 544330 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2226203002
Cr-Commit-Position: refs/heads/master@{#410599}

[modify] https://crrev.com/649cee3f737eba27daacc69fb2309cc7e7c01e71/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cec766bf0c854d4137da46360362813919558440

commit cec766bf0c854d4137da46360362813919558440
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 08:29:14 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/331017e61df618c587dbe9762f7d80dd8c80ba38 Remove unused android-gce recipe code. (bpastene@chromium.org)
  https://crrev.com/14ed81de22b5635905c22b5d0b98420f235874c2 build_state._is_build_archived is a method, not a property. (robertocn@chromium.org)
  https://crrev.com/a2c5c12a068bbd21fef24d9158451c76e8aac935 Upload LocalGTestTest results to test-results. (jbudorick@chromium.org)
  https://crrev.com/66efb7523e1a05821bb897a1bf96a9a7793abf13 Revert of Upload LocalGTestTest results to test-results. (patchset #2 id:20001 of https://codereview.chromium.org/2225893002/ ) (jbudorick@chromium.org)
  https://crrev.com/e194ba182811abb83a66de3a7304fb88369ca9e9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/dff032d88cade0048a60c2c6fdadd367771dce40 Add option to store pid of cloudtail in compile.py (tikuta@chromium.org)
  https://crrev.com/697fd2909e82e505a47f7f244d521e6190e85d91 Reland of Unified the code to upload goma-related information. (yyanagisawa@chromium.org)
depot_tools:
  https://crrev.com/13f9c37185750d4212a125204d22302376c77f8e Update top_dir with git repo root just when cwd locate in a git repo. (hanpfei@gmail.com)

R=bpastene@chromium.org,robertocn@chromium.org,jbudorick@chromium.org,stip@chromium.org,dtu@chromium.org,recipe-roller@chromium.org,yyanagisawa@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,tikuta@chromium.org,hanpfei@gmail.com
BUG=chromium:634527, 633971 , 544330 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2221153004
Cr-Commit-Position: refs/heads/master@{#410617}

[modify] https://crrev.com/cec766bf0c854d4137da46360362813919558440/infra/config/recipes.cfg

is this resolved ? i still got the same errors, cant event build from downloaded tarballs, if this features was available, it will lower the stress on git server to always pull permanently.
@kyles You are probably running the gn wrapper script (gn.py in depot_tools), and the wrapper cannot find the actual gn executable which is usually downloaded by `gclient runhooks` IIRC.

For the record, on embedded build systems they often build GN themselves and use that GN binary to build chromium from a tarball. See, for example, https://github.com/rakuco/meta-crosswalk/tree/chromium61/recipes-browser/chromium
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 17

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment