New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633961 link

Starred by 2 users
Status: Verified
Owner:
mamir@chromium.org
Closed: Aug 2016
Cc:
█ bauerb@chromium.org
treib@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 0
Type: Bug



Sign in to add a comment

Chrome crashes upon receiving invalid managed user settings.

Project Member Reported by mamir@chromium.org, Aug 3 2016 
Managed user settings are stored as JSON values.

Chrome crashes if an invalid value is coming via Sync.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d48f6178d1cfbf6b2dc26df2066343b778edb3d1

commit d48f6178d1cfbf6b2dc26df2066343b778edb3d1
Author: mamir <mamir@chromium.org>
Date: Wed Aug 03 17:10:45 2016

Ignore invalid managed user settings values gracefully.
If the managed user settings isn't a valid JSON value, don't store it.
Ignore it instead and log an error.

BUG= 633961 

Review-Url: https://codereview.chromium.org/2201373002
Cr-Commit-Position: refs/heads/master@{#409548}

[modify] https://crrev.com/d48f6178d1cfbf6b2dc26df2066343b778edb3d1/chrome/browser/supervised_user/supervised_user_settings_service.cc

Comment 2 by mamir@chromium.org, Aug 4 2016

Status: Fixed (was: Started)

Comment 3 by dhadd...@chromium.org, Oct 21 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment