New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633942 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 633527
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-5.1% regression in system_health.memory_desktop at 408937:408962

Project Member Reported by petrcermak@chromium.org, Aug 3 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@408943  15068711  144892   12  good
chromium@408947  15008328  229459   8   bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 633942

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: browse_news-memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/browse_news_reddit
Relative Change: 1.29%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/804
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005355290498546656


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5890602084859904

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 633527
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactoring: Make member variables in Resource private
Author  : hajimehoshi
Commit description:
  
This CL moves some member variables in Resource class from protected to
private to improve code health.

BUG=n/a
TEST=webkit_unit_tests

Review-Url: https://codereview.chromium.org/2199713002
Cr-Commit-Position: refs/heads/master@{#408943}
Commit  : 33e8546b6e54b2a38d9baa327f45238cf6d64c28
Date    : Mon Aug 01 11:50:46 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@408937  3297048  40692.9  5  good
chromium@408941  3318347  18680.6  5  good
chromium@408942  3285579  13145.5  5  good
chromium@408943  3412760  39542.8  5  bad    <--
chromium@408945  3416856  32043.2  5  bad
chromium@408953  3420952  39436.6  5  bad
chromium@408968  3433240  37248.8  5  bad
chromium@408999  3451262  25149.6  5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 633942

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_search-memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/load_search_baidu
Relative Change: 4.68%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/808
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005329407689198304


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5747422773379072

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment