New audio rendering mixing strategy does not work correctly with setSinkId on Chrome 54+ |
|||||||
Issue descriptionCreated from https://bugs.chromium.org/p/webrtc/issues/detail?id=6142 Copy of the description: What steps will reproduce the problem? 1. Go to https://dev-licode1.hirevue.net:3004/ on Chrome 54+ 2. Open another tab, and go to the same page What is the expected result? user can hear audio from the other tab, and vice-versa. What do you see instead? user cannot hear audio from the other tab. If you open the second tab in Chrome 53 or lower, the Chrome 53 user *will* be able to hear the Chrome 54 user, but the Chrome 54 user cannot hear the Chrome 53 user. So not a microphone issue, but an output device issue What version of the product are you using? On what operating system? Version 54.0.2807.0 canary (64-bit) on OSX 10.9.5 Please provide any additional information below. This defect is somehow related to a new flag, chrome://flags/#new-audio-rendering-mixing-strategy and the video tag's setSinkId(). If I comment this code out on the page above: ``` var audioSinkChanged = function(event) { that.video.setSinkId(event.sinkId) .then(function() { L.Logger.info('Success, audio output device attached: ' + event.sinkId + ' to ' + that.id); }) .catch(function(error) { L.Logger.error(error); }); }; ``` ...it does not reproduce. Likewise, if I disable that new audio mixing mode feature, it does not reproduce. So some errant interaction between those two features.
,
Aug 3 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/169b21453f01ede1a2d4ed100f5b6cadf100536d commit 169b21453f01ede1a2d4ed100f5b6cadf100536d Author: olka <olka@chromium.org> Date: Wed Aug 03 11:48:56 2016 Making WebRtcAudioRenderer sink to always play after start. BUG= 633930 Review-Url: https://codereview.chromium.org/2204143002 Cr-Commit-Position: refs/heads/master@{#409493} [modify] https://crrev.com/169b21453f01ede1a2d4ed100f5b6cadf100536d/content/renderer/media/webrtc_audio_renderer.cc
,
Aug 3 2016
,
Aug 8 2016
[triage] olka@ do you think this warrants a unit test?
,
Aug 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f82d25be084cd948d6f707ef87df8f61afcbf15f commit f82d25be084cd948d6f707ef87df8f61afcbf15f Author: olka <olka@chromium.org> Date: Sun Aug 21 05:22:07 2016 Make sure WebRtcAudioRenderer always plays sink after starting it. BUG= 633930 Review-Url: https://codereview.chromium.org/2254753002 Cr-Commit-Position: refs/heads/master@{#413368} [modify] https://crrev.com/f82d25be084cd948d6f707ef87df8f61afcbf15f/content/renderer/media/webrtc_audio_renderer_unittest.cc
,
Aug 23 2016
Thanks for adding the test!
,
Aug 31 2016
,
Sep 7 2016
Verified in M54 dev 54.0.2840.14 in Win, Mac, Linux. .. able to hear Audio from the other tab after opening https://dev-licode1.hirevue.net:3004/ in 2 tabs |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by olka@chromium.org
, Aug 3 2016