New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633930 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
OOO Dec 22 - Jan 8
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

New audio rendering mixing strategy does not work correctly with setSinkId on Chrome 54+

Project Member Reported by olka@chromium.org, Aug 3 2016

Issue description

Created from https://bugs.chromium.org/p/webrtc/issues/detail?id=6142

Copy of the description:

What steps will reproduce the problem?
1. Go to https://dev-licode1.hirevue.net:3004/ on Chrome 54+
2. Open another tab, and go to the same page

What is the expected result?

user can hear audio from the other tab, and vice-versa.

What do you see instead?

user cannot hear audio from the other tab.  If you open the second tab in Chrome 53 or lower, the Chrome 53 user *will* be able to hear the Chrome 54 user, but the Chrome 54 user cannot hear the Chrome 53 user.  So not a microphone issue, but an output device issue


What version of the product are you using? On what operating system?

Version 54.0.2807.0 canary (64-bit) on OSX 10.9.5

Please provide any additional information below.

This defect is somehow related to a new flag, chrome://flags/#new-audio-rendering-mixing-strategy and the video tag's setSinkId().  If I comment this code out on the page above:

```
    var audioSinkChanged = function(event) {
        that.video.setSinkId(event.sinkId)
            .then(function() {
                L.Logger.info('Success, audio output device attached: ' + event.sinkId + ' to ' + that.id);
            })
            .catch(function(error) {
                L.Logger.error(error);
            });
    };
```

...it does not reproduce.  Likewise, if I disable that new audio mixing mode feature, it does not reproduce.  So some errant interaction between those two features.

 

Comment 1 by olka@chromium.org, Aug 3 2016

Components: Internals>Media>Audio

Comment 2 by olka@chromium.org, Aug 3 2016

Components: Blink>WebRTC>Audio
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169b21453f01ede1a2d4ed100f5b6cadf100536d

commit 169b21453f01ede1a2d4ed100f5b6cadf100536d
Author: olka <olka@chromium.org>
Date: Wed Aug 03 11:48:56 2016

Making WebRtcAudioRenderer sink to always play after start.

BUG= 633930 

Review-Url: https://codereview.chromium.org/2204143002
Cr-Commit-Position: refs/heads/master@{#409493}

[modify] https://crrev.com/169b21453f01ede1a2d4ed100f5b6cadf100536d/content/renderer/media/webrtc_audio_renderer.cc

Comment 4 by olka@chromium.org, Aug 3 2016

Status: Fixed (was: Started)
Labels: MissingTests
[triage] olka@ do you think this warrants a unit test?
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82d25be084cd948d6f707ef87df8f61afcbf15f

commit f82d25be084cd948d6f707ef87df8f61afcbf15f
Author: olka <olka@chromium.org>
Date: Sun Aug 21 05:22:07 2016

Make sure WebRtcAudioRenderer always plays sink after starting it.

BUG= 633930 

Review-Url: https://codereview.chromium.org/2254753002
Cr-Commit-Position: refs/heads/master@{#413368}

[modify] https://crrev.com/f82d25be084cd948d6f707ef87df8f61afcbf15f/content/renderer/media/webrtc_audio_renderer_unittest.cc

Labels: -MissingTests
Thanks for adding the test!
Labels: M-54
Status: Verified (was: Fixed)
Verified in M54 dev 54.0.2840.14 in Win, Mac, Linux. 
.. able to hear Audio from the other tab after opening https://dev-licode1.hirevue.net:3004/ in 2 tabs 

Sign in to add a comment