New issue
Advanced search Search tips

Issue 633898 link

Starred by 3 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Bug: MD Settings Search engine removal

Reported by lukewaym...@gmail.com, Aug 3 2016 
In material design settings, removing a search engine from list does not remove the popup menu after removal

Comment 1 by tbuck...@chromium.org, Aug 10 2016

Cc: dpa...@chromium.org
Labels: Hotlist-MD-Settings-SearchEngines
Owner: bettes@chromium.org
Status: Assigned (was: Unconfirmed)
This is actually the next item's dropdown, making it more convenient for removing a bunch of search engines at once. But we should make that clearer.

@bettes, any thoughts?

Comment 2 by tbuck...@chromium.org, Aug 10 2016

Labels: -Pri-2 Pri-3

Comment 3 by tbuck...@chromium.org, Sep 12 2016

Labels: -Pri-3 Pri-2
Owner: ----
Status: Available (was: Assigned)
We should just close the dropdown.

Comment 4 by kavvaru@chromium.org, Sep 12 2016 

 Issue 641669  has been merged into this issue.

Comment 5 by dpa...@chromium.org, Sep 26 2016

Cc: -dpa...@chromium.org
Owner: dpa...@chromium.org
Status: Assigned (was: Available)

Comment 6 by dpa...@chromium.org, Oct 19 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9

commit 9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 19 21:57:12 2016

MD Settings: Close action menu when search engine is removed.

BUG= 657254 , 633898 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2425423005
Cr-Commit-Position: refs/heads/master@{#426297}

[modify] https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9/chrome/test/data/webui/settings/search_engines_page_test.js

Comment 8 by dpa...@chromium.org, Oct 19 2016

Status: Fixed (was: Started)

Comment 9 by vanantwe...@gmail.com, Jan 21 2017 

Verified in the latest build
►

Sign in to add a comment