New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633883 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

args[1]->IsString() in runtime-strings.cc

Project Member Reported by ClusterFuzz, Aug 3 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5775722570579968

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args[1]->IsString() in runtime-strings.cc
  
Regressed: V8: r38265:38266

Minimized Testcase (0.12 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95qzDYs2blItU3UeCjLIw4-xABgVEU9qq39VsBzF9ELWGqIya-VmZjrlbX-UpVTQZ4f7vbSuxiZmpA21hPll3kEl3-3Zf3TOEtVaJ0Ygf0MsIuDsIP4CrUweh0Vw-VK-4ZANYEQK3ew88YR-TDBnC3LOrEuyw?testcase_id=5775722570579968
 v5 = new Array(); 
 v17 = encodeURIComponent(v5); 
 v19 = isFinite(); 
 v34 = new Array(v19); 
 v47 = v34.includes(v17); 


Filer: mstarzinger

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: ca...@igalia.com cbruni@chromium.org rossberg@chromium.org
Status: Available (was: Untriaged)
Regression range and repro point towards Array.prototype.includes CL.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c4ee3d94740f865f485173f4a3a194b6973f2d34

commit c4ee3d94740f865f485173f4a3a194b6973f2d34
Author: caitp <caitp@igalia.com>
Date: Wed Aug 03 14:26:44 2016

[builtins] fix mapcheck in Array.includes fast-case when searching for String

Use LoadInstanceType() rather than LoadMapInstanceType(), as this part of the
code is operating on a JS-accessible HeapObject rather than a Map.

BUG= chromium:633883 ,  v8:5162 
R=mstarzinger@chromium.org, bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2207903002
Cr-Commit-Position: refs/heads/master@{#38297}

[modify] https://crrev.com/c4ee3d94740f865f485173f4a3a194b6973f2d34/src/builtins/builtins-array.cc
[add] https://crrev.com/c4ee3d94740f865f485173f4a3a194b6973f2d34/test/mjsunit/es7/regress/regress-633883.js

Project Member

Comment 3 by ClusterFuzz, Aug 4 2016

ClusterFuzz has detected this issue as fixed in range 38296:38297.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5775722570579968

Fuzzer: v8_builtins_generator
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args[1]->IsString() in runtime-strings.cc
  
Regressed: V8: r38265:38266
Fixed: V8: r38296:38297

Minimized Testcase (0.12 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv95qzDYs2blItU3UeCjLIw4-xABgVEU9qq39VsBzF9ELWGqIya-VmZjrlbX-UpVTQZ4f7vbSuxiZmpA21hPll3kEl3-3Zf3TOEtVaJ0Ygf0MsIuDsIP4CrUweh0Vw-VK-4ZANYEQK3ew88YR-TDBnC3LOrEuyw?testcase_id=5775722570579968
 v5 = new Array(); 
 v17 = encodeURIComponent(v5); 
 v19 = isFinite(); 
 v34 = new Array(v19); 
 v47 = v34.includes(v17); 


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Aug 4 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment