New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633877 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary focus ring is seen on 'Guest' profile icon.

Reported by rk...@etouch.net, Aug 3 2016

Issue description

Chrome Version: 54.0.2817.0 (Official Build) Revision cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416} 
OS: Mac (10.10.5,10.11.4)

Pre-condition: Enable material design user menu flag from chrome://flags.

What steps will reproduce the problem?
(1) Launch chrome,switch to 'Guest' mode, click on avatar icon.
(2) Press 'Tab' key (Focus ring is seen on Guest profile), hitt 'Enter' or 'Space bar' and observe.

Nothing is happened after hitting 'Enter' key when focus is on Guest profile.

Focus ring should not seen on Guest profile.

This is regression issue, broken in 'M 54’ and below is narrow bisect:

Good build:54.0.2801.0
Bad build:54.0.2802.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/8cc17dd5bd16119157decba981d11f1e217052dd..e6fcf92ec826c6b56672eec154e2075b1d01cf60?pretty=fuller&n=100

Suspecting: r406377 

Note: Issue is not seen Windows and Linux OS.

@rogerta: Please help me to reassign this issue, if you change is not cause for it.
 
Actual_Focus.mov
1012 KB Download

Comment 1 by rk...@etouch.net, Aug 3 2016

Summary: Regression: Unnecessary focus ring is seen on 'Guest' profile icon. (was: Regression: Nothing is happened after hitting 'Enter' key when focus ring is on 'Guest' profile icon.)
Correction in Actual Result:

Unnecessary focus ring is seen on guest profile icon.
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Able to reproduce the issue on Mac OS 10.11.6 using chrome latest canary M54-54.0.2823.0 as well.
	
Rogerta@ - Any update on this bug? Since this issue is marked as RB-Stable could you please have a look in to it. Incase if it's not related to your change please feel free to reassign it to the concerned Dev person.

Thanks!
Sorry about the delayed update, this issue is indeed cause by the suspected CL. I will submit a fix in the next few days. Thanks!

Comment 5 by ew...@chromium.org, Aug 8 2016

Labels: md-usermenu

Comment 6 by ew...@chromium.org, Aug 9 2016

Labels: -ReleaseBlock-Stable
This isn't releaseblock-stable, since this is behind a flag.
I tried with 54.0.2823.0 and 54.0.2828.0 on my MBA, and I am not able to repro.  I have seen similar problems with focus rings before on macs, and I suspect there is a user setting that causes this.  Might be worth playing with OS user settings.

Also, if you press the TAB key the ring appears, allows you to tab through the menu items.  This is by design wrt mac UI.  Are you sure you didn't press a key or something (in the video, there is a delay for the focus ring to appear)?

I was able to repro on my mac, and the problem was that these user menu buttons we had don't disable focus ring when the button itself is disabled. I will submit a fix that disables focus for any disabled buttons in the user menu.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2995fb57c078db3de42e5ad46faf5ad428e80d

commit bd2995fb57c078db3de42e5ad46faf5ad428e80d
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Aug 11 14:29:24 2016

[Mac][MD User Menu] UI Tweaks

Specifically:
1. Fixed misalignment between user menu and avatar button (see bug #1)
2. Fixed pixelated profile icon border (see  bug #2 )
3. Fixed certain letters being cut off on the bottom for avatar name
4. Disabled the color change for button icons upon mouse down
5. Disabled focus for buttons that are disabled (see  bug #3 )

See comparative screenshots:
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGWUtYM29OdnVjQm8

BUG= 632936 
BUG= 633175 
BUG= 633877 

BUG= 615893 

Review-Url: https://codereview.chromium.org/2197253002
Cr-Commit-Position: refs/heads/master@{#411323}

[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The above CL would prevent focus rings from appearing on disabled buttons.

Comment 11 by rk...@etouch.net, Aug 18 2016

Just to update:

Issue is fixed in latest canary build 54.0.2831.0
Labels: TE-Verified-M54 TE-Verified-54.0.2835.0
Rechecked this on chrome version 54.0.2835.0 on MAC 10.11.6. Fix is working as intended. Adding TE-Verified labels.

Comment 13 by ew...@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)

Sign in to add a comment