New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633869 link

Starred by 3 users
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 529938



Sign in to add a comment

Regression : Background contents at the bottom of page are seen missing after clicking on ‘Full screen’ button.

Reported by yfulgaon...@etouch.net, Aug 3 2016 
Chrome Version: 54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416} (64-bit)
OS: Mac (10.10.5, 10.11.5)

Precondition : Sign in to chrome using valid credentials.

What steps will reproduce the problem?
1. Launch chrome, go to chrome://settings page and hit cmd+P.
2. Now click on ‘Full screen’ button at top LHS and observe the bottom part of page. 

Actual : Background contents at the bottom of page are seen missing after clicking on ‘Full screen’ button.

Expected : Background contents at the bottom of page should be visible after clicking on ‘Full screen’ button.

This is a regression issue broken in M-54, below is Manual Regression info and will soon update other info.

Manual Regression :
Good build: 54.0.2816.0
Bad build: 54.0.2817.0
Actual.mov
6.3 MB Download
Expected.mov
5.0 MB Download

Comment 1 by yfulgaon...@etouch.net, Aug 3 2016

Components: UI>Browser>FullScreen
Labels: hasbisect OS-Linux OS-Windows
Owner: wkorman@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect : 
https://chromium.googlesource.com/chromium/src/+log/cae1058e62b7960796709512c4e1e650b6389c0f..994c65ef57ec7c84b18fd66d7b8b85e5a2dc29bd?pretty=fuller&n=10000

Suspecting: r409291 ? from narrow bisect

@wkorman : Please help to re-assign if your change is not the cause for this issue.

Note : 
1. Issue is also reproducible on Windows and Linux OS.
2. Above issue is also seen on chrome://extensions/ page.

Comment 2 by ranjitkan@chromium.org, Aug 3 2016

Labels: -Pri-1 ReleaseBlock-Beta Pri-0
Adding release block label, please undo if not the case.

Comment 3 by thestig@chromium.org, Aug 3 2016

Labels: -Pri-0 Pri-2
ranjitkan: This is not a Pri-0 bug. Pri-0 means "dire emergency" and this is not that.

Comment 4 by wkorman@chromium.org, Aug 3 2016 

I am looking into this now.

Comment 5 by wkorman@chromium.org, Aug 3 2016

Components: Blink>Paint
Able to reproduce on Mac at ToT. Confirmed that syncing to my commit produces issue, and preceding commit does not. Looking further.

Comment 6 by wkorman@chromium.org, Aug 4 2016

Cc: chrishtr@chromium.org
Partial reduction from chrome://settings attached. To reduce further tomorrow.
index.html
1.1 KB View Download
frame.html
3.2 KB View Download

Comment 7 by wkorman@chromium.org, Aug 5 2016 

I am preparing a revert due to  http://crbug.com/634823  to land today and will continue looking into this to fix for re-land.

Comment 8 by wkorman@chromium.org, Aug 5 2016

Blocking: 529938

Comment 9 by wkorman@chromium.org, Aug 5 2016 

Updated reduced test case attached.
index.html
596 bytes View Download
frame.html
89 bytes View Download

Comment 10 by wkorman@chromium.org, Aug 5 2016 

Note the above test case doesn't actually require print dialog. Just opening the test case in content shell and subsequently resizing the window vertically to be tall enough that the text should be visible results in an incorrect empty view.

Comment 11 by wkorman@chromium.org, Aug 5 2016 

The text isn't painted at all initially. During subsequent resize frames as the text becomes visible, every drawing display item for the text has an empty visual rect, and is marked as cached:

{index: 4, client: "0x116a3b640010 InlineTextBox 'Foo'", type: "DrawingPaintPhaseForeground", rect: [8.000000,700.000000 52.000000x36.000000], cacheIsValid: true, visualRect: [0,0 0x0]},
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/490867260447e9360b52d5c03417b000490332e0

commit 490867260447e9360b52d5c03417b000490332e0
Author: wkorman <wkorman@chromium.org>
Date: Fri Aug 05 22:24:57 2016

Revert "Raster display item lists via a visual rect RTree."

Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and
DevTools.

Original change description:

    Raster display item lists via a visual rect RTree.

    Rather than caching and playing back an entire SkPicture
    when rastering a display item list for a particular
    playback rect, instead retain display items and query
    them via an RTree of their visual rects to find and
    raster only what's needed.

    Display item lists no longer support the notion of a
    bounding "layer rect" with mutable origin.

    DisplayItemListSettings proto is obsolete after this
    change as it's comprised solely of one field to allow
    switching whether to use the aforementioned now-deleted
    cached SkPicture code path. It will be deleted in a
    subsequent patch.

Revert "Raster display item lists via a visual rect RTree."

This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51.

Revert "Don't clear visual rects when finalizing display item lists for now."

This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e.

Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition."

This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d.

BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 
TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2217263003
Cr-Commit-Position: refs/heads/master@{#410190}

[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_content_layer_impl.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_display_item_list_impl.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.h
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/empty_content_layer_client.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/discardable_image_map_unittest.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.h
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/recording_source.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/proto/display_item.proto
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/skia_common.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/canvas_painter.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/layer.cc
[modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/views/view_unittest.cc

Comment 13 by wkorman@chromium.org, Aug 5 2016 

This bug is related to  http://crbug.com/490725 . http://crrev.com/2212403004 is in flight though it is a future-fix, as it is only needed for with-rtree code and revert of that has already landed.

Comment 15 by wkorman@chromium.org, Aug 6 2016

Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817

commit c1fc4c8a7eadf9a0a5f296228372e5a3ed309817
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sat Aug 06 01:24:51 2016

Auto-rebaseline for r410222

https://chromium.googlesource.com/chromium/src/+/74d1e7374

BUG= 633869 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2221693002 .

Cr-Commit-Position: refs/heads/master@{#410243}

[modify] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.png
[rename] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/c1fc4c8a7eadf9a0a5f296228372e5a3ed309817/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/resize-iframe-text-expected.png

Comment 17 by tkonch...@chromium.org, Aug 9 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2824.0
Tested the same on mac 10.11.5, win7,8.1 using chrome version 54.0.2824.0 and Linux using chrome version 54.0.2823.0 - Background contents at the bottom of page are visible after clicking on ‘Full screen’ button.

Please find the screenshot

Comment 18 by tkonch...@chromium.org, Aug 9 2016

Screen Shot 2016-08-09 at 11.22.19 AM.png
545 KB View Download

Comment 19 by tkonch...@chromium.org, Aug 9 2016

Labels: TE-Verified-54.0.2823.0
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0c98a9d507510dbb7023b38fab8f786e882e11

commit ee0c98a9d507510dbb7023b38fab8f786e882e11
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 13:46:06 2016

Revert of Include non-composited layout views in existing workaround for clipping changes. (patchset #3 id:40001 of https://codereview.chromium.org/2212403004/ )

Reason for revert:
fast/repaint/resize-iframe-text.html is failing on Mac and Win.

The CL was landed with [ NeedsRebaseline ], so also remove the platform
expectations added with https://codereview.chromium.org/2221693002

BUG= 635892 

Original issue's description:
> Include non-composited layout views in existing workaround for clipping changes.
>
> BUG= 633869 
>
> Committed: https://crrev.com/74d1e73747b73764b50dfaf413344397c14b971f
> Cr-Commit-Position: refs/heads/master@{#410222}

TBR=chrishtr@chromium.org,wkorman@chromium.org
BUG= 633869 

Review URL: https://codereview.chromium.org/2220423004 .

Cr-Commit-Position: refs/heads/master@{#410652}

[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/fast/repaint/resize-iframe-text.html
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/resize-iframe-text-expected.png
[modify] https://crrev.com/ee0c98a9d507510dbb7023b38fab8f786e882e11/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d58aef05951368778eda5aa835969a8f04bf285

commit 3d58aef05951368778eda5aa835969a8f04bf285
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Aug 10 01:41:19 2016

Auto-rebaseline for r410893

https://chromium.googlesource.com/chromium/src/+/f4f6b5170

BUG= 633869 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2230713002 .

Cr-Commit-Position: refs/heads/master@{#410913}

[modify] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.txt
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.png
[add] https://crrev.com/3d58aef05951368778eda5aa835969a8f04bf285/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.txt

Comment 22 by foolip@chromium.org, Aug 10 2016 

Relanded again in https://chromium.googlesource.com/chromium/src/+/f4f6b5170078b6312f775e86ca90dc295b3db956 but a typo in the BUG= line means it didn't show up here.
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12ee9251fb9f0745f1273b228c10cdd3308b1a12

commit 12ee9251fb9f0745f1273b228c10cdd3308b1a12
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 10 08:31:40 2016

Mark fast/repaint/resize-iframe-text.html as flaky on Mac10.10

BUG= 636271 , 633869 
TBR=wkorman@chromium.org,chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2230153002 .

Cr-Commit-Position: refs/heads/master@{#411005}

[modify] https://crrev.com/12ee9251fb9f0745f1273b228c10cdd3308b1a12/third_party/WebKit/LayoutTests/TestExpectations

Comment 24 by ssamanoori@chromium.org, Aug 16 2016

Labels: TE-Verified-54.0.2830.0
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 54.0.2830.0.Observed that background contents at the bottom of page are visible after clicking on ‘Full screen’ button.

Please find attached screenshot.
633869.png
570 KB View Download
►

Sign in to add a comment