New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633868 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In Switch person window, User profile does not get selected on pressing Enter key.

Reported by vvishwak...@etouch.net, Aug 3 2016 
Version: 54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416} (32/64-bit)
OS: Mac (10.10.5, 10.11.5)

What steps will reproduce the problem?
(1) Launch chrome, click on avatar icon and select Switch person.
(2) Press Tab key (focus is on Person 1), now press Enter key and observe.

On pressing Enter key focus, Switch person window should close and focus should be on Person 1 window.

On pressing Enter key focus nothing happens.

This is a Regression issue broken in M-54, will soon update other info

Comment 1 by vvishwak...@etouch.net, Aug 3 2016

Labels: hasbisect OS-Linux OS-Windows
Owner: sammiequon@chromium.org
Status: Assigned (was: Unconfirmed)
Manual bisect:
Good build: 54.0.2815.0
Bad build: 54.0.2816.0

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5..bf22fa93e4003d0a0210ab679b60b784a6e38761?pretty=fuller&n=100

Suspecting: r408985

Note: Issue is reproducible on Windows (7,8,10) and Linux (14.04 LTS) OS.
profile_actual.mov
1.5 MB Download
profile_expected.mov
1.6 MB Download

Comment 2 by ranjitkan@chromium.org, Aug 3 2016

Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.

Comment 3 by sammiequon@chromium.org, Aug 5 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442e7d64266217feb0d6299a8d31773d73775ecf

commit 442e7d64266217feb0d6299a8d31773d73775ecf
Author: sammiequon <sammiequon@chromium.org>
Date: Fri Aug 05 19:40:53 2016

Fixes keyboard event related bugs in switch person window.

BUG= 633058 , 633868 

Review-Url: https://codereview.chromium.org/2213563003
Cr-Commit-Position: refs/heads/master@{#410147}

[modify] https://crrev.com/442e7d64266217feb0d6299a8d31773d73775ecf/ui/login/account_picker/user_pod_row.js

Comment 5 by ranjitkan@chromium.org, Aug 9 2016 

Just to update still able to reproduce the issue on Windows 7, MAC 10.11.6 for chrome version 54.0.2824.0. Issue is marked with a beta blocker. 

@sammiequon: Request you to please take a look into it
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7dc827035d1a11c8d0489005ecc76b74785790c

commit a7dc827035d1a11c8d0489005ecc76b74785790c
Author: sammiequon <sammiequon@chromium.org>
Date: Tue Aug 09 17:58:37 2016

Fix bug in switch person window where enter button did not work.

BUG= 633868 

Review-Url: https://codereview.chromium.org/2223293005
Cr-Commit-Position: refs/heads/master@{#410739}

[modify] https://crrev.com/a7dc827035d1a11c8d0489005ecc76b74785790c/ui/login/account_picker/user_pod_row.js

Comment 7 by durga.behera@chromium.org, Aug 12 2016

Labels: TE-Verified-54.0.2827.0 TE-Verified-M54
Verified he issue on Mac 10.11.6,Win 7 and Ubuntu 14.04 using 54.0.2827.0 and its working.Please find the screen cast for the same.

Addded respective TE-Verified labels for the same.
sammiequon@ : Could you please update the status to Fixed/Verified if there is no further work to be done on it.
633868_Aug_12.mp4
547 KB View Download

Comment 8 by sammiequon@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment