New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633859 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : User Manager becomes unresponsive on clicking CANCEL Button

Project Member Reported by mm00333...@techmahindra.com, Aug 3 2016

Issue description

Version: 54.0.2817.0
OS: Ubuntu 14.04

Precondition: 
Enable 'Material Design User Manager' flag from 'chrome://flags'

What steps will reproduce the problem?
(1)Launch chrome -> click on avatar icon 
(2)Now click on 'Switch person' option for User Manager window-> Select 'ADD PERSON' 
(3)Now click on 'CANCEL' Button and Now try to click on Person , Buttons and observe

Expected: User Manager should not become unresponsive i.e. should be able to click on Buttons,Person
Actual:Instead User Manager becomes unresponsive on clicking CANCEL Button


Please use labels and text to provide additional information.

 

Comment 1 by ajha@chromium.org, Aug 3 2016

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Issue is reproducible on the latest canary(54.0.2817.0) on Mac OS 10.11.5. 
Labels: -Needs-Bisect hasbisect OS-Windows
Owner: mahmadi@chromium.org
Status: Assigned (was: Untriaged)
Issue is seen on Windows OS also.
Attaching Expected and Actual Videos

Manual good and Bad Builds:
Good Build: 54.0.2816.0
Bad Build:  54.0.2817.0

Note : Unable to find suspect from below changelog URL

CHANGELOG URL::
https://chromium.googlesource.com/chromium/src/+log/557c21bc2cf9d2f735c91a47ce732268a7efdb88..b1205edbd51bf546deb4296a963669c918b6f596


So providing MANUAL CHANGELOG URL::
https://chromium.googlesource.com/chromium/src/+log/54.0.2816.0..54.0.2817.0?pretty=fuller&n=10000


Suspecting https://codereview.chromium.org/2168953002 from Manual Changelog

@mahmadi :  Please feel free to re-assign if its not related to your change
Actual_UserMAnager.ogv
1.5 MB View Download
Expected_UserMAnager.ogv
2.3 MB View Download
Labels: ReleaseBlock-Stable
Adding Stable Blocker as this is a Recent Regression on M54.
Please feel free to remove if not required
Owner: sashab@chromium.org
Hi sashab@, I narrowed down the bisect to your commit:

https://chromium.googlesource.com/chromium/src/+/f24dba9f04dd093aac4298378c671ecd44d0fe97

Could you please investigate?

Labels: -ReleaseBlock-Stable le
Oh wow, this really is caused by my change! :/

I don't think this needs to be a Stable ReleaseBlock since this functionality is behind a flag.

But I will investigate... Thanks for pointing out! I'll try make a minimal test case as well since my change didn't touch the user manager directly, only WebKit.
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Labels: -Pri-2 -le ReleaseBlock-Dev Pri-1
If you broke something core to the style engine it's definitely release blocking. I would suggest you roll out your patch while you try to understand this, leaving something core broken on trunk when we know it causes breakage in an app (in chrome behind a flag or otherwise) is bad.
Cc: mahmadi@chromium.org
MD User Manager will be rolled out in M53. There could be other things are affected too. I also suggest your CL be reverted until we know why it causes the breakage. Thank you.
Please have the fix ready asap as we are planning to do another Dev release this coming Tuesday.
This is working fine on current canary build 54.0.2823.0 - Win7/64 bit, Mac OSX 10.11.5 & Linux/Ubuntu 14.04

Please mark this bug as Fixed.

Comment 14 by ajha@chromium.org, Aug 9 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2824.0
Just to confirm, this is working fine on the latest canary Windows-7 (54.0.2824.0-PGO(64 bit)), Mac OS 10.11.5 and 54.0.2823.0 on Linux.

Adding the verified label therefore.

Comment 15 by ajha@chromium.org, Aug 9 2016

Labels: TE-Verified-54.0.2823.0
Status: Fixed (was: Started)

Sign in to add a comment