Regression: [Md Settings] Focus doesn't traverse through side nav bar.
Reported by
dchau...@etouch.net,
Aug 3 2016
|
||||||||||||||||
Issue descriptionChrome Version: 53.0.2785.45 (Official Build) 70a7d200b65a4bc8fa957bfa8a8ad8bc8f429bdb-refs/branch-heads/2785@{#477} 32/64-bit. OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings. 2. Keep focus on toolbar menu icon and press 'Enter' key. 3. Now, press 'Tab' key from keyboard and observe the focus. Focus doesn't traverse to side nav bar. Focus should traverse through side nav bar. This is a regression issue, broken in M-50 series, below is bisect info. Good build: 50.0.2641.0 Bad build: 50.0.2643.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/7cadea4c77674b8f2c4b8842877de2d5d8d5670f..1784be25c32a243547048a8f426253dd12262529?pretty=fuller&n=100 Suspecting: r373893 KIndly review the attached screen-cast for reference.
,
Aug 19 2016
,
Sep 8 2016
,
Sep 8 2016
,
Sep 8 2016
,
Nov 2 2016
I've been working on this issue. Solution is two part: 1. Fix tab capture by using a dialog for the side nav 2. Fix tab-ability of elements by updating how menus are used
,
Nov 2 2016
,
Nov 4 2016
Issue 605108 has been merged into this issue.
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae4924a123c42de82f4fef429cc176ee9065785 commit bae4924a123c42de82f4fef429cc176ee9065785 Author: hcarmona <hcarmona@chromium.org> Date: Tue Dec 13 16:27:20 2016 Create implementation of the side panel using a dialog. Using a dialog is a much cleaner solution because it handles all focus trapping without attempting to capture TAB or require updating all tabindex properties. We removed the ability to swipe the drawer open in order to keep the code simple. BUG= 633858 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2465433002 Cr-Commit-Position: refs/heads/master@{#438187} [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/controls/compiled_resources2.gyp [add] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/controls/dialog_drawer.html [add] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/controls/dialog_drawer.js [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/test/data/webui/settings/rtl_tests.js [modify] https://crrev.com/bae4924a123c42de82f4fef429cc176ee9065785/chrome/test/data/webui/settings/settings_ui_browsertest.js
,
Dec 13 2016
This is not fixed yet, but the CL that landed is a big step in the right direction.
,
Dec 20 2016
,
Dec 20 2016
,
Jan 6 2017
,
Jan 26 2017
Screenshots showing selection for http://crrev.com/2651293003. It's based on chrome://history and color/style matches that.
,
Feb 15 2017
Issue 686307 has been merged into this issue.
,
Feb 15 2017
Issue 686331 has been merged into this issue.
,
Feb 15 2017
Issue 686305 has been merged into this issue.
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26ccb9043c276fb76b875f90361ef5b58acc510 commit f26ccb9043c276fb76b875f90361ef5b58acc510 Author: hcarmona <hcarmona@chromium.org> Date: Thu Feb 16 17:42:13 2017 Make MD Settings side bar keyboard accessible. Screenshots in bug. BUG= 633858 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2651293003 Cr-Commit-Position: refs/heads/master@{#451007} [modify] https://crrev.com/f26ccb9043c276fb76b875f90361ef5b58acc510/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/f26ccb9043c276fb76b875f90361ef5b58acc510/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/f26ccb9043c276fb76b875f90361ef5b58acc510/chrome/test/data/webui/settings/settings_menu_test.js [modify] https://crrev.com/f26ccb9043c276fb76b875f90361ef5b58acc510/chrome/test/data/webui/settings/settings_ui_browsertest.js
,
Feb 16 2017
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Aug 5 2016