New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633851 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 625781



Sign in to add a comment

Tricium Configuration

Project Member Reported by emso@chromium.org, Aug 3 2016

Issue description

Specification of the Tricium configuration outlined in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Vmr1FOCx7cU, together with a validator for that specification.

The specification should support the suggested division between a global and project-specific configuration.
 

Comment 1 by emso@chromium.org, Aug 3 2016

Components: Infra>CodeAnalysis
Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3966af069b7af14fd0966505a5b956eb0d2f9d86

commit 3966af069b7af14fd0966505a5b956eb0d2f9d86
Author: Emma Soederberg <emso@chromium.org>
Date: Fri Sep 02 05:54:45 2016

Tricium configuration for testing.

This is just the first step in adding the configuration: a specification and two examples.
A validator and a converter, together with tests, will be added later.

BUG= 633851 

Change-Id: I9177d2bfc78e886b4e6586c9ecde83c479cc52f0
Reviewed-on: https://chromium-review.googlesource.com/378915
Reviewed-by: Paweł Hajdan Jr. <phajdan@google.com>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[add] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/config/tricium.cfg
[add] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/proto/tricium.pb.go
[add] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/proto/tricium.proto
[add] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/tricium.cfg

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c0b7abe6f3015773a1b21c541fe1e5e3c9fd9bb2

commit c0b7abe6f3015773a1b21c541fe1e5e3c9fd9bb2
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Sep 06 15:49:01 2016

Revert of Tricium configuration for testing.

Reason for revert: broke tree https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-32/builds/3599
NOPRESUBMIT=True
NOTRY=True
NOTREECHECKS=True
TBR=emso@chromium.org


Original issue's description:
> Tricium configuration for testing.
> 
> This is just the first step in adding the configuration: a specification and two examples.
> A validator and a converter, together with tests, will be added later.
> 
> BUG= 633851 
> 
> Change-Id: I9177d2bfc78e886b4e6586c9ecde83c479cc52f0
> Reviewed-on: https://chromium-review.googlesource.com/378915
> Reviewed-by: Paweł Hajdan Jr. <phajdan@google.com>
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> 

Change-Id: If8e9aaeb64057b6ba67deb2a3249b5c7ecdf8073
Reviewed-on: https://chromium-review.googlesource.com/381491
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/config/tricium.cfg
[delete] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/proto/tricium.pb.go
[delete] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/proto/tricium.proto
[delete] https://crrev.com/3966af069b7af14fd0966505a5b956eb0d2f9d86/go/src/infra/tricium/tricium.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/80d8e5ffb464d78d574933574626c9819df7f6b2

commit 80d8e5ffb464d78d574933574626c9819df7f6b2
Author: Emma Soederberg <emso@chromium.org>
Date: Fri Sep 16 12:49:17 2016

Cleans up Tricium configs moved elsewhere

BUG= 633851 

Change-Id: I84d37efba3dd67f8ce5513c55b2c1ddd0909b40b
Reviewed-on: https://chromium-review.googlesource.com/385516
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan@google.com>

[delete] https://crrev.com/63d74e19bd023f459e0abbf73ffe20a05d88c06e/config/tricium.cfg
[delete] https://crrev.com/63d74e19bd023f459e0abbf73ffe20a05d88c06e/go/src/infra/tricium/tricium.cfg

Comment 8 by emso@chromium.org, Jan 11 2017

Labels: -Pri-2 Pri-1

Comment 9 by emso@chromium.org, Jan 11 2017

Labels: Tricium

Comment 10 by emso@chromium.org, Jan 17 2017

Labels: Milestone-Hello
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0

commit 9a5e8de6dad9d484f81a1913f2d9abef3f6553f0
Author: Emma Soederberg <emso@chromium.org>
Date: Sat Feb 04 11:10:29 2017

Adds the Config service.

BUG= 633851 

Change-Id: I639da77d54cb935178bcbd965bee86f5f86ca2a6
Reviewed-on: https://chromium-review.googlesource.com/428810
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/config.pb.go
[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/config.proto
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/tracker.pb.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/frontend/handlers.go
[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/config/rpc_validate_test.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/config/config.infra_testing
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/driver.pb.go
[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/config/init.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/launcher.pb.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/pb.discovery.go
[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/config/rpc_validate.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[delete] https://crrev.com/d7cd548992676ddce3f0b543f1abd7f16e6cf318/go/src/infra/tricium/appengine/config/handlers.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/config.proto
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/v1.infra_testing
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/frontend/rpc_analyze.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/config_helpers_test.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/v1/config_helpers.go
[add] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/appengine/config/rpc_generate_workflow.go
[modify] https://crrev.com/9a5e8de6dad9d484f81a1913f2d9abef3f6553f0/go/src/infra/tricium/api/admin/v1/workflow.pb.go

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bb858d6e6dcf6f447adad5a517ecca976378262a

commit bb858d6e6dcf6f447adad5a517ecca976378262a
Author: Emma Soederberg <emso@chromium.org>
Date: Wed Feb 22 17:32:38 2017

Adds the generate workflow RPC.

Also refactors how platforms are represented in the config.

BUG= 633851 

Change-Id: I43f5c204bde06348cf4418f51cd26b6aa4ce97d8
Reviewed-on: https://chromium-review.googlesource.com/438185
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/config/rpc_validate_test.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/config/rpc_validate.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/config_helpers_test.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/common/common.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/config.proto
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/admin/v1/workflow.proto
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/config_helpers.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/tricium.pb.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/config.pb.go
[add] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/platform.proto
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/config/config.infra_testing
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/v1.infra_testing
[add] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/config/rpc_generate_workflow_test.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/config/rpc_generate_workflow.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/admin/v1/config.pb.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/data.pb.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/data.proto
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/admin/v1/workflow.pb.go
[add] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/api/v1/platform.pb.go
[modify] https://crrev.com/bb858d6e6dcf6f447adad5a517ecca976378262a/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go

Comment 13 by emso@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment