[Findit] Indexed JsonProperties used where values could exceed 1500 bytes |
|||
Issue descriptionWhat is the bug or feature: WfFailureGroup.output_nodes and WfFailureGroup.failed_steps_and_tests both use ndb.JsonProperty(indexed=True), which (when indexed) has a max size of 1500 bytes. WfFailureGroup.output_nodes and WfFailureGroup.failed_steps_and_tests could both exceed 1500 bytes, which would cause an error. One solution is to use unindexed JsonProperties for WfFailureGroup.output_nodes and WfFailureGroup.failed_steps_and_tests.
,
Aug 5 2016
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/d6897e11508a50d02e7da183a61445c8654ce38a commit d6897e11508a50d02e7da183a61445c8654ce38a Author: josiahk <josiahk@google.com> Date: Wed Aug 10 00:50:11 2016 [Findit] Fix 1500 byte cap on failed_steps_and_tests and output_nodes Add created_time support for wf_failure_groups Disable indexing on failed_steps_and_tests and output_nodes BUG= 633837 Review-Url: https://codereview.chromium.org/2227223002 [modify] https://crrev.com/d6897e11508a50d02e7da183a61445c8654ce38a/appengine/findit/model/wf_failure_group.py [modify] https://crrev.com/d6897e11508a50d02e7da183a61445c8654ce38a/appengine/findit/waterfall/try_job_util.py
,
Aug 16 2016
Closed this bug as it seems fixed. Please reopen if not yet. |
|||
►
Sign in to add a comment |
|||
Comment 1 by chanli@chromium.org
, Aug 3 2016Components: Tools>Test>FindIt
Status: Available (was: Unconfirmed)