+pkasting Was that shortcut removed entirely? It seems there's a finch experiment to turn it back on.

It's removed unless the Finch experiment is running (which it won't be by default, that's an emergency escape switch in case something goes wrong).  So the shortcut likewise should not appear unless that's running.  If it's impossible to consult the Finch experiment status, then assume the shortcut is gone.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbfa3e92777e0b55429cac3c880f12237732385

commit abbfa3e92777e0b55429cac3c880f12237732385
Author: afakhry <afakhry@chromium.org>
Date: Thu Aug 04 21:06:39 2016

Remove "Go Back/Forward" from keyboard overlay

Only show these shortcuts if the finch experiment that turns them on is
enabled.

BUG= 633825 
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2206823004
Cr-Commit-Position: refs/heads/master@{#409900}

[modify] https://crrev.com/abbfa3e92777e0b55429cac3c880f12237732385/chrome/browser/resources/chromeos/keyboard_overlay.js
[modify] https://crrev.com/abbfa3e92777e0b55429cac3c880f12237732385/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/abbfa3e92777e0b55429cac3c880f12237732385/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/abbfa3e92777e0b55429cac3c880f12237732385/chrome/common/chrome_features.cc
[modify] https://crrev.com/abbfa3e92777e0b55429cac3c880f12237732385/chrome/common/chrome_features.h

 Issue 636527  has been merged into this issue.

It would be good to merge this to 53 if we think it's safe.

pkasting, is this CL safe to merge into M53; i.e. was that finch experiment introduced in M53?

A regression happened that made Alt+left/right shortcuts disappear. I'm fixing it now.

The changes here were done for M52 rather than 53, so it's definitely safe to merge patches to 53.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccff19d515c4615b5d7d420245c85b8e1c92ef73

commit ccff19d515c4615b5d7d420245c85b8e1c92ef73
Author: afakhry <afakhry@chromium.org>
Date: Fri Aug 12 19:22:39 2016

Fix a regression in the keyboard overlay go back/forward shortcuts

My earlier CL: https://codereview.chromium.org/2206823004 resulted in the
removal of alt+left/right shortcuts.
This CL fixes this regression.

BUG= 633825 
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2237993002
Cr-Commit-Position: refs/heads/master@{#411729}

[modify] https://crrev.com/ccff19d515c4615b5d7d420245c85b8e1c92ef73/chrome/browser/resources/chromeos/keyboard_overlay.js

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0bf06569f9627f5d28befef7d93e1984d9a44b3

commit e0bf06569f9627f5d28befef7d93e1984d9a44b3
Author: Ahmed Fakhry <afakhry@google.com>
Date: Mon Aug 15 16:14:59 2016

[Merge to M53] Remove "Go Back/Forward" from keyboard overlay

Only show these shortcuts if the finch experiment that turns them on is
enabled.

TBR=xiyuan@chromium.org,thestig@chromium.org
BUG= 633825 
TEST=manually
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2206823004
Cr-Commit-Position: refs/heads/master@{#409900}
(cherry picked from commit abbfa3e92777e0b55429cac3c880f12237732385)

Review URL: https://codereview.chromium.org/2245103002 .

Cr-Commit-Position: refs/branch-heads/2785@{#588}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e0bf06569f9627f5d28befef7d93e1984d9a44b3/chrome/browser/resources/chromeos/keyboard_overlay.js
[modify] https://crrev.com/e0bf06569f9627f5d28befef7d93e1984d9a44b3/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/e0bf06569f9627f5d28befef7d93e1984d9a44b3/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/e0bf06569f9627f5d28befef7d93e1984d9a44b3/chrome/common/chrome_features.cc
[modify] https://crrev.com/e0bf06569f9627f5d28befef7d93e1984d9a44b3/chrome/common/chrome_features.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4341d7b5ba3821f2a05d9584c26287f8cca0915

commit a4341d7b5ba3821f2a05d9584c26287f8cca0915
Author: Ahmed Fakhry <afakhry@google.com>
Date: Mon Aug 15 16:24:50 2016

[Merge to M53] Fix a regression in the keyboard overlay go back/forward shortcuts

My earlier CL: https://codereview.chromium.org/2206823004 resulted in the
removal of alt+left/right shortcuts.
This CL fixes this regression.

TBR=stevenjb@chromium.org
BUG= 633825 
TEST=manually
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2237993002
Cr-Commit-Position: refs/heads/master@{#411729}
(cherry picked from commit ccff19d515c4615b5d7d420245c85b8e1c92ef73)

Review URL: https://codereview.chromium.org/2242183002 .

Cr-Commit-Position: refs/branch-heads/2785@{#589}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/a4341d7b5ba3821f2a05d9584c26287f8cca0915/chrome/browser/resources/chromeos/keyboard_overlay.js