New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633806 link

Starred by 17 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

pp::Graphics2D: Only upper-left quadrant of an image is repainted on Chrome OS

Project Member Reported by drinkcat@chromium.org, Aug 3 2016

Issue description

CHROMEOS_RELEASE_CHROME_MILESTONE=53
CHROMEOS_RELEASE_DESCRIPTION=8530.35.0 (Official Build) dev-channel samus 

Extremely similar to  Issue 596697 , we have users reporting this on M52 as well (https://github.com/dnschneid/crouton/issues/2692).

1. Download/setup nacl_sdk
2. cd ~/nacl_sdk/pepper_49/examples/api/graphics_2d; make
(attached graphics_2d.tar, so you can skip 1/2)
3. Upload to Pixel 2/samus
4. Install app
5. Launch app
6. Resize window a few times, click in app area
7. Only top-quadrant is updated

See attached picture (it's impossible to take a proper screenshot: that refreshes the screen and the problem disappears).

Switching to "native" 2560x1700 resolution fixes the issue.
 
IMG_20160803_090146.jpg
2.5 MB View Download
graphics_2d.tar
1.8 MB Download
Is "click" in step 6 required to repro?
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 5 2016

Labels: -M-53 -M-52 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: malaykeshav@chromium.org
Status: Assigned (was: Available)
Malay, can you look into this? I can give more context so please feel free to book someone on my calendar.
Malay/Oshima: Gentle ping, any progress on this issue?
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9af1f7989315eda1c55b490146945c341374d54

commit a9af1f7989315eda1c55b490146945c341374d54
Author: malaykeshav <malaykeshav@chromium.org>
Date: Wed Aug 24 03:42:37 2016

Update viewport_to_dip_scale on bound compositor host

Fix for bug that caused the viewport_to_dip_scale not being updated
when a new compositor host was being instantiated.

BUG= 633806 
COMPONENT=Pepper, Chrome OS

Review-Url: https://codereview.chromium.org/2262323002
Cr-Commit-Position: refs/heads/master@{#413972}

[modify] https://crrev.com/a9af1f7989315eda1c55b490146945c341374d54/content/renderer/pepper/pepper_plugin_instance_impl.cc

Status: Fixed (was: Started)
Labels: Merge-Request-53
Could we backport this to M53 as well?

Comment 9 by dimu@chromium.org, Aug 28 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 cros.

@malaykeshav: Gentle ping, is it possible to backport this change to M53?
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 2 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: jdufault@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 6 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e83c67cc949d22bddc5d1aa09b9264f4a95b657

commit 4e83c67cc949d22bddc5d1aa09b9264f4a95b657
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Sep 06 22:24:05 2016

Update viewport_to_dip_scale on bound compositor host

Fix for bug that caused the viewport_to_dip_scale not being updated
when a new compositor host was being instantiated.

BUG= 633806 
COMPONENT=Pepper, Chrome OS

Review-Url: https://codereview.chromium.org/2262323002
Cr-Commit-Position: refs/heads/master@{#413972}
(cherry picked from commit a9af1f7989315eda1c55b490146945c341374d54)

Review URL: https://codereview.chromium.org/2312393003 .

Cr-Commit-Position: refs/branch-heads/2785@{#836}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4e83c67cc949d22bddc5d1aa09b9264f4a95b657/content/renderer/pepper/pepper_plugin_instance_impl.cc

Components: -Internals>Graphics Internals>GPU
Moving old issues out of Internal>Graphics to delete this obsolete component ( crbug.com/685425  for details)

Comment 17 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 18 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 19 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 21 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment