Layer border visible
Reported by
michael....@gmail.com,
Aug 3 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36 Example URL: http://angled-edges.josephfus.co/ Steps to reproduce the problem: 1. Go to http://angled-edges.josephfus.co/ What is the expected behavior? What went wrong? On the red background areas of the page you can see a distinct line where the browser layer edges meet up. This should not be there since the background area is 1 solid color. Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? Yes El Capitan and older Does this work in other browsers? Yes Chrome version: 52.0.2743.82 Channel: stable OS Version: OS X 10.12.0 Flash Version: Shockwave Flash 22.0 r0
,
Aug 3 2016
Issue remains with a new user profile. Note this only started happening after updating to macOS Sierra version 10.12 beta. Depending on your monitor's color preferences it may be difficult to spot the contrast but nonetheless it is there.
,
Aug 5 2016
,
Aug 12 2016
Thank you for providing more feedback. Adding requester "nyerramilli@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 12 2016
,
Aug 12 2016
michael.fusco3@, it does appear that the effect you are seeing aligns with GPU tile boundaries. To confirm, open DevTools > More Tools > Rendering and select "Layer Borders" which will show both layers created for stacked HTML content and boundaries of graphics tiles. Please confirm that the tile boundaries lineup with the artifacts. Could you please also open chrome://gpu and paste the contents into here? We can't reproduce, so information about your specific machine would be helpful. Meanwhile, assigning this to the compositing team due to the tile-based nature of the artifact.
,
Aug 12 2016
Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Hardware accelerated Rasterization: Software only. Hardware acceleration disabled Video Decode: Hardware accelerated Video Encode: Hardware accelerated WebGL: Hardware accelerated Driver Bug Workarounds disable_multimonitor_multisampling disable_texture_cube_map_seamless disable_webgl_rgb_multisampling_usage init_varyings_without_static_use msaa_is_slow pack_parameters_workaround_with_pack_buffer regenerate_struct_names scalarize_vec_and_mat_constructor_args set_zero_level_before_generating_mipmap unfold_short_circuit_as_ternary_operation unpack_alignment_workaround_with_unpack_buffer use_intermediary_for_copy_texture_image validate_multisample_buffer_allocation Problems Detected Multisampling is buggy on OSX when multiple monitors are connected: 237931 Applied Workarounds: disable_multimonitor_multisampling Multisampled renderbuffer allocation must be validated on some Macs: 290391 Applied Workarounds: validate_multisample_buffer_allocation Unfold short circuit on Mac OS X: 307751 Applied Workarounds: unfold_short_circuit_as_ternary_operation Mac drivers handle varyings without static use incorrectly: 322760 Applied Workarounds: init_varyings_without_static_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args Mac drivers handle struct scopes incorrectly: 403957 Applied Workarounds: regenerate_struct_names On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499 Applied Workarounds: set_zero_level_before_generating_mipmap Pack parameters work incorrectly with pack buffer bound: 563714 Applied Workarounds: pack_parameters_workaround_with_pack_buffer Alignment works incorrectly with unpack buffer bound: 563714 Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777 Applied Workarounds: use_intermediary_for_copy_texture_image Seamless cubemap does not work for Mac Intel: 597794 Applied Workarounds: disable_texture_cube_map_seamless Multisample renderbuffers with format GL_RGB8 have performance issues on Intel GPUs.: 607130 Applied Workarounds: disable_webgl_rgb_multisampling_usage Accelerated rasterization has been disabled, either via blacklist, about:flags or the command line. Disabled Features: rasterization Version Information Data exported 8/12/2016, 3:26:25 PM Chrome version Chrome/52.0.2743.116 Operating system Mac OS X 10.12.0 Software rendering list version 11.7 Driver bug list version 8.78 ANGLE commit id f07246f6a06d 2D graphics backend Skia Command Line Args Chrome.app/Contents/MacOS/Google Chrome -psn_0_151589 --flag-switches-begin --flag-switches-end Driver Information Initialization time 85 In-process GPU false Sandboxed true GPU0 VENDOR = 0x8086, DEVICE= 0x162b Optimus false AMD switchable false Driver vendor Driver version 10.18.60 Driver date Pixel shader version 1.20 Vertex shader version 1.20 Max. MSAA samples 8 Machine model name MacBookPro Machine model version 12.1 GL_VENDOR Intel Inc. GL_RENDERER Intel(R) Iris(TM) Graphics 6100 GL_VERSION 2.1 INTEL-10.18.60 GL_EXTENSIONS GL_ARB_color_buffer_float GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_draw_buffers GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_instanced_arrays GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_provoking_vertex GL_ARB_seamless_cube_map GL_ARB_shader_objects GL_ARB_shader_texture_lod GL_ARB_shading_language_100 GL_ARB_shadow GL_ARB_sync GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_float GL_ARB_texture_mirrored_repeat GL_ARB_texture_non_power_of_two GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_transpose_matrix GL_ARB_vertex_array_bgra GL_ARB_vertex_blend GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_window_pos GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_clip_volume_hint GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_draw_buffers2 GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_object GL_EXT_framebuffer_sRGB GL_EXT_geometry_shader4 GL_EXT_gpu_program_parameters GL_EXT_gpu_shader4 GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod_bias GL_EXT_texture_rectangle GL_EXT_texture_shared_exponent GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array_bgra GL_APPLE_aux_depth_stencil GL_APPLE_client_storage GL_APPLE_element_array GL_APPLE_fence GL_APPLE_float_pixels GL_APPLE_flush_buffer_range GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_packed_pixels GL_APPLE_pixel_buffer GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_specular_vector GL_APPLE_texture_range GL_APPLE_transform_hint GL_APPLE_vertex_array_object GL_APPLE_vertex_array_range GL_APPLE_vertex_point_size GL_APPLE_vertex_program_evaluators GL_APPLE_ycbcr_422 GL_ATI_separate_stencil GL_ATI_texture_env_combine3 GL_ATI_texture_float GL_ATI_texture_mirror_once GL_IBM_rasterpos_clip GL_NV_blend_square GL_NV_conditional_render GL_NV_depth_clamp GL_NV_fog_distance GL_NV_light_max_exponent GL_NV_texgen_reflection GL_NV_texture_barrier GL_SGIS_generate_mipmap GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod Disabled Extensions Window system binding vendor Window system binding version Window system binding extensions Direct rendering Yes Reset notification strategy 0x0000 GPU process crash count 0 Compositor Information Tile Update Mode Zero-copy Partial Raster Disabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 GPU_READ, SCANOUT BGRX_8888 GPU_READ, SCANOUT BGRA_8888 GPU_READ, SCANOUT, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT YUV_420 Software only YUV_420_BIPLANAR GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT UYVY_422 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
,
Aug 15 2016
I wasn't able to reproduce this on macOS Sierra, but this sounds like it might be a dupe of 632274.
,
Sep 13 2016
Looked at this a bit, pretty sure it's unrelated to crbug.com/632274 . This appears to be a difference in rendering of solid color tiles vs contentful tiles. My guess is that, due to some OS/system config, we're doing color correction on the solid color tiles but not on the contentful ones. CCameron@, is it possible that CA has started color correcting more things in Sierra?
,
Sep 16 2016
I had the same issue (macOS 10.12, custom color profile), but now I'm able to reproduce it only on Chrome from Stable channel (53.0.2785.116). It looks to be fixed in higher versions.
,
Sep 16 2016
I just checked 55.0.2861.0 and the issue remains. This is very difficult to see on some color profiles, so I suggest cycling through a few while checking for this behavior. The color will be a smidgen lighter for tiles with no content.
,
Sep 16 2016
I'm aware of that and still - recent Canary (55.0.2862.0) works fine for me, as well as beta. Screenshot below as a proof - Canary and Stable running at the same time, with "Apple RGB" profile at two different screens (retina and external Dell P2414h). MBP mid 2014 with Intel Iris Pro 1536 MB.
,
Sep 16 2016
Ok, I know why :) Canary has enabled "enable-gpu-rasterization" flag and it's fixing the problem, even in the stable version. chrome://flags/#enable-gpu-rasterization
,
Sep 21 2016
This is still important to fix, we should keep looking into this, likely with --disable-gpu-rasterization to force the issue to show up. Ccameron@ - does my theory in #12 make sense? If not, feel free to assign back or re-assign.
,
Sep 23 2016
I too have this issue with Sierra and Version 53.0.2785.116 (64-bit). I was not able to reproduce this using the original link provided (http://angled-edges.josephfus.co/), however I am with this simple JSBin: http://output.jsbin.com/sayawuboxa .
,
Sep 28 2016
,
Sep 28 2016
To #12, this sounds possible. The API that we use for color specification on IOSurfaces isn't documented, maybe they're changing it out from under us. To confirm, this is Sierra-only?
,
Sep 28 2016
Correct only Sierra
,
Sep 28 2016
I still can't get this to reproduce on 53.0.2785.116, Sierra 10.12 Beta (16A239j). I'll try updating to the GM to see if that makes the issue show up.
,
Sep 28 2016
I upgraded from Sierra beta to Sierra GM, and this is really broken badly.
Repro steps:
* Set color profile to "Generic RGB profile"
* Go to the URL: data:text/html,<html><head><style>body{background: #1560bd;}</style></head><body>Test</body></html>
I suspect that the issue is in how solid color CALayer backgrounds are interpreted. We currently specify them as sRGB colors ... we probably need to make them match the output device color profile ... but getting that data is a bit hard.
,
Sep 29 2016
Actually, the issue has to do with how IOSurfaces' color spaces are interpreted. And there are bugs here. We use 2 types of colors on CALayers. IOSurface layer contents, and background CGColors. Before 10.12: If you use a locally hosted CALayer, then [A] IOSurfaces are treated as though they are in SRGB color space, and corrected to device color space [B] CGColors are treated as though they are in whatever space you specify (SRGB), and corrected to device color space If you use a cross-process CALayer, then [C] IOSurfaces are not color corrected (unless they have a color space assigned, which we don't do, yet) [D] CGColors are never corrected This works for us -- we use remote layers, neither of our inputs are color corrected, life is good. In 10.12, they fixed [C], so that it behaves like [A] now. But I'm not sure, because they seem to have broken the remote CALayer API that we use (it works for Chrome, but it doesn't work for stand-alone apps that used to work). I've attached a test program that I wrote, and it runs on 10.11, but not 10.12. Btw, the "remote layers are odd on 10.9+" comments can be found at https://bugs.chromium.org/p/chromium/issues/detail?id=312462#c40 Now, what can we do to fix this? In the short term, for solid color layers, we can set their contents to be solid-color IOSurfaces. In the long term, we need to go and fix the remote layer API again, which is a pain. I think we should re-examine hosting our CALayer trees in the browser process to avoid this nightmare.
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318395caaf3a43683a41d09e65050649d5fedf27 commit 318395caaf3a43683a41d09e65050649d5fedf27 Author: ccameron <ccameron@chromium.org> Date: Thu Sep 29 19:29:48 2016 Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG= 633805 Review-Url: https://codereview.chromium.org/2378423002 Cr-Commit-Position: refs/heads/master@{#421899} [modify] https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27/ui/accelerated_widget_mac/ca_renderer_layer_tree.h [modify] https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Sep 30 2016
Requesting merge for M54
,
Sep 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
Could you please confirm whether this change is verified in Canary and safe to merge?If ye, please merge to M54 ASAP.
,
Sep 30 2016
This fix broke Canary -- follow-up fix at https://codereview.chromium.org/2387653004/.
,
Sep 30 2016
ccameron@ - this change currently has merge approval even though it's in no shape to be merged back. Please make doubly sure your fixed patch works as intended before landing the cherry pick. Also, please attach screenshots of the problem so that I can gauge the magnitude. I'm wondering if this is the kind of change that can be delayed until it's had sufficient airtime on Canary to suss out any unexpected issues.
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/496c26b5cc3983f40b65729d8fa8bbd4a9951c71 commit 496c26b5cc3983f40b65729d8fa8bbd4a9951c71 Author: ccameron <ccameron@chromium.org> Date: Sat Oct 01 02:09:55 2016 Mac: Fix bugs in Sierra color fix The previous fix uncondiontally replaced populated the solid color IOSurface and updated the contents_rect for all layers on Sierra, instead of just doing it for the ones without IOSurfaces. Fix this bug, parameterize whether or not we are using this workaround, and add tests for both code paths. BUG= 633805 Review-Url: https://codereview.chromium.org/2387653004 Cr-Commit-Position: refs/heads/master@{#422281} [modify] https://crrev.com/496c26b5cc3983f40b65729d8fa8bbd4a9951c71/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm [modify] https://crrev.com/496c26b5cc3983f40b65729d8fa8bbd4a9951c71/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm [modify] https://crrev.com/496c26b5cc3983f40b65729d8fa8bbd4a9951c71/ui/accelerated_widget_mac/ca_renderer_layer_tree.h [modify] https://crrev.com/496c26b5cc3983f40b65729d8fa8bbd4a9951c71/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Oct 3 2016
Thanks Chris for the fix. Please confirm whether this change is verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) before 4.00 PM Tuesday(10/04) so that we could take for next Beta Release.
,
Oct 3 2016
Verified on Canary. Merging the two patches together.
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a01116d528eb834b2580328817db8105ef0f59e8 commit a01116d528eb834b2580328817db8105ef0f59e8 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Oct 03 22:20:29 2016 Mac: Fix bugs in Sierra color fix The previous fix uncondiontally replaced populated the solid color IOSurface and updated the contents_rect for all layers on Sierra, instead of just doing it for the ones without IOSurfaces. Fix this bug, parameterize whether or not we are using this workaround, and add tests for both code paths. BUG= 633805 Review-Url: https://codereview.chromium.org/2387653004 Cr-Commit-Position: refs/heads/master@{#422281} (cherry picked from commit 496c26b5cc3983f40b65729d8fa8bbd4a9951c71) Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG= 633805 Review-Url: https://codereview.chromium.org/2378423002 Cr-Commit-Position: refs/heads/master@{#421899} (cherry picked from commit 318395caaf3a43683a41d09e65050649d5fedf27) Review URL: https://codereview.chromium.org/2391793002 . Cr-Commit-Position: refs/branch-heads/2840@{#630} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_renderer_layer_tree.h [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Oct 3 2016
Fixed. I'm going to take a second look at our Sierra color strategy in a separate bug.
,
Oct 4 2016
There is still a similar problem here. On this website, http://yjlintw.people.si.umich.edu/responsive%20site/ The very bottom in certain window size will create the color mismatch. Enable GPU Rasterization did fix the issue. OSX 10.12 Version 55.0.2880.0 canary
,
Oct 4 2016
Issue 652664 has been merged into this issue.
,
Oct 4 2016
This issue is still being reported. See the dupe bug linked above. Does something need to be merged back? Is there a new bug that these reports should be duped into?
,
Oct 4 2016
55.0.2880.0 is r422654, the color fix went in at r421899. I'll double-check that on my Sierra machine when I get a chance. Issue 652664 is missing the fix's merge.
,
Oct 4 2016
That is, the version in issue 652664 is not expected to have the fix in it.
,
Oct 5 2016
Tested this issue on Mac OS 10.12 sierra using chrome latest Beta M54-54.0.2840.50 by following steps mentioned in the original comment. Observed no rendering issues in the page as seen in the screen-shot #0. Observing same behavior on reported version of chrome #52.0.2743.82 as well. Is there any constant repro steps or sample test case to verify this issue from Chrome-TE end.
,
Oct 5 2016
As per #36 and #42 tagging as verified.
,
Oct 6 2016
Issue 649928 has been merged into this issue.
,
Oct 9 2016
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/139c0a4a023d168763f0983bebe2790b38419bb2 commit 139c0a4a023d168763f0983bebe2790b38419bb2 Author: ccameron <ccameron@chromium.org> Date: Mon Oct 10 18:27:11 2016 Mac color: Apply Sierra workaround unconditionally This was accidentally enabled on just <10.12. It didn't cause any issues, so expand to 10.12. BUG= 633805 Review-Url: https://codereview.chromium.org/2405883002 Cr-Commit-Position: refs/heads/master@{#424190} [modify] https://crrev.com/139c0a4a023d168763f0983bebe2790b38419bb2/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
,
Oct 10 2016
Issue 653643 has been merged into this issue.
,
Oct 12 2016
Same issue here on MacBook Pro and MacOS Sierra. This issue also occur in every "chronium" based apps like electron (Atom, VisualStudio Code ecc)
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8f20e7bcfaf62b0153dca0184dd7e9911e8701 commit eb8f20e7bcfaf62b0153dca0184dd7e9911e8701 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Oct 12 14:44:15 2016 Mac color: Apply Sierra workaround unconditionally This was accidentally enabled on just <10.12. It didn't cause any issues, so expand to 10.12. BUG= 633805 Review-Url: https://codereview.chromium.org/2405883002 Cr-Commit-Position: refs/heads/master@{#424190} (cherry picked from commit 139c0a4a023d168763f0983bebe2790b38419bb2) Review URL: https://codereview.chromium.org/2405363003 . Cr-Commit-Position: refs/branch-heads/2840@{#731} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/eb8f20e7bcfaf62b0153dca0184dd7e9911e8701/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84dc448d2ece95a24312370c7b0017050593276f commit 84dc448d2ece95a24312370c7b0017050593276f Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Oct 12 14:51:38 2016 Mac color: Apply Sierra workaround unconditionally This was accidentally enabled on just <10.12. It didn't cause any issues, so expand to 10.12. BUG= 633805 Review-Url: https://codereview.chromium.org/2405883002 Cr-Commit-Position: refs/heads/master@{#424190} (cherry picked from commit 139c0a4a023d168763f0983bebe2790b38419bb2) Review URL: https://codereview.chromium.org/2412123002 . Cr-Commit-Position: refs/branch-heads/2883@{#60} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/84dc448d2ece95a24312370c7b0017050593276f/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
,
Oct 12 2016
Sorry about the churn -- this is now fixed for real. It will not make the first M54 stable, because that has already been caught. Thanks to #37 and the comments after for alerting me that the fix wasn't taking effect.
,
Oct 12 2016
In #52 s/caught/cut
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84dc448d2ece95a24312370c7b0017050593276f commit 84dc448d2ece95a24312370c7b0017050593276f Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Oct 12 14:51:38 2016 Mac color: Apply Sierra workaround unconditionally This was accidentally enabled on just <10.12. It didn't cause any issues, so expand to 10.12. BUG= 633805 Review-Url: https://codereview.chromium.org/2405883002 Cr-Commit-Position: refs/heads/master@{#424190} (cherry picked from commit 139c0a4a023d168763f0983bebe2790b38419bb2) Review URL: https://codereview.chromium.org/2412123002 . Cr-Commit-Position: refs/branch-heads/2883@{#60} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/84dc448d2ece95a24312370c7b0017050593276f/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a01116d528eb834b2580328817db8105ef0f59e8 commit a01116d528eb834b2580328817db8105ef0f59e8 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Oct 03 22:20:29 2016 Mac: Fix bugs in Sierra color fix The previous fix uncondiontally replaced populated the solid color IOSurface and updated the contents_rect for all layers on Sierra, instead of just doing it for the ones without IOSurfaces. Fix this bug, parameterize whether or not we are using this workaround, and add tests for both code paths. BUG= 633805 Review-Url: https://codereview.chromium.org/2387653004 Cr-Commit-Position: refs/heads/master@{#422281} (cherry picked from commit 496c26b5cc3983f40b65729d8fa8bbd4a9951c71) Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG= 633805 Review-Url: https://codereview.chromium.org/2378423002 Cr-Commit-Position: refs/heads/master@{#421899} (cherry picked from commit 318395caaf3a43683a41d09e65050649d5fedf27) Review URL: https://codereview.chromium.org/2391793002 . Cr-Commit-Position: refs/branch-heads/2840@{#630} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_renderer_layer_tree.h [modify] https://crrev.com/a01116d528eb834b2580328817db8105ef0f59e8/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8f20e7bcfaf62b0153dca0184dd7e9911e8701 commit eb8f20e7bcfaf62b0153dca0184dd7e9911e8701 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Oct 12 14:44:15 2016 Mac color: Apply Sierra workaround unconditionally This was accidentally enabled on just <10.12. It didn't cause any issues, so expand to 10.12. BUG= 633805 Review-Url: https://codereview.chromium.org/2405883002 Cr-Commit-Position: refs/heads/master@{#424190} (cherry picked from commit 139c0a4a023d168763f0983bebe2790b38419bb2) Review URL: https://codereview.chromium.org/2405363003 . Cr-Commit-Position: refs/branch-heads/2840@{#731} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/eb8f20e7bcfaf62b0153dca0184dd7e9911e8701/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Aug 3 2016Labels: Needs-Feedback
404 KB
404 KB View Download