Move ScreenCapturer Differ logic out of each implementation |
|||
Issue descriptionThis is a work item to track all the changes to move ScreenCapturer Differ logic out of each implementation. As most of the ScreenCapturer implementations need to compare the changes of two frames and set the DesktopFrame::updated_region(). It would be better to have an individual layer to handle the Differ logic.
,
Sep 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ba38ac9d3ae2b0d1d4d5230cd1280d417694390 commit 3ba38ac9d3ae2b0d1d4d5230cd1280d417694390 Author: zijiehe <zijiehe@chromium.org> Date: Sun Sep 25 20:12:26 2016 [Chromoting] Use detect_updated_region option in remoting ScreenCapturer / DesktopCapturer do not always need to detect more accurate updated region, since some consumers do not really care about the updated region. And according to the analysis, a Differ call may use some 10 ms for a 2560 x 1440 DesktopFrame. So Differ logic will eventually be moved out of ScreenCapturer / DesktopCapturer implementations. But a more accurate updated region is useful for Chromoting, since we do not need to send an unchanged frame to the client. So this change actively sets detect_updated_region in DesktopCapturerOptions to ensure ScreenCapturerDifferWrapper is used. This change will be submitted together with WebRTC change https://codereview.chromium.org/2348803003/ to avoid the differ to be involved twice. BUG= 633802 Review-Url: https://codereview.chromium.org/2348943002 Cr-Commit-Position: refs/heads/master@{#420863} [modify] https://crrev.com/3ba38ac9d3ae2b0d1d4d5230cd1280d417694390/remoting/host/basic_desktop_environment.cc
,
Sep 26 2016
After WebRTC changes https://codereview.chromium.org/2314323002/ & https://codereview.chromium.org/2348803003/ and the Chromium one above, the required changes are all submitted. Resolved as fixed. AJ, just FYI. This change should have no logic impact to chromoting.
,
Sep 30 2016
I ran through P0 tests on ToT, as part of my weekly tests. I found no regressions, so this should be good. Verified in 55.0.2873.0 web app and host. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jamiewa...@chromium.org
, Aug 9 2016