Quick View: Images with transparent background looks weird. |
||||
Issue descriptionWe should add default background (grid checker).
,
Aug 4 2016
Created a CL. Sample images attached.
,
Aug 4 2016
Hi Tien. Is this change looks good to you? I copied CSS used in Google Images. http://goo.gl/0lPSZG
,
Aug 9 2016
LGTM, Oka-san. Thank you!
,
Aug 10 2016
Thank you! Submitting.
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57368c7c6f03ed810ebd32960b49eafcf5de7621 commit 57368c7c6f03ed810ebd32960b49eafcf5de7621 Author: oka <oka@chromium.org> Date: Wed Aug 10 01:43:18 2016 Use checkerboard pattern as the background of Quick View images. I copied CSS used in Google Images. http://goo.gl/0lPSZG BUG= 633800 TEST=manually. See https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2 Review-Url: https://codereview.chromium.org/2214633002 Cr-Commit-Position: refs/heads/master@{#410914} [modify] https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css
,
Aug 11 2016
,
Aug 25 2016
Chrome OS 54.0.2837.0/8738.0.90 |
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, Aug 3 2016