New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633800 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 614228



Sign in to add a comment

Quick View: Images with transparent background looks weird.

Project Member Reported by oka@chromium.org, Aug 3 2016

Issue description

We should add default background (grid checker).

 
Blocking: 614228

Comment 2 by oka@chromium.org, Aug 4 2016

Created a CL. Sample images attached.

black.png
17.6 KB View Download
white.png
12.5 KB View Download

Comment 3 by oka@chromium.org, Aug 4 2016

Cc: tienchang@chromium.org
Hi Tien. Is this change looks good to you? I copied CSS used in Google Images. http://goo.gl/0lPSZG
LGTM, Oka-san. Thank you!

Comment 5 by oka@chromium.org, Aug 10 2016

Thank you! Submitting.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57368c7c6f03ed810ebd32960b49eafcf5de7621

commit 57368c7c6f03ed810ebd32960b49eafcf5de7621
Author: oka <oka@chromium.org>
Date: Wed Aug 10 01:43:18 2016

Use checkerboard pattern as the background of Quick View images.

I copied CSS used in Google Images. http://goo.gl/0lPSZG

BUG= 633800 
TEST=manually. See https://bugs.chromium.org/p/chromium/issues/detail?id=633800#c2

Review-Url: https://codereview.chromium.org/2214633002
Cr-Commit-Position: refs/heads/master@{#410914}

[modify] https://crrev.com/57368c7c6f03ed810ebd32960b49eafcf5de7621/ui/file_manager/file_manager/foreground/elements/files_safe_img_webview_content.css

Comment 7 by oka@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 54.0.2837.0/8738.0.90

Sign in to add a comment