"Copy to clipboard" notification action icon is too dark and too large |
|||||||||||
Issue descriptionThe icon used for the "Copy to clipboard" action on download notifications looks like it's bigger than it should be: IDR_DOWNLOAD_NOTIFICATION_MENU_COPY_TO_CLIPBOARD: chrome/app/theme/default_100_percent/cros/downloads/copy_to_clipboard.png 24x24 chrome/app/theme/default_200_percent/cros/downloads/copy_to_clipboard.png 48x48 kNotificationButtonIconSize in ui/message_center/message_center_style.h is 16, so I think these should be 16x16 and 32x32 instead -- that's what other button icons seem to be. They also look like they're the wrong color: they're #757575, while other action icons appear to be #969696. I'm attaching the incorrect images. I've since copied these to the following paths, so I should update those too: chrome/app/theme/default_100_percent/cros/notification_screenshot_copy_to_clipboard.png chrome/app/theme/default_200_percent/cros/notification_screenshot_copy_to_clipboard.png
,
Aug 3 2016
On issue 633600, you wrote "I checked with Sebastien and he mentioned that the icons should be at 16 at 1x and in svg format." Just to clarify, I don't think that any of these are shipped as SVG. We convert to transparent PNGs before checking them in to the tree. Agree that it sounds reasonable to keep these as SVGs on the UX side, though. :-)
,
Aug 3 2016
Yes I see what you are saying. Please let me know if it's possible to get the list of all the other notification action icons that we should update.
,
Aug 3 2016
List is in comment #1. I don't see any other problematic action icons but there are a bunch of main notification icons that are too small.
,
Aug 3 2016
Are you talking about these icons? Would you mind to show me a screenshot of how small they are looking now? https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OYkpDNHUwako4VHc https://bugs.chromium.org/p/chromium/issues/detail?id=619085 Thanks, Elizabeth
,
Aug 3 2016
Here are the 100% images that seem like they should be 80x80. I don't think they'll occur at their original sizes in the UI. Instead, they'll be scaled up and blurry.
,
Aug 3 2016
System notification is moving to vector icons (crbug.com/619085), and we should avoid png unless there is a good reason. Please contact oshima@ or tdanderson@ as they know more about this. Also the icons you have attached some assets are already updated in 80x80 svg format, but the rest of them I didn't get the bug/request. That's why they are not created in the right size and format. notification_peripheral_battery_low: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2ORzc5N1Y5X0NVMzg/view notification_screenshot: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OUU9aTGtQOThFU1E/view this is for chrome web store, do we need a new one for play store?: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OUHgxdUxlbVpaU2M/view printer_notification: https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OZGFaQ1RoVWc2Y1E (These are created much earlier so they are still in png) I will update these files to SVG format soon.
,
Aug 3 2016
I'll let Oshima or Terry comment here, as I haven't noticed any vector assets in the tree or announcements about this on chromium-dev.
,
Aug 4 2016
Re #8, we started switching all icons over to vector format during the top chrome material design work. You can see them in ui/gfx/vector_icons (note the files themselves are derived from SVGs but are not actually in .svg format). More details are at https://sites.google.com/a/chromium.org/dev/developers/how-tos/vectorized-icons-in-native-chrome-ui PNGs will still need to be used for complex multi-colored product icons such as the ones for Drive or Play Store.
,
Aug 4 2016
Thanks for the details! I left a comment on issue 606819 -- I'm happy to help out with updating some of these if we have vector versions. I assume we should use the spreadsheet for tracking.
,
Aug 5 2016
Elizabeth sent me updated icons; attaching here. Thanks!
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a10475cca111130fbecb654ec34df670725c051 commit 7a10475cca111130fbecb654ec34df670725c051 Author: derat <derat@chromium.org> Date: Fri Aug 05 23:41:43 2016 chromeos: Fix download/screenshot "Copy to clipboard" icons. Update the icons used in download and screenshot notifications' "Copy to clipboard" buttons to be the same size (16x16) and color (#969696) as other notification button icons. BUG= 633799 Review-Url: https://codereview.chromium.org/2217333002 Cr-Commit-Position: refs/heads/master@{#410213} [modify] https://crrev.com/7a10475cca111130fbecb654ec34df670725c051/chrome/app/theme/default_100_percent/cros/downloads/copy_to_clipboard.png [modify] https://crrev.com/7a10475cca111130fbecb654ec34df670725c051/chrome/app/theme/default_100_percent/cros/notification_screenshot_copy_to_clipboard.png [modify] https://crrev.com/7a10475cca111130fbecb654ec34df670725c051/chrome/app/theme/default_200_percent/cros/downloads/copy_to_clipboard.png [modify] https://crrev.com/7a10475cca111130fbecb654ec34df670725c051/chrome/app/theme/default_200_percent/cros/notification_screenshot_copy_to_clipboard.png
,
Aug 6 2016
The clipboard icons are fixed now, so I'm closing this. I'll use issue 606819 to track fixing the other issues from comment #1.
,
Aug 8 2016
,
Aug 29 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 6 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by derat@chromium.org
, Aug 3 2016