New issue
Advanced search Search tips

Issue 633734 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 633730



Sign in to add a comment

Remove set_config and self.c

Project Member Reported by martiniss@chromium.org, Aug 2 2016

Issue description

Configs are currently mostly used through self.m.module.set_config(), and self.c. This is confusing, and is a global variable which is not at all obvious to developers not familiar with the modules they're interacting with, and should be removed. Instead, all configs should simply be passed as arguments into modules. 

This cleanup work would probably also include moving some function parameters into the config itself.
 
Components: Infra>Platform>Config
Labels: TE-NeedsTriageHelp

Comment 2 by no...@chromium.org, Mar 29 2017

Components: -Infra>Platform>Config Infra>Platform>Recipes
Labels: -TE-NeedsTriageHelp
Yep, configs still need cleanup.
Cc: martiniss@chromium.org luqui@chromium.org aga...@chromium.org
 Issue 285300  has been merged into this issue.
Project Member

Comment 5 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mar...@chromium.org, May 21 2018

Cc: -luqui@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment