New issue
Advanced search Search tips

Issue 633717 link

Starred by 2 users
Status: Fixed
Owner:
qin...@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Clicking download successful notification doesn't go to downloads app

Project Member Reported by qin...@chromium.org, Aug 2 2016 
Steps to reproduce:
(1) go to http://ftp.gnu.org/gnu/gzip/
(2) long press any link, and download the tar or tar.gz file 
(3) After download completes, click the download notification

Expected result:
Open downloads app, just like clicking the snackbar notification


Actual result:
Nothing happens

Clicking the snackbar "OPEN" button will bring the user to Downloads app. However, clicking the notification has no effect.

Comment 1 by mattm@chromium.org, Aug 2 2016

Components: UI>Browser>Downloads
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d58f91f1a8237e6a8fa53837785edc2e178e9154

commit d58f91f1a8237e6a8fa53837785edc2e178e9154
Author: qinmin <qinmin@chromium.org>
Date: Wed Aug 03 21:48:04 2016

Open downloads app when clicking on the downlaod notification of an unresolved type

If a download cannot be resolved to any app, nothing happens when
clicking the notification.
This doesn't match the behavior of the snackbar "open" button
This CL changes the behavior to open the downloads app

BUG= 633717 

Review-Url: https://codereview.chromium.org/2202423003
Cr-Commit-Position: refs/heads/master@{#409632}

[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Comment 3 by qin...@chromium.org, Aug 3 2016

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment