New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633715 link

Starred by 2 users
Status: Fixed
Owner:
█ cco3@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add grouping to Physical Web Results

Project Member Reported by cco3@chromium.org, Aug 2 2016 
A group id is an identifier that associates URLs into buckets.  (i.e.,
URLs from the same domain with the same title might have the same group
id).

The PWS should send down a group id and the chrome should display grouped URLs as a single entry in a list instead of multiple entries.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df58d62bc0bff46e73ffde6cd3479efd5009ad5e

commit df58d62bc0bff46e73ffde6cd3479efd5009ad5e
Author: cco3 <cco3@chromium.org>
Date: Wed Aug 03 22:21:45 2016

Add a group id to PwsResult

A group id is an identifier that associates URLs into buckets.  (i.e.,
URLs from the same domain with the same title might have the same group
id).  In anticipation of the PWS sending Chrome a group id, this change
adds a placeholder to our PwsResult data structure.

BUG= 633715 

Review-Url: https://codereview.chromium.org/2201183002
Cr-Commit-Position: refs/heads/master@{#409639}

[modify] https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java
[modify] https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java
[modify] https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/df58d62bc0bff46e73ffde6cd3479efd5009ad5e/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218aec3aa9e6174071660db1f593d87dd7151a27

commit 218aec3aa9e6174071660db1f593d87dd7151a27
Author: cco3 <cco3@chromium.org>
Date: Thu Aug 04 22:15:31 2016

Add serialization capabilities to PwsResult

This will let us store PwsResults along with UrlInfos in the
UrlManager, giving us more opportunities to compare the two
together and shift the burden away form the ListUrlsActivity.

BUG= 633715 

Review-Url: https://codereview.chromium.org/2209333004
Cr-Commit-Position: refs/heads/master@{#409911}

[modify] https://crrev.com/218aec3aa9e6174071660db1f593d87dd7151a27/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java
[modify] https://crrev.com/218aec3aa9e6174071660db1f593d87dd7151a27/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java
[add] https://crrev.com/218aec3aa9e6174071660db1f593d87dd7151a27/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3

commit 5ba64b349e320be7a35c42dcdfbdeaea9ae412b3
Author: cco3 <cco3@chromium.org>
Date: Fri Aug 12 19:04:59 2016

Combine Physical Web URLs into groups

A group id is an identifier that associates URLs into buckets.  (i.e.,
URLs from the same domain with the same title might have the same group
id).

This change displays groups as a single entry in our display list, and
then chooses the closest URL when a user taps the entry.

BUG= 633715 

Review-Url: https://codereview.chromium.org/2224223002
Cr-Commit-Position: refs/heads/master@{#411724}

[modify] https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyUrlsAdapter.java
[modify] https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java

Comment 6 by cco3@chromium.org, Sep 7 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment