New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633709 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 633710



Sign in to add a comment

[Sync] //components/sync_driver should move inside //components/sync

Project Member Reported by maxbogue@chromium.org, Aug 2 2016

Issue description

Now that sync is its own component, sync_driver should move to be a sub-folder so all our code lives in one location.
 
Blockedon: 633710
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35515f47c042be06961058acf4f9eab9a92bab16

commit 35515f47c042be06961058acf4f9eab9a92bab16
Author: maxbogue <maxbogue@chromium.org>
Date: Sat Aug 13 01:55:25 2016

[Sync] Convert sync to a static library.

In preparation for merging in sync_driver, sync is becoming a static
library. The driver code has several static_library dependencies that it
would probably be bad to duplicate and at least one class
(DeviceCountMetricsProvider) which would otherwise need to export a base
class from an unrelated component.

BUG= 633709 

Review-Url: https://codereview.chromium.org/2240613002
Cr-Commit-Position: refs/heads/master@{#411851}

[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/BUILD.gn
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/android/sync_jni_registrar.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/attachments/attachment.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/attachments/attachment_id.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/attachments/attachment_metadata.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/attachments/attachment_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/attachments/attachment_store_backend.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/conflict_resolution.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/data_batch.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/entity_change.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/entity_data.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/metadata_batch.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/metadata_change_list.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/model_type_change_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/model_type_service.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/model_type_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_change.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_change_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_data.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_error.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_error_factory.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/sync_merge_result.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/api/syncable_service.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/attachment_id_proto.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/cancelation_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/cancelation_signal.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/cryptographer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/extensions_activity.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/get_session_name.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/invalidation_interface.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/model_type.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/nigori.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/node_ordinal.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/progress_marker_map.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/sync_db_util.h
[delete] https://crrev.com/093fc168e7673193faecdd70b743cd62686cd9e4/components/sync/base/sync_export.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/sync_string_conversions.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/syncer_error.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/time.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/unique_position.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/base/weak_handle.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/activation_context.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_downloader.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_downloader_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_service.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_service_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_service_proxy.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_service_proxy_for_test.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_store_frontend.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_uploader.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_uploader_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/attachment_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/fake_attachment_downloader.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/fake_attachment_uploader.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/in_memory_attachment_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/attachments/on_disk_attachment_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/base_node.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/base_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/change_record.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/data_batch_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/data_type_association_stats.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/data_type_debug_info_listener.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/delete_journal.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/http_bridge.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/http_bridge_network_resources.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/http_post_provider_factory.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/http_post_provider_interface.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/internal_components_factory.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/internal_components_factory_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/model_type_connector.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/model_type_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/model_type_store_backend.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/network_resources.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/non_blocking_sync_common.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/processor_entity_tracker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/read_node.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/read_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/shared_model_type_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/shutdown_reason.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/simple_metadata_change_list.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/sync_encryption_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/sync_manager.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/sync_manager_factory.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/user_share.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/write_node.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core/write_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/attachments/proto/BUILD.gn
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/debug_info_event_listener.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/js_mutation_event_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/js_sync_encryption_handler_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/js_sync_manager_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/model_type_connector_proxy.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/protocol_event_buffer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/sync_encryption_handler_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/sync_manager_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/syncapi_internal.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/core_impl/syncapi_server_connection_manager.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/clear_server_data_request_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/clear_server_data_response_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/commit_request_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/commit_response_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/configure_get_updates_request_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/get_updates_response_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/normal_get_updates_request_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/poll_get_updates_request_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/events/protocol_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/model_safe_worker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/passive_model_worker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/polling_constants.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine/sync_status.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/apply_control_data_updates.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/backoff_delay_provider.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/clear_server_data.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit_contribution.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit_contributor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit_queue.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/commit_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/directory_commit_contribution.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/directory_update_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/get_commit_ids.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/get_updates_delegate.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/get_updates_processor.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/net/server_connection_manager.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/nudge_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/sync_cycle_event.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/sync_engine_event_listener.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/sync_scheduler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/sync_scheduler_impl.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/syncer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/syncer_proto_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/syncer_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/update_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/engine_impl/worker_entity_tracker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/js/js_backend.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/js/js_controller.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/js/js_event_details.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/js/js_event_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/js/sync_js_controller.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/protocol/BUILD.gn
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/protocol/proto_enum_conversions.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/protocol/proto_value_conversions.h
[delete] https://crrev.com/093fc168e7673193faecdd70b743cd62686cd9e4/components/sync/protocol/sync_proto_export.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/protocol/sync_protocol_error.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/commit_counters.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/model_neutral_state.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/status_counters.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/sync_session_snapshot.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/type_debug_info_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions/update_counters.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/debug_info_getter.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/directory_type_debug_info_emitter.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/model_type_registry.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/nudge_tracker.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/status_controller.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/sync_session.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/sessions_impl/sync_session_context.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/directory.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/directory_backing_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/directory_backing_store_unittest.cc
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/directory_change_delegate.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/entry.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/entry_kernel.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/in_memory_directory_backing_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/invalid_directory_backing_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/model_neutral_mutable_entry.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/mutable_entry.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/nigori_handler.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/nigori_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/on_disk_directory_backing_store.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/parent_child_index.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/scoped_parent_child_index_updater.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_base_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_base_write_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_delete_journal.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_enum_conversions.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_id.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_model_neutral_write_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_proto_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_read_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_util.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/syncable_write_transaction.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/syncable/transaction_observer.h
[modify] https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16/components/sync/test/sessions/mock_debug_info_getter.h

Status: Fixed (was: Started)
Landed https://codereview.chromium.org/2203673002, just put the wrong bug # on it...
Labels: Sync-Code-Health
Labels: -Sync-Code-Health Hotlist-CodeHealth

Sign in to add a comment