New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633707 link

Starred by 3 users
Status: Fixed
Owner:
pdr@chromium.org
Closed: Aug 2016
Cc:
wangxianzhu@chromium.org
foolip@chromium.org
chrishtr@chromium.org
█ wkorman@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 601275



Sign in to add a comment

[spv2] Animation compositing tests leave the testrunner in a bad state, causing flakes

Project Member Reported by pdr@chromium.org, Aug 2 2016 
The canvas test passes here:
rtd third_party/WebKit/LayoutTests/fast/canvas/canvas-render-layer.html --additional-driver-flag=--enable-slimming-paint-v2 --child-processes=1

The canvas test fails here:
rtd third_party/WebKit/LayoutTests/compositing/animation/state-at-end-event-transform-layer.html third_party/WebKit/LayoutTests/fast/canvas/canvas-render-layer.html --additional-driver-flag=--enable-slimming-paint-v2 --child-processes=1

rtd = run webkit tests in debug.

Comment 1 by pdr@chromium.org, Aug 3 2016

Cc: wangxianzhu@chromium.org
Status: Started (was: Assigned)
This is due to our compositing test detection in blink_test_controller which overrides preferences but does not clean them up. This also results in the wrong scrollbar theme which may explain  https://crbug.com/627798  too.

Comment 2 by schenney@chromium.org, Aug 4 2016 

Good to know this is the scrollbar theme issue. It's causing flakes all over the place. Anything I can do to help?

Comment 3 by pdr@chromium.org, Aug 8 2016 

 Issue 634685  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c

commit 002f2e5577c4538c7ef29f8ee7648c14f9bdce4c
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Aug 09 00:26:15 2016

Auto-rebaseline for r410485

https://chromium.googlesource.com/chromium/src/+/a5191dca2

BUG= 627798 , 633707 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2225883003 .

Cr-Commit-Position: refs/heads/master@{#410515}

[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/fast/repaint/resize-scrollable-iframe-expected.txt
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/linux-precise/compositing/overflow/scroll-ancestor-update-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/compositing/layers-inside-overflow-scroll-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/compositing/self-painting-layers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-scrollable-iframe-expected.txt
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/text-match-document-change-expected.txt
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/geometry/video-fixed-scrolling-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/layers-inside-overflow-scroll-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/scroll-ancestor-update-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/self-painting-layers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/text-match-document-change-expected.txt
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-fixed-scrolling-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/compositing/layers-inside-overflow-scroll-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/scroll-ancestor-update-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/compositing/self-painting-layers-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-long-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-many-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-rtl-default-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-rtl-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-zoom090-expected.png
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/002f2e5577c4538c7ef29f8ee7648c14f9bdce4c/third_party/WebKit/LayoutTests/platform/win/fast/repaint/text-match-document-change-expected.txt
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select-popup/popup-menu-appearance-long-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select-popup/popup-menu-appearance-many-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select-popup/popup-menu-appearance-rtl-default-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select-popup/popup-menu-appearance-rtl-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/forms/select-popup/popup-menu-appearance-zoom090-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/line-flow-with-floats-9-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/nested-fixed-iframe-scrolled-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/repaint-during-scroll-with-zoom-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/resize-scrollable-iframe-expected.png
[delete] https://crrev.com/7b023b1936593c7360fe7a3b6a0d2c6002a174cc/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/text-match-document-change-expected.png

Comment 5 by schenney@chromium.org, Aug 9 2016

Cc: chrishtr@chromium.org wkorman@chromium.org
 Issue 635892  has been merged into this issue.

Comment 6 by foolip@chromium.org, Aug 9 2016

Cc: foolip@chromium.org
Has this a new problem? I saw multiple issues that might be explained by this when sheriffing today, and if there's something that can be reverted that would be very good.

Comment 7 by wangxianzhu@chromium.org, Aug 9 2016 

foolip@ do you still see new failures after r410485?

Comment 8 by pdr@chromium.org, Aug 9 2016 

It's possible this patch exposed more incorrect baselines that I didn't catch in the original patch. Do you see flaky failures after r410485 or are they consistent? If they are consistent, please rebaseline them.

Comment 9 by pdr@chromium.org, Aug 10 2016

Status: Fixed (was: Started)
I think this is now fixed.

Comment 10 by foolip@chromium.org, Aug 10 2016 

Thanks all, I haven't seen anything yet but if I see anything with scrollbars flaking today I'll circle back here.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685fcb775764ff8211bb8f8285de8903c172b4f4

commit 685fcb775764ff8211bb8f8285de8903c172b4f4
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 10 10:14:51 2016

Mark popup-menu-appearance-zoom.html as failing on Linux Trusty

According to flakiness dashboard, the test began failing sometime after
r410470. The failure has scrollbars rendered wrong. Needs rebaseline?

BUG= 636304 , 633707 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2232823002 .

Cr-Commit-Position: refs/heads/master@{#411018}

[modify] https://crrev.com/685fcb775764ff8211bb8f8285de8903c172b4f4/third_party/WebKit/LayoutTests/TestExpectations
►

Sign in to add a comment