quipper should handle Chrome huge pages mappings |
||||||||||||
Issue descriptionA hugepages-mapped Chrome binary gets mapped as three mappings: PERF_RECORD_MMAP2 24492/24492: [0x7f7377324000(0xdc000) @ 0 fe:00 90623 3474019349355834936]: r-xp /opt/google/chrome/chrome PERF_RECORD_MMAP2 24492/24492: [0x7f7377400000(0x1e00000) @ 0 00:00 0 3474019349355834936]: r-xp //anon PERF_RECORD_MMAP2 24492/24492: [0x7f7379200000(0x48d2000) @ 0x1edc000 fe:00 90623 3474019349355834936]: r-xp /opt/google/chrome/chrome Quipper should combine these into one mapping, or at least replace the "//anon" mapping with a Chrome-named mapping with the proper file offset.
,
Aug 2 2016
in ChromeOS, we only plan for Chrome to do this. However, with ARC++ this may change in the future (not sure when, but not soon). But, better to make it non-chrome specific unless it is too difficult.
,
Aug 2 2016
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5e1b24cbf3d870b12dfc12da75f18738afcbe670 commit 5e1b24cbf3d870b12dfc12da75f18738afcbe670 Author: Simon Que <sque@chromium.org> Date: Thu Jul 28 17:42:47 2016 quipper: Combine split Chrome huge pages mappings Add a new class, HugePagesMappingDeducer that figures out when a single binary is partially mapped with a run of hugepages, thus splitting it into into three ranges. Use this class in PerfParser to replace the split mapping with the original restored mapping. BUG= chromium:633698 TEST=unit tests pass Change-Id: I96537ed9022d4e62a0e23bb478a9ed9851563498 Reviewed-on: https://chromium-review.googlesource.com/366040 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Simon Que <sque@chromium.org> Reviewed-by: Simon Que <sque@chromium.org> [modify] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/perf_parser.cc [add] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/huge_pages_mapping_deducer.h [modify] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/quipper.gyp [add] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/huge_pages_mapping_deducer.cc [add] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/huge_pages_mapping_deducer_test.cc [modify] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/perf_parser.h [modify] https://crrev.com/5e1b24cbf3d870b12dfc12da75f18738afcbe670/chromiumos-wide-profiling/perf_parser_test.cc
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/00f61b3150bcb31316bf2f44f343d429abdff8c9 commit 00f61b3150bcb31316bf2f44f343d429abdff8c9 Author: Simon Que <sque@chromium.org> Date: Tue Aug 09 18:26:33 2016 quipper: Enable huge pages mapping resolution The functionality of split huge pages mapping resolution was added in https://chromium-review.googlesource.com/#/c/366040/. This patch enables it in the quipper executable itself. BUG= chromium:633698 TEST=unit tests pass Change-Id: I106735ccf8772f54d2e1d1a39f3e83fcd3336855 Reviewed-on: https://chromium-review.googlesource.com/367300 Commit-Ready: Simon Que <sque@chromium.org> Tested-by: Simon Que <sque@chromium.org> Reviewed-by: Chong Jiang <chongjiang@chromium.org> [modify] https://crrev.com/00f61b3150bcb31316bf2f44f343d429abdff8c9/chromiumos-wide-profiling/perf_recorder.cc
,
Sep 26 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by sque@chromium.org
, Aug 2 2016