EC: MKBP: Host interrupt isn't cleared when there are no pending events. |
||||||||||||
Issue descriptionI was taking a look at the EC output on Shelley's kevin and discovered that the EC was getting spammed with host commands. The host command was EC_CMD_GET_NEXT_EVENT, but the EC was returning that there were no more events to process. I think that the kernel kept calling the EC for the next event, but there was no more events. However, the EC failed to clear the host interrupt which caused the kernel to continually call down to the EC. I have a fix in place.
,
Aug 3 2016
,
Aug 29 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/108c73bdb2873386e2382cdca9a9dd9dbbd43cd4 commit 108c73bdb2873386e2382cdca9a9dd9dbbd43cd4 Author: Aseda Aboagye <aaboagye@google.com> Date: Mon Feb 13 09:30:22 2017 mkbp: Clear host interrupt if no more events. BUG= chromium:633694 ,chrome-os-partner:60882 BRANCH=veyron TEST=Flash kevin; verify that no more console spam is present on the EC. Original-Change-Id: I240fbe330952b82e2a5f97d0be7ebe4b2a8e2b46 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/365470 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> (cherry picked from commit f5ec39ee0f70ec041eb739f931608e6ee1f96860) Conflicts: common/mkbp_event.c Change-Id: Ia9e641c230538f231b906d73cae548626adf50e6 Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-on: https://chromium-review.googlesource.com/438067 Reviewed-by: Alexandru Stan <amstan@chromium.org> Reviewed-by: Simon Glass <sjg@google.com> [modify] https://crrev.com/108c73bdb2873386e2382cdca9a9dd9dbbd43cd4/common/mkbp_event.c
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 3 2016