Issue metadata
Sign in to add a comment
|
linker warnings in gn (?) windows builds for v8 binaries |
||||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/62339/steps/compile%20%28with%20patch%29/logs/stdio LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/OPT:ICF' specification parser-shell.obj : warning LNK4217: locally defined symbol ?NewFromTwoByte@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBGW4NewStringType@2@H@Z (public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromTwoByte(class v8::Isolate *,unsigned short const *,enum v8::NewStringType,int)) imported in function "struct std::pair<class v8::base::TimeDelta,class v8::base::TimeDelta> __cdecl RunBaselineParser(char const *,enum v8::internal::Encoding,int,class v8::Isolate *,class v8::Local<class v8::Context>)" (?RunBaselineParser@@YA?AU?$pair@VTimeDelta@base@v8@@V123@@std@@PEBDW4Encoding@internal@v8@@HPEAVIsolate@5@V?$Local@VContext@v8@@@5@@Z) parser-shell.obj : warning LNK4217: locally defined symbol ?ToLocalEmpty@V8@v8@@CAXXZ (private: static void __cdecl v8::V8::ToLocalEmpty(void)) imported in function "struct std::pair<class v8::base::TimeDelta,class v8::base::TimeDelta> __cdecl RunBaselineParser(char const *,enum v8::internal::Encoding,int,class v8::Isolate *,class v8::Local<class v8::Context>)" (?RunBaselineParser@@YA?AU?$pair@VTimeDelta@base@v8@@V123@@std@@PEBDW4Encoding@internal@v8@@HPEAVIsolate@5@V?$Local@VContext@v8@@@5@@Z) parser-shell.obj : warning LNK4217: locally defined symbol ?NewExternalOneByte@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEAVExternalOneByteStringResource@12@@Z (public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewExternalOneByte(class v8::Isolate *,class v8::String::ExternalOneByteStringResource *)) imported in function "struct std::pair<class v8::base::TimeDelta,class v8::base::TimeDelta> __cdecl RunBaselineParser(char const *,enum v8::internal::Encoding,int,class v8::Isolate *,class v8::Local<class v8::Context>)" (?RunBaselineParser@@YA?AU?$pair@VTimeDelta@base@v8@@V123@@std@@PEBDW4Encoding@internal@v8@@HPEAVIsolate@5@V?$Local@VContext@v8@@@5@@Z) parser-shell.obj : warning LNK4217: locally defined symbol ?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z (public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)) imported in function "struct std::pair<class v8::base::TimeDelta,class v8::base::TimeDelta> __cdecl RunBaselineParser(char const *,enum v8::internal::Encoding,int,class v8::Isolate *,class v8::Local<class v8::Context>)" (?RunBaselineParser@@YA?AU?$pair@VTimeDelta@base@v8@@V123@@std@@PEBDW4Encoding@internal@v8@@HPEAVIsolate@5@V?$Local@VContext@v8@@@5@@Z) parser-shell.obj : warning LNK4217: locally defined symbol ?SetFlagsFromCommandLine@V8@v8@@SAXPEAHPEAPEAD_N@Z (public: static void __cdecl v8::V8::SetFlagsFromCommandLine(int *,char * *,bool)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?InitializeICUDefaultLocation@V8@v8@@SA_NPEBD0@Z (public: static bool __cdecl v8::V8::InitializeICUDefaultLocation(char const *,char const *)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?InitializePlatform@V8@v8@@SAXPEAVPlatform@2@@Z (public: static void __cdecl v8::V8::InitializePlatform(class v8::Platform *)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Initialize@V8@v8@@SA_NXZ (public: static bool __cdecl v8::V8::Initialize(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?InitializeExternalStartupData@V8@v8@@SAXPEBD@Z (public: static void __cdecl v8::V8::InitializeExternalStartupData(char const *)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ??0ResourceConstraints@v8@@QEAA@XZ (public: __cdecl v8::ResourceConstraints::ResourceConstraints(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?NewDefaultAllocator@Allocator@ArrayBuffer@v8@@SAPEAV123@XZ (public: static class v8::ArrayBuffer::Allocator * __cdecl v8::ArrayBuffer::Allocator::NewDefaultAllocator(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?New@Isolate@v8@@SAPEAV12@AEBUCreateParams@12@@Z (public: static class v8::Isolate * __cdecl v8::Isolate::New(struct v8::Isolate::CreateParams const &)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Enter@Isolate@v8@@QEAAXXZ (public: void __cdecl v8::Isolate::Enter(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ??0HandleScope@v8@@QEAA@PEAVIsolate@1@@Z (public: __cdecl v8::HandleScope::HandleScope(class v8::Isolate *)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?New@ObjectTemplate@v8@@SA?AV?$Local@VObjectTemplate@v8@@@2@PEAVIsolate@2@V?$Local@VFunctionTemplate@v8@@@2@@Z (public: static class v8::Local<class v8::ObjectTemplate> __cdecl v8::ObjectTemplate::New(class v8::Isolate *,class v8::Local<class v8::FunctionTemplate>)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?New@Context@v8@@SA?AV?$Local@VContext@v8@@@2@PEAVIsolate@2@PEAVExtensionConfiguration@2@V?$MaybeLocal@VObjectTemplate@v8@@@2@V?$MaybeLocal@VValue@v8@@@2@@Z (public: static class v8::Local<class v8::Context> __cdecl v8::Context::New(class v8::Isolate *,class v8::ExtensionConfiguration *,class v8::MaybeLocal<class v8::ObjectTemplate>,class v8::MaybeLocal<class v8::Value>)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Enter@Context@v8@@QEAAXXZ (public: void __cdecl v8::Context::Enter(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Exit@Context@v8@@QEAAXXZ (public: void __cdecl v8::Context::Exit(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ??1HandleScope@v8@@QEAA@XZ (public: __cdecl v8::HandleScope::~HandleScope(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Exit@Isolate@v8@@QEAAXXZ (public: void __cdecl v8::Isolate::Exit(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?Dispose@V8@v8@@SA_NXZ (public: static bool __cdecl v8::V8::Dispose(void)) imported in function main parser-shell.obj : warning LNK4217: locally defined symbol ?ShutdownPlatform@V8@v8@@SAXXZ (public: static void __cdecl v8::V8::ShutdownPlatform(void)) imported in function main I believe that's a regression.
,
Aug 3 2016
Hence "gn (?)" in the bug title :-)
,
Aug 8 2016
Related to issue 632082 ?
,
Aug 10 2016
,
Aug 10 2016
,
Aug 10 2016
,
Aug 10 2016
I won't be able to look into this the next few weeks. Rather keeping it available.
,
Aug 22 2016
+marja who wrote parser-shell a while ago. hablich, if machenbach is busy, can you find someone else to look at this? We don't want warnings in out builds, and this has been broken for quite a while by now.
,
Aug 22 2016
Adding Jochen who is also working on GN.
,
Aug 22 2016
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/24cb21e327645f0708dadb8abac473b6f09952cf commit 24cb21e327645f0708dadb8abac473b6f09952cf Author: jochen <jochen@chromium.org> Date: Mon Aug 22 16:50:16 2016 [gn] add missing suppressions for linker warnings on windows When doing a component build, some test binaries link against the object files directly, bypassing the components. This results, however, and rightly so, in linker warnings. In gyp, we just suppressed them. During the transition to gn, this was dropped for two binaries. Here I add the suppressions back in. Long term, we should either change the tests to go through the public API, or export the required symbols. BUG= chromium:633688 R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2261123003 Cr-Commit-Position: refs/heads/master@{#38793} [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/BUILD.gn [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/test/cctest/BUILD.gn
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/24cb21e327645f0708dadb8abac473b6f09952cf commit 24cb21e327645f0708dadb8abac473b6f09952cf Author: jochen <jochen@chromium.org> Date: Mon Aug 22 16:50:16 2016 [gn] add missing suppressions for linker warnings on windows When doing a component build, some test binaries link against the object files directly, bypassing the components. This results, however, and rightly so, in linker warnings. In gyp, we just suppressed them. During the transition to gn, this was dropped for two binaries. Here I add the suppressions back in. Long term, we should either change the tests to go through the public API, or export the required symbols. BUG= chromium:633688 R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2261123003 Cr-Commit-Position: refs/heads/master@{#38793} [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/BUILD.gn [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/test/cctest/BUILD.gn
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/24cb21e327645f0708dadb8abac473b6f09952cf commit 24cb21e327645f0708dadb8abac473b6f09952cf Author: jochen <jochen@chromium.org> Date: Mon Aug 22 16:50:16 2016 [gn] add missing suppressions for linker warnings on windows When doing a component build, some test binaries link against the object files directly, bypassing the components. This results, however, and rightly so, in linker warnings. In gyp, we just suppressed them. During the transition to gn, this was dropped for two binaries. Here I add the suppressions back in. Long term, we should either change the tests to go through the public API, or export the required symbols. BUG= chromium:633688 R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2261123003 Cr-Commit-Position: refs/heads/master@{#38793} [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/BUILD.gn [modify] https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf/test/cctest/BUILD.gn
,
Aug 22 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, Aug 3 2016