new settings UI doesn't allow entering URL patterns anymore |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) open the cookie exceptions (2) click on add (3) enter [*.]google.com What is the expected result? A corresponding pattern is created. What happens instead? Nothing Please provide any additional information below. Attach a screenshot if possible. Version: 54.0.2813.0
,
Aug 8 2016
As currently implemented, [*.] is implied when entering exceptions (google.com -> [*.]google.com). It is a bug, however, that when you enter a pattern it allows you to save it. It shouldn't. I thought the pattern validity check was supposed to catch when you have too many [*.] but that part doesn't seem to work. I'm getting a bit hazy on the details as to why this is so (just got back from vacation), but I think this is to try to fit patterns into this site-centric view of the world. One of the aims is also to simplify the way we expose content settings and I'm not sure how to handle more complex patterns, if those are ever entered (so this was supposed to also avoid those). Maybe that's not the right thing to do (not sure). Haven't given it much thought.
,
Aug 10 2016
,
Aug 23 2016
,
Sep 6 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c8075c0d37d27074caa8c9987a9d03f20d72d03 commit 9c8075c0d37d27074caa8c9987a9d03f20d72d03 Author: finnur <finnur@chromium.org> Date: Thu Sep 08 11:35:52 2016 Site Settings Desktop: Fix issues with entering URL patterns. BUG= 633682 , 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2309283002 Cr-Commit-Position: refs/heads/master@{#417254} [modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/add_site_dialog.js [modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
,
Sep 8 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c8075c0d37d27074caa8c9987a9d03f20d72d03 commit 9c8075c0d37d27074caa8c9987a9d03f20d72d03 Author: finnur <finnur@chromium.org> Date: Thu Sep 08 11:35:52 2016 Site Settings Desktop: Fix issues with entering URL patterns. BUG= 633682 , 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2309283002 Cr-Commit-Position: refs/heads/master@{#417254} [modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/add_site_dialog.js [modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/site_settings_behavior.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by raymes@chromium.org
, Aug 2 2016Owner: finnur@chromium.org
Status: Assigned (was: Untriaged)