New issue
Advanced search Search tips

Issue 633672 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Some pointer event tests need an ID

Project Member Reported by lanwei@chromium.org, Aug 2 2016

Issue description

For some pointer event web platform tests, it is better to have an ID, so we can easily find the right element.

Such as in pointerevent_touch-action-svg-test_touch-manual.html, it is better to have an ID for the 'svg' element. 

pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
.scroller > div div {
            touch-action: none;
            }
We should scroll in this div div area, which does not have an ID.
 
Components: Blink>Input
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67

commit f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67
Author: nzolghadr <nzolghadr@chromium.org>
Date: Tue Sep 06 17:58:36 2016

Use querySelector instead of getElementById

Using querySelector to get the target to do
actions on makes the need for ids go away.

BUG= 633672 

Review-Url: https://codereview.chromium.org/2306103003
Cr-Commit-Position: refs/heads/master@{#416664}

[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_gotpointercapture_before_first_pointerevent-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_for_disconnected_node-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_is_first-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerdown-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_does_not_bubble-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_nohover-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_descendant_over-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_descendants-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_does_not_bubble-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_pen-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_pointertype-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_pen-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_received_once-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerover-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_pen-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_isprimary_same_as_pointerdown-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_pointertype-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_disconnected-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_relatedtarget-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-auto-css_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-keyboard-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-mouse-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual-automation.js
[modify] https://crrev.com/f76de0830d9174a8dfd6fc215c9f0f1dbed0fc67/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-automation.js

Status: Fixed (was: Assigned)

Sign in to add a comment