New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633666 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

exo's output/configure event should be updated for the current primary dislay, not the one stored at boot time.

Project Member Reported by osh...@chromium.org, Aug 2 2016

Issue description

Because primary display can change even with single display.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e65ef4f9318e912eeafa825df938bf4d753a324

commit 2e65ef4f9318e912eeafa825df938bf4d753a324
Author: oshima <oshima@chromium.org>
Date: Wed Aug 03 00:55:00 2016

Use the current primary display to update output/configure.

BUG= 633666 
TEST=tested on samus:
Connect external display  and switch the primary to external using alt-fullscreen. Arc app can move within the external display.

Review-Url: https://codereview.chromium.org/2202343003
Cr-Commit-Position: refs/heads/master@{#409407}

[modify] https://crrev.com/2e65ef4f9318e912eeafa825df938bf4d753a324/components/exo/wayland/server.cc

Labels: Merge-Rejected-53
Labels: -Merge-Rejected-53 Merge-Request-53
I assume this is supposed to be merge-requested?
doh, yes. thank you for fixing.
Repro step:

1) Start arc apps.
2) Connect external display
3) Switch primary display to external (atl-fullscreen)

Expected: you can use arc window in external dislay
Actual: the window can be clipped by the size of the internal display.

 

Comment 6 by dimu@chromium.org, Aug 3 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 4 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56c873348ebabf4b459a979cd3b579f5659ec369

commit 56c873348ebabf4b459a979cd3b579f5659ec369
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Aug 04 01:44:37 2016

Use the current primary display to update output/configure.

BUG= 633666 
TEST=tested on samus:
Connect external display  and switch the primary to external using alt-fullscreen. Arc app can move within the external display.

Review-Url: https://codereview.chromium.org/2202343003
Cr-Commit-Position: refs/heads/master@{#409407}
(cherry picked from commit 2e65ef4f9318e912eeafa825df938bf4d753a324)

Review URL: https://codereview.chromium.org/2207313002 .

Cr-Commit-Position: refs/branch-heads/2785@{#496}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/56c873348ebabf4b459a979cd3b579f5659ec369/components/exo/wayland/server.cc

Status: Fixed (was: Started)

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment