Able to delete active language
Reported by
dennis.m...@gmail.com,
Aug 2 2016
|
|||||
Issue descriptionWhat steps will reproduce the problem? (1) my language was set to english US (2) I deleted the languages English US, English ... and left German in there. (3) When i saved it the overall language says English US, and the only language listed is German? What is the expected result? The language changing to German What happens instead? the language stayed English US Please provide any additional information below. Attach a screenshot if possible. Version: 54.0.2815.0
,
Aug 10 2016
,
Dec 12 2016
,
Dec 13 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cb2126002cd187035ba90ee13ebda77e16d81f6 commit 4cb2126002cd187035ba90ee13ebda77e16d81f6 Author: michaelpg <michaelpg@chromium.org> Date: Wed Dec 14 02:46:48 2016 Language settings: Fix Restart and Remove buttons shown at wrong times Language settings makes the faulty assumption that the app locale (navigator.language) will match the the preferred app locale (intl.app_locale). For some languages, we map a language code to a different locale. For example, en-ZA is mapped to en-GB when getting the application locale, so the preference won't match the actual locale used. See l10n_util::CheckAndResolveLocale for other wacky examples. Stop using navigator.language when the intl.app_locale pref is available. Also move more logic into the model and stop checking intl.app_locale in the UI. Use a more defensive check for the Restart button: show if the locale preference has changed from its initial value. BUG= 561227 , 649588 , 633661 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573643005 Cr-Commit-Position: refs/heads/master@{#438403} [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_types.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/ui/webui/settings/languages_handler.cc [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/ui/webui/settings/languages_handler.h [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/test/data/webui/settings/languages_tests.js
,
Dec 17 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tbuck...@chromium.org
, Aug 10 2016Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)