Add a chrome:flags flag for launching in mash |
|||||||||||||
Issue descriptionWe want to add a flag in chrome:flags page so that it is possible for users to switch to this mode (and switch back if needed). Apart from the obvious code changes, we would need to update deploy_chrome to push the mojo apps onto the device by default, and make sure the mojo apps are included in the updated pushed to users.
,
Sep 14 2016
I would *love* for this to get resolved before the end of the quarter. If Xiyuan won't have time before then I can take it.
,
Sep 14 2016
+xiyuan
,
Sep 14 2016
This hasn't happened yet. I have some local changes I haven't had a chance to try on a device yet. I should be able to have some update by the end of the week.
,
Sep 14 2016
ima bump up the p
,
Sep 15 2016
OK, looks like things mostly work. There's currently a startup-crash that gets in the way of chrome (the rest of the things, e.g. ash, quick-launcher etc. do launch OK though). Investigating farther ...
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e835de462f99529c7312b49926e2f0a67aa36e commit 59e835de462f99529c7312b49926e2f0a67aa36e Author: sadrul <sadrul@chromium.org> Date: Thu Sep 22 00:59:15 2016 chromeos: Add a flag to launch with --mash. Add a flag in chrome:flags to turn on the mojo ui service. The caveat is that it works OK (as in, you can successfully login) if a secondary user on the device turns on the flag. If the primary user/owner turns the flag on, then the flag is used in the login screen as well, and that does not work well yet. Even though secondary/non-owner users can turn the flag on and login, and see the chrome browser window (and other mus apps) without getting immediate crashes, a number of things are still in progress, and not implemented yet. So there are a number of missing features, and is somewhat unstable. BUG= 633656 Review-Url: https://codereview.chromium.org/2359483003 Cr-Commit-Position: refs/heads/master@{#420219} [modify] https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e/chrome/app/chrome_main.cc [modify] https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e/chrome/app/generated_resources.grd [modify] https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e/chrome/browser/about_flags.cc [modify] https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e/tools/metrics/histograms/histograms.xml
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/147eb671278ecc4eec6d87973cb15eaa33d19a6d commit 147eb671278ecc4eec6d87973cb15eaa33d19a6d Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Sep 16 14:24:04 2016 deploy_chrome: Fix deploying mash. . 'mojo_runner' is not needed on device for mustash. . The .library files are not needed for 'chrome --mash'. For mojo/mus apps, the build generates .library files, and other files (e.g. manifest, resources etc.) used by the app in the Packages/ directory. However, when running on device (using 'chrome --mash'), it is not necessary to have the .library files, while the rest of the files are still needed. To facilitate this, allow specifying a blacklist when creating a Path() object, and use this blacklist to exclude the .library files from being sent to device. The Copier() object currently has a blacklist, but it is never set. So move the default blacklist from Copier to Path object as well. BUG= 644408 , 633656 Change-Id: Ifc1fd33882b6b97db81af0a0ba7479873c4c0950 Reviewed-on: https://chromium-review.googlesource.com/386417 Commit-Ready: Sadrul Chowdhury <sadrul@chromium.org> Tested-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/147eb671278ecc4eec6d87973cb15eaa33d19a6d/lib/chrome_util.py
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a570def6dbb73675bdbee3766e636f0f2218439 commit 6a570def6dbb73675bdbee3766e636f0f2218439 Author: sadrul <sadrul@chromium.org> Date: Tue Oct 04 03:44:27 2016 chrome/mash: Load resources before running the mus app. When running 'chrome --mash' on device, all the resource files necessary for ash, mus etc. apps are already in the resource files used for regular chrome. So instead of deploying separate resource files for these apps, just load chrome's resource files, before initializing the app. BUG= 628715 , 633656 Review-Url: https://codereview.chromium.org/2387233002 Cr-Commit-Position: refs/heads/master@{#422694} [modify] https://crrev.com/6a570def6dbb73675bdbee3766e636f0f2218439/chrome/app/mash/mash_runner.cc [modify] https://crrev.com/6a570def6dbb73675bdbee3766e636f0f2218439/ui/views/mus/aura_init.cc
,
Oct 4 2016
,
Oct 4 2016
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d6cf1148b63673422e189bbae74e6be60084afbe commit d6cf1148b63673422e189bbae74e6be60084afbe Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Thu Oct 06 20:30:34 2016 deploy_chrome: Remove special handling for mash It is no longer necessary to dispatch the resources for the mus apps either. All that are needed are the manifest files for chrome, content etc. Deploy them by default instead. BUG= 633656 Change-Id: I4f9acd61137c6fdda6280198257d69fb39078549 Reviewed-on: https://chromium-review.googlesource.com/394827 Commit-Ready: Sadrul Chowdhury <sadrul@chromium.org> Tested-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/d6cf1148b63673422e189bbae74e6be60084afbe/scripts/deploy_chrome.py [modify] https://crrev.com/d6cf1148b63673422e189bbae74e6be60084afbe/lib/chrome_util.py
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/977aef789bec4cd9bf9e66a17d29f0f3cbf6a3dd commit 977aef789bec4cd9bf9e66a17d29f0f3cbf6a3dd Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Nov 21 21:30:37 2016 deploy_chrome: Remove special handling for mash It is no longer necesasry to dispatch the resources for the mus apps. All that are needed are the manifest files for chrome, content etc. Deploy by them default instead (optinally, when available). BUG= 633656 Change-Id: I86dea87cc6e5f8da277acf3d135df4845fa95359 Reviewed-on: https://chromium-review.googlesource.com/413110 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/977aef789bec4cd9bf9e66a17d29f0f3cbf6a3dd/scripts/deploy_chrome.py [modify] https://crrev.com/977aef789bec4cd9bf9e66a17d29f0f3cbf6a3dd/lib/chrome_util.py
,
Dec 9 2016
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Feb 26 2018
,
Feb 26 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by jamescook@chromium.org
, Sep 14 2016