New issue
Advanced search Search tips

Issue 633650 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 632141



Sign in to add a comment

GN: actions depending on shared libraries should depend on all outputs

Project Member Reported by brettw@chromium.org, Aug 2 2016

Issue description

Shared libraries have an optimization for linking where the build dependency is on the .lib/.TOC file that only changes when the exports are changed. This prevents unnecessary rebuilds of dependent executables and shared libraries, which don't need to be relinked unless the shared library exports change.

But GN also applies this rule to actions depending on the shared library. An example is remoting_me2me_host_archive which depends on the remoting_core shared library. The action should be re-run any time the shared library is changed, not just when its exports change.

So basically actions should depend on all outputs of a shared library (or maybe the first one?), not just the "depend_output" listed in the tool.
 
Labels: -Pri-2 Pri-3
This is very low priority since as long as actions list their inputs 9possibly including .so or .dll files), the actual dependency file GN generates implicitly won't matter.
Blocking: 632141
Components: Build
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold

Sign in to add a comment