New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633641 link

Starred by 3 users
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Aug 2016
Cc:
yosin@chromium.org
█ groby@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Grammar decoration is not drawing when "Ask Google for suggestions" is enabled

Project Member Reported by rouslan@chromium.org, Aug 2 2016 
Chrome Version: 54.0.2817.0

What steps will reproduce the problem?
1. Set "English (US)" as spellcheck language.
2. Enable "Ask Google for suggestions" in the right-click menu.
3. Type "data:text/html,<textarea>" in the address bar.
4. Type "How doe sit know that Icland is an icland " in the text area.

What is the expected result?
"doe sit" should have a gray (grammar) underline. Right-click on "doe sit" should select the phrase and show "does it" as a spelling suggestion.

What happens instead of that?
"doe sit" is not underlined. Right-click on "doe sit" does not show spelling suggestions.

Please provide any additional information below. Attach a screenshot if
possible.

Last known good revision is 54.0.2810.2.

Note that "Ask Google for suggestions" is working correctly, as evidenced by "Icland" having red underline with "Iceland" suggestion, whereas "icland" has red underline with "island" suggestion. Different suggestions for the same word (sans capitalization) indicates that "Ask Google for suggestions" is at work here. The underline is red, however, because "icland" is also not in the local "English (US)" hunspell dictionary.

Assigning to someone that has worked with grammar/spellcheck.
chrome-54.0.2817.0.png
15.8 KB View Download
chrome-54.0.2810.2.png
13.9 KB View Download

Comment 1 by yosin@chromium.org, Aug 3 2016

Labels: OS-Windows
Does this mean Chrome support grammar checking?
We're removing grammar checking feature from Blink now.

Comment 2 by rouslan@chromium.org, Aug 3 2016 

Chrome supports contextual spellcheck through Google's servers. You can enabled it via "Ask Google for suggestions" in right-click menu and "Use a web service to help resolve spelling errors" in chrome://settings. In my understanding, Chrome is using Blink's gray "grammar" markers to display results that come from the server. I think you are OK to remove a bunch of grammar code in Blink, but please make sure that gray "grammar" markers are still drawn. Here's the code in Chrome that uses the gray "grammar" markers:

https://cs.chromium.org/chromium/src/chrome/renderer/spellchecker/spellcheck.cc?rcl=0&l=526

Comment 3 by xiaoche...@chromium.org, Aug 4 2016

Status: Started (was: Available)
Whoops, I screwed up.

I'll revert my patches related to grammar checking in the past two weeks.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a0304640b77b4fdddcccf35bc26cca7ed87ace

commit c5a0304640b77b4fdddcccf35bc26cca7ed87ace
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Aug 04 08:24:26 2016

Revert of Remove hasGrammarMarker from internals (patchset #1 id:1 of https://codereview.chromium.org/2191803002/ )

Reason for revert:
Blink may still draw grammar markers when "Ask Google for suggestion" is checked, so testing of grammar markers should not be removed.

BUG= 633641 
TBR=yosin@chromium.org, tkent@chromium.org

Original issue's description:
> Remove hasGrammarMarker from internals
>
> BUG= 619452 
> TEST=n/a; no behavior change
>
> Committed: https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075
> Cr-Commit-Position: refs/heads/master@{#408541}

TBR=yosin@chromium.org,tkent@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 619452 

Review-Url: https://codereview.chromium.org/2210863002
Cr-Commit-Position: refs/heads/master@{#409740}

[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.idl
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580e9d52a44e15cc8e92673fc763cb47caa3717e

commit 580e9d52a44e15cc8e92673fc763cb47caa3717e
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Aug 04 11:52:58 2016

Revert removal of grammar checking and marking code

This is a manual revert of the following commits:

Revert "Remove layout tests only for grammar checking"
This reverts commit 32de271fb02024450856b9a5dcfbe42609739224.

Revert "Remove grammar checking from layout tests, and MockGrammarCheck"
This reverts commit 57b84ed8f4c1df5564ae573459287ce55569dab3.

Revert "Auto-rebaseline for r408347"
This reverts commit b8af511d0bb6a78352b434c4dede88f9348650c6.

Revert "Remove expectation images incorrectly added by autorebaseline bot"
This reverts commit 537eb21a213e933eadc4cb5261bd33f5b895d08d.

Revert "Remove grammar marker inspection from WebFrameTest"
This reverts commit ca4b6d233d131487b752e5c92ff16f56779b3f7a.

Revert "Stop TextCheckingHelper from checking grammar"
This reverts commit 068b312e9d944f8fdb4090355b93ab3e87f9a99b.

Revert "Hide some member functions of SpellChecker as private"
This reverts commit 01554f3c62b7725817c766dd620e302fcdad6e00.

Revert "Remove some grammar checking code from SpellChecker"
This reverts commit 9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2.

Revert "Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges"
This reverts commit 91ca178d41af494fd444fad6a44202d1d31388c6.

Revert "Remove some further grammar checking code from SpellChecker"
This reverts commit 579c127d36de5035a5084b9aa88697f18b0a4552.

Revert "Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar"
This reverts commit 0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9.

Revert "Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar"
This reverts commit 7095e1641402c57f32d2cc952b4357af13ff8dfc.

Revert "Cleanup function names in SpellChecker and TextCheckingHelper"
This reverts commit a10daeeca303db977aa23218f2ac71abbb2eaa2e.

BUG= 619452 , 633641 
TBR=yosin@chromium.org, tkent@chromium.org

Review-Url: https://codereview.chromium.org/2211813002
Cr-Commit-Position: refs/heads/master@{#409763}

[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/BUILD.gn
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/mock_grammar_check.cc
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/mock_grammar_check.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/test_runner.gyp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/markers-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/markers.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/platform/text/TextCheckerClient.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 6 by rouslan@chromium.org, Aug 4 2016 

Works on trunk now. Thank you!
Screenshot from 2016-08-04 10:20:33.png
15.9 KB View Download

Comment 7 by xiaoche...@chromium.org, Aug 5 2016

Status: Fixed (was: Started)

Comment 8 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment