New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633639 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

EC: cleanup: Consider moving board-level callback protypes to common headers

Project Member Reported by sha...@chromium.org, Aug 2 2016

Issue description

In many cases, we have board-defined callback functions (called from common code) without prototypes in common header files, so the prototype must be defined in board.h. eg:

board_get_battery_soc()
board_reset_pd_mcu()

Shall we move these prototypes to common header files? Or maybe even a new header file, "board_callbacks.h"?

 
I'd say in the common header files for their respective modules, with the note that they are to be implemented in the board folder and are called from the module.
Owner: caveh@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by caveh@chromium.org, Jun 23 2017

Labels: -Type-Bug Type-Task

Sign in to add a comment