New issue
Advanced search Search tips

Issue 633637 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SVGImage::imageForCurrentFrameForContainer() does not respect the container size

Project Member Reported by fmalita@chromium.org, Aug 2 2016

Issue description

Should return an SkImage matching the container size, not the embedded SVG size.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8148eedf1595dab9ec126e3e20403bad53021db9

commit 8148eedf1595dab9ec126e3e20403bad53021db9
Author: fmalita <fmalita@chromium.org>
Date: Thu Aug 04 18:59:45 2016

Fix SVGImage::imageForCurrentFrameForContainer() sizing

SVGImageForContainer implements the Image interface, and reports a size
equal to the container size.

But its imageForCurrentFrame() implementation delegates to
SVGImage::imageForCurrentFrameForContainer(), which currently returns an
SkImage with a size equal to the SVG intrinsic size.

This mismatch between the size reported by SVGImageForContainer and the
size of the SkImage returned by its imageForCurrentFrame() is causing
problems when tiling.

The CL updates SVGImage::imageForCurrentFrameForContainer() to return an
SkImage reflecting the container size instead of intrinsic size.

New pixel test: fast/backgrounds/background-svg-scaling.html

BUG= 632969 , 633637 
R=schenney@chromium.org, pdr@chromium.org, fs@opera.com

Review-Url: https://codereview.chromium.org/2203093003
Cr-Commit-Position: refs/heads/master@{#409853}

[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/fast/backgrounds/background-svg-scaling.html
[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html
[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Status: Fixed (was: Started)

Sign in to add a comment